Shiloh/brotherton-erpnext
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

fix: Linting and test cases

Browse Source
This commit is contained in:
Deepesh Garg 2020-11-17 11:10:00 +05:30
parent 4bd52b4842
commit 6456c3dc24
3 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py
View File

@ -75,14 +75,14 @@ def create_dimension():
frappe.set_user("Administrator")
if not frappe.db.exists("Accounting Dimension", {"document_type": "Department"}):
dimension = frappe.get_doc({
frappe.get_doc({
"doctype": "Accounting Dimension",
"document_type": "Department",
}).insert()
else:
dimension1 = frappe.get_doc("Accounting Dimension", "Department")
dimension1.disabled = 0
dimension1.save()
dimension = frappe.get_doc("Accounting Dimension", "Department")
dimension.disabled = 0
dimension.save()
if not frappe.db.exists("Accounting Dimension", {"document_type": "Location"}):
dimension1 = frappe.get_doc({

4
erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.js
View File

@ -8,7 +8,7 @@ frappe.ui.form.on('Accounting Dimension Filter', {
filters : {
'company': frm.doc.company
}
}
};
});
frappe.db.get_list('Accounting Dimension',
@ -41,7 +41,7 @@ frappe.ui.form.on('Accounting Dimension Filter', {
frm.set_query('dimension_value', 'dimensions', function() {
return {
filters: filters
}
};
});
}
});

3
erpnext/accounts/doctype/accounting_dimension_filter/test_accounting_dimension_filter.py
View File

@ -10,6 +10,7 @@ from erpnext.accounts.doctype.accounting_dimension.test_accounting_dimension imp
class TestAccountingDimensionFilter(unittest.TestCase):
def setUp(self):
create_dimension()
create_accounting_dimension_filter()
def test_allowed_dimension_validation(self):
@ -42,7 +43,7 @@ def create_accounting_dimension_filter():
}],
'dimensions': [{
'accounting_dimension': 'Cost Center',
'dimension_value': '_Test Cost Center 3 - _TC'
'dimension_value': '_Test Cost Center 2 - _TC'
}]
}).insert()
else: