From 6456c3dc244c0b294748707ed08e558826f3ab65 Mon Sep 17 00:00:00 2001
From: Deepesh Garg <deepeshgarg6@gmail.com>
Date: Tue, 17 Nov 2020 11:10:00 +0530
Subject: [PATCH] fix: Linting and test cases

---
 .../accounting_dimension/test_accounting_dimension.py     | 8 ++++----
 .../accounting_dimension_filter.js                        | 4 ++--
 .../test_accounting_dimension_filter.py                   | 3 ++-
 3 files changed, 8 insertions(+), 7 deletions(-)

diff --git a/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py b/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py
index b5375e106f..fc1d7e344a 100644
--- a/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py
+++ b/erpnext/accounts/doctype/accounting_dimension/test_accounting_dimension.py
@@ -75,14 +75,14 @@ def create_dimension():
 	frappe.set_user("Administrator")
 
 	if not frappe.db.exists("Accounting Dimension", {"document_type": "Department"}):
-		dimension = frappe.get_doc({
+		frappe.get_doc({
 			"doctype": "Accounting Dimension",
 			"document_type": "Department",
 		}).insert()
 	else:
-		dimension1 = frappe.get_doc("Accounting Dimension", "Department")
-		dimension1.disabled = 0
-		dimension1.save()
+		dimension = frappe.get_doc("Accounting Dimension", "Department")
+		dimension.disabled = 0
+		dimension.save()
 
 	if not frappe.db.exists("Accounting Dimension", {"document_type": "Location"}):
 		dimension1 = frappe.get_doc({
diff --git a/erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.js b/erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.js
index c8c32d58bd..994ee44354 100644
--- a/erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.js
+++ b/erpnext/accounts/doctype/accounting_dimension_filter/accounting_dimension_filter.js
@@ -8,7 +8,7 @@ frappe.ui.form.on('Accounting Dimension Filter', {
 				filters : {
 					'company': frm.doc.company
 				}
-			}
+			};
 		});
 
 		frappe.db.get_list('Accounting Dimension',
@@ -41,7 +41,7 @@ frappe.ui.form.on('Accounting Dimension Filter', {
 				frm.set_query('dimension_value', 'dimensions', function() {
 					return {
 						filters: filters
-					}
+					};
 				});
 			}
 		});
diff --git a/erpnext/accounts/doctype/accounting_dimension_filter/test_accounting_dimension_filter.py b/erpnext/accounts/doctype/accounting_dimension_filter/test_accounting_dimension_filter.py
index feb0af1bd5..02fd75e759 100644
--- a/erpnext/accounts/doctype/accounting_dimension_filter/test_accounting_dimension_filter.py
+++ b/erpnext/accounts/doctype/accounting_dimension_filter/test_accounting_dimension_filter.py
@@ -10,6 +10,7 @@ from erpnext.accounts.doctype.accounting_dimension.test_accounting_dimension imp
 
 class TestAccountingDimensionFilter(unittest.TestCase):
 	def setUp(self):
+		create_dimension()
 		create_accounting_dimension_filter()
 
 	def test_allowed_dimension_validation(self):
@@ -42,7 +43,7 @@ def create_accounting_dimension_filter():
 			}],
 			'dimensions': [{
 				'accounting_dimension': 'Cost Center',
-				'dimension_value': '_Test Cost Center 3 - _TC'
+				'dimension_value': '_Test Cost Center 2 - _TC'
 			}]
 		}).insert()
 	else: