Shiloh/brotherton-erpnext
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity

[event] [fix] commonified delete_events method, which is executed before auto-creation of events. Fixed delete issue

Browse Source
This commit is contained in:
Anand Doshi 2013-06-17 12:51:36 +05:30
parent ad6180ef6d
commit 11d311376e
4 changed files with 14 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
patches/june_2013/p04_fix_event_for_lead_oppty_project.py
View File

@ -1,6 +1,8 @@
import webnotes
def execute():
from utilities.transaction_base import delete_events
# delete orphaned Event User
webnotes.conn.sql("""delete from `tabEvent User`
where not exists(select name from `tabEvent` where `tabEvent`.name = `tabEvent User`.parent)""")
@ -15,5 +17,4 @@ def execute():
webnotes.get_obj(dt, ref_name).add_calendar_event()
else:
# remove events where ref doc doesn't exist
webnotes.delete_doc("Event", webnotes.conn.sql_list("""select name from `tabEvent`
where ref_type=%s and ref_name=%s""", (dt, ref_name)))
delete_events(dt, ref_name)

9
projects/doctype/project/project.py
View File

@ -19,6 +19,7 @@ import webnotes
from webnotes.utils import flt, getdate
from webnotes import msgprint
from utilities.transaction_base import delete_events
class DocType:
def __init__(self, doc, doclist=None):
@ -69,7 +70,7 @@ class DocType:
def add_calendar_event(self):
# delete any earlier event for this project
self.delete_events()
delete_events(self.doc.doctype, self.doc.name)
# add events
for milestone in self.doclist.get({"parentfield": "project_milestones"}):
@ -87,8 +88,4 @@ class DocType:
}).insert()
def on_trash(self):
self.delete_events()
def delete_events(self):
webnotes.delete_doc("Event", webnotes.conn.sql_list("""select name from `tabEvent`
where ref_type=%s and ref_name=%s""", (self.doc.doctype, self.doc.name)))
delete_events(self.doc.doctype, self.doc.name)

12
support/doctype/maintenance_schedule/maintenance_schedule.py
View File

@ -26,7 +26,7 @@ from webnotes import msgprint
sql = webnotes.conn.sql
from utilities.transaction_base import TransactionBase
from utilities.transaction_base import TransactionBase, delete_events
class DocType(TransactionBase):
def __init__(self, doc, doclist=[]):
@ -327,13 +327,7 @@ class DocType(TransactionBase):
if d.serial_no:
self.update_amc_date(d.serial_no, '')
webnotes.conn.set(self.doc, 'status', 'Cancelled')
self.delete_events()
delete_events(self.doc.doctype, self.doc.name)
def on_trash(self):
self.delete_events()
def delete_events(self):
webnotes.delete_doc("Event", webnotes.conn.sql_list("""select name from `tabEvent`
where ref_type=%s and ref_name=%s""", (self.doc.doctype, self.doc.name)))
delete_events(self.doc.doctype, self.doc.name)

5
utilities/transaction_base.py
View File

@ -303,3 +303,8 @@ class TransactionBase(DocListController):
})
webnotes.bean(event_doclist).insert()
def delete_events(ref_type, ref_name):
webnotes.delete_doc("Event", webnotes.conn.sql_list("""select name from `tabEvent`
where ref_type=%s and ref_name=%s""", (ref_type, ref_name)), for_reload=True)