linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity
githaven-fork/services
History
Nanguan Lin 49b98e45bc
Fix migration panic due to an empty review comment diff (#28334) 
Fix #28328 
```
func (p *PullRequestComment) GetDiffHunk() string {
	if p == nil || p.DiffHunk == nil {
		return ""
	}
	return *p.DiffHunk
}
```
This function in the package `go-github` may return an empty diff. When
it's empty, the following code will panic because it access `ss[1]`

ec1feedbf5/services/migrations/gitea_uploader.go (L861-L867)

ec1feedbf5/modules/git/diff.go (L97-L101)
2023-12-05 08:29:43 +00:00
..
actions
Use db.Find instead of writing methods for every object (#28084)
2023-11-24 03:49:41 +00:00
agit
Penultimate round of db.DefaultContext refactor (#27414)
2023-10-11 04:24:07 +00:00
asymkey
Use db.Find instead of writing methods for every object (#28084)
2023-11-24 03:49:41 +00:00
attachment
Even more db.DefaultContext refactor (#27352)
2023-10-03 10:30:41 +00:00
auth
Use db.Find instead of writing methods for every object (#28084)
2023-11-24 03:49:41 +00:00
automerge
Improve queue and logger context (#24924)
2023-05-26 07:31:55 +00:00
context
Another round of db.DefaultContext refactor (#27103)
2023-09-25 13:17:37 +00:00
convert
Fix package webhook (#27839)
2023-10-31 04:43:38 +00:00
cron
Improve retrying index issues (#27554)
2023-10-15 18:56:57 +00:00
externalaccount
Final round of db.DefaultContext refactor (#27587)
2023-10-14 08:37:24 +00:00
feed
More db.DefaultContext refactor (#27265)
2023-09-29 12:12:54 +00:00
forms
Fix required error for token name (#28267)
2023-11-29 03:47:05 +00:00
gitdiff
Even more db.DefaultContext refactor (#27352)
2023-10-03 10:30:41 +00:00
indexer
Fix missing issue search index update when changing status (#28325)
2023-12-03 12:22:44 +01:00
issue
Penultimate round of db.DefaultContext refactor (#27414)
2023-10-11 04:24:07 +00:00
lfs
Bump github.com/golang-jwt/jwt to v5 (#25975)
2023-07-19 09:57:10 +00:00
mailer
Fix missing mail reply address (#27997)
2023-11-13 03:20:34 +00:00
markup
make writing main test easier (#27270)
2023-09-28 01:38:53 +00:00
migrations
Fix migration panic due to an empty review comment diff (#28334)
2023-12-05 08:29:43 +00:00
mirror
Even more db.DefaultContext refactor (#27352)
2023-10-03 10:30:41 +00:00
notify
Update status and code index after changing the default branch (#27018)
2023-09-13 04:43:31 +00:00
org
Delete repos of org when purge delete user (#27273)
2023-10-19 13:16:11 +00:00
packages
Fix RPM/Debian signature key creation (#28352)
2023-12-05 00:48:01 +00:00
pull
Use db.Find instead of writing methods for every object (#28084)
2023-11-24 03:49:41 +00:00
release
Fix comment permissions (#28213)
2023-11-25 17:21:21 +00:00
repository
Make pushUpdate error verbose (#28263)
2023-11-30 00:46:51 +00:00
secrets
Use db.Find instead of writing methods for every object (#28084)
2023-11-24 03:49:41 +00:00
task
Fix incorrect ctx usage in defer function (#27740)
2023-10-22 14:12:27 +00:00
uinotification
Penultimate round of db.DefaultContext refactor (#27414)
2023-10-11 04:24:07 +00:00
user
Use db.Find instead of writing methods for every object (#28084)
2023-11-24 03:49:41 +00:00
webhook
Use db.Find instead of writing methods for every object (#28084)
2023-11-24 03:49:41 +00:00
wiki
Even more db.DefaultContext refactor (#27352)
2023-10-03 10:30:41 +00:00