githaven-fork/templates/repo/diff
confusedsushi f6f4e1ddb9
Fix review excerpt (#18502)
Currently the "File Changed" tab of a PR is somehow broken. This is also true for the current release 1.16.0.

When you are on the "File Changed" tab, and want to look at code excerpt before or after the code changes, the layout breaks. You can test this on try.gitea.io here: https://try.gitea.io/testnotexisting/magic_enum/pulls/2/files

The problem occurs for the unified view and for the split view.

Kind of the same problem was there for commenting a line of code, this was fixed in #18321 and #18403.

For consistency, I changed the solution of #18321, I removed the ``colspan`` and instead added a ``<td>``. The goal was to have code similarly with the split view.

Also the separator line in the split view was in the wrong column, this was fixed too.* more consistent unified review comment

Fix #18516

Co-authored-by: Andrew Thornton <art27@cantab.net>
2022-02-01 19:08:33 +00:00
..
blob_excerpt.tmpl Fix review excerpt (#18502) 2022-02-01 19:08:33 +00:00
box.tmpl Add warning for BIDI characters in page renders and in diffs (#17562) 2022-01-07 02:18:52 +01:00
comment_form_datahandler.tmpl Pull request review/approval and comment on code (#3748) 2018-08-06 06:43:21 +02:00
comment_form.tmpl Refactor repo-legacy.js, remove messy global variables. Fix errors. (#17646) 2021-11-19 00:45:00 +08:00
comments.tmpl Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
compare.tmpl Improve interface when comparing a branch which has created a pull request (#17911) 2021-12-24 12:14:42 +00:00
conversation.tmpl Fix previous/next button size (#16284) 2021-06-28 21:36:09 +02:00
csv_diff.tmpl Prevent NPE in CSV diff rendering when column removed (#17018) 2021-10-20 20:10:03 +01:00
image_diff.tmpl Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
new_comment.tmpl Do not reload page after adding comments in Pull Request reviews (#13877) 2021-01-08 23:49:55 +02:00
new_review.tmpl Add attachments for PR reviews (#16075) 2021-06-14 21:12:33 -04:00
options_dropdown.tmpl Multiple Escaping Improvements (#17551) 2021-11-16 18:18:25 +00:00
section_split.tmpl Add warning for BIDI characters in page renders and in diffs (#17562) 2022-01-07 02:18:52 +01:00
section_unified.tmpl Add warning for BIDI characters in page renders and in diffs (#17562) 2022-01-07 02:18:52 +01:00
stats.tmpl Cleanup and use global style on popups (#17674) 2021-11-18 11:26:50 +08:00
whitespace_dropdown.tmpl Comment box tweaks and SVG dropdown triangles (#13376) 2020-10-31 18:15:11 -04:00