githaven-fork/routers
wxiaoguang ee242a08e9
Refactor issue template parsing and fix API endpoint (#29069)
The old code `GetTemplatesFromDefaultBranch(...) ([]*api.IssueTemplate,
map[string]error)` doesn't really follow Golang's habits, then the
second returned value might be misused. For example, the API function
`GetIssueTemplates` incorrectly checked the second returned value and
always responds 500 error.

This PR refactors GetTemplatesFromDefaultBranch to
ParseTemplatesFromDefaultBranch and clarifies its behavior, and fixes the
API endpoint bug, and adds some tests.

And by the way, add proper prefix `X-` for the header generated in
`checkDeprecatedAuthMethods`, because non-standard HTTP headers should
have `X-` prefix, and it is also consistent with the new code in
`GetIssueTemplates`
2024-02-12 05:04:10 +00:00
..
api Refactor issue template parsing and fix API endpoint (#29069) 2024-02-12 05:04:10 +00:00
common Rework markup link rendering (#26745) 2024-01-15 08:49:24 +00:00
install Enhanced auth token / remember me (#27606) 2023-10-14 00:56:41 +00:00
private Simplify how git repositories are opened (#28937) 2024-01-27 21:09:51 +01:00
utils Improve user search display name (#29002) 2024-02-01 17:10:16 +00:00
web Refactor issue template parsing and fix API endpoint (#29069) 2024-02-12 05:04:10 +00:00
init.go Allow to sync tags from admin dashboard (#28045) 2024-01-24 03:02:04 +00:00