forked from Shiloh/githaven
1e76a824bc
Fix #24662. Replace #24822 and #25708 (although it has been merged) ## Background In the past, Gitea supported issue searching with a keyword and conditions in a less efficient way. It worked by searching for issues with the keyword and obtaining limited IDs (as it is heavy to get all) on the indexer (bleve/elasticsearch/meilisearch), and then querying with conditions on the database to find a subset of the found IDs. This is why the results could be incomplete. To solve this issue, we need to store all fields that could be used as conditions in the indexer and support both keyword and additional conditions when searching with the indexer. ## Major changes - Redefine `IndexerData` to include all fields that could be used as filter conditions. - Refactor `Search(ctx context.Context, kw string, repoIDs []int64, limit, start int, state string)` to `Search(ctx context.Context, options *SearchOptions)`, so it supports more conditions now. - Change the data type stored in `issueIndexerQueue`. Use `IndexerMetadata` instead of `IndexerData` in case the data has been updated while it is in the queue. This also reduces the storage size of the queue. - Enhance searching with Bleve/Elasticsearch/Meilisearch, make them fully support `SearchOptions`. Also, update the data versions. - Keep most logic of database indexer, but remove `issues.SearchIssueIDsByKeyword` in `models` to avoid confusion where is the entry point to search issues. - Start a Meilisearch instance to test it in unit tests. - Add unit tests with almost full coverage to test Bleve/Elasticsearch/Meilisearch indexer. --------- Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
42 lines
1.0 KiB
Go
42 lines
1.0 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package internal
|
|
|
|
import (
|
|
"math"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
)
|
|
|
|
// ParsePaginator parses a db.Paginator into a skip and limit
|
|
func ParsePaginator(paginator db.Paginator, max ...int) (int, int) {
|
|
// Use a very large number to indicate no limit
|
|
unlimited := math.MaxInt32
|
|
if len(max) > 0 {
|
|
// Some indexer engines have a limit on the page size, respect that
|
|
unlimited = max[0]
|
|
}
|
|
|
|
if paginator == nil || paginator.IsListAll() {
|
|
return 0, unlimited
|
|
}
|
|
|
|
// Warning: Do not use GetSkipTake() for *db.ListOptions
|
|
// Its implementation could reset the page size with setting.API.MaxResponseItems
|
|
if listOptions, ok := paginator.(*db.ListOptions); ok {
|
|
if listOptions.Page >= 0 && listOptions.PageSize > 0 {
|
|
var start int
|
|
if listOptions.Page == 0 {
|
|
start = 0
|
|
} else {
|
|
start = (listOptions.Page - 1) * listOptions.PageSize
|
|
}
|
|
return start, listOptions.PageSize
|
|
}
|
|
return 0, unlimited
|
|
}
|
|
|
|
return paginator.GetSkipTake()
|
|
}
|