Gusted
ebe569a268
Set correct PR status on 3way on conflict checking ( #19457 )
...
* Set correct PR status on 3way on conflict checking
- When 3-way merge is enabled for conflict checking, it has a new
interesting behavior that it doesn't return any error when it found a
conflict, so we change the condition to not check for the error, but
instead check if conflictedfiles is populated, this fixes a issue
whereby PR status wasn't correctly on conflicted PR's.
- Refactor the mergeable property(which was incorrectly set and lead me this
bug) to be more maintainable.
- Add a dedicated test for conflicting checking, so it should prevent
future issues with this.
* Fix linter
2022-04-21 22:55:45 +01:00
..
2022-04-14 21:58:21 +08:00
2021-10-21 17:22:43 +08:00
2022-04-14 21:58:21 +08:00
2022-04-14 21:58:21 +08:00
2022-01-20 18:46:10 +01:00
2022-04-14 21:58:21 +08:00
2022-03-29 14:29:02 +08:00
2022-03-17 18:08:35 +01:00
2022-04-14 21:58:21 +08:00
2022-04-02 00:34:57 +08:00
2022-04-20 18:43:26 +08:00
2022-04-19 12:55:35 -04:00
2022-01-05 11:37:00 +08:00
2022-04-14 21:58:21 +08:00
2022-04-14 21:58:21 +08:00
2022-02-08 21:16:17 +00:00
2022-04-14 21:58:21 +08:00
2022-04-14 21:58:21 +08:00
2022-04-14 21:58:21 +08:00
2022-03-29 14:29:02 +08:00
2022-03-29 14:29:02 +08:00
2022-03-31 17:20:39 +08:00
2022-03-13 17:40:47 +01:00
2022-04-08 17:11:15 +08:00
2021-12-10 09:27:50 +08:00
2022-03-29 14:29:02 +08:00
2021-12-10 09:27:50 +08:00
2021-12-15 13:39:34 +08:00
2022-02-02 11:10:06 +01:00
2022-04-08 17:11:15 +08:00
2022-01-20 18:46:10 +01:00
2021-12-07 13:44:08 +08:00
2022-04-08 17:11:15 +08:00
2021-12-10 09:27:50 +08:00
2021-11-12 22:36:47 +08:00
2021-09-22 13:38:34 +08:00
2022-03-22 17:29:07 +08:00
2022-03-31 17:20:39 +08:00
2022-03-29 16:57:33 +02:00
2022-04-08 17:11:15 +08:00
2022-04-08 17:11:15 +08:00
2022-01-19 23:26:57 +00:00
2022-04-08 17:11:15 +08:00
2022-03-29 16:57:33 +02:00
2021-12-10 09:27:50 +08:00
2022-03-29 15:23:45 +08:00
2022-04-08 17:11:15 +08:00
2021-11-16 16:53:21 +08:00
2022-04-08 17:11:15 +08:00
2022-04-08 17:11:15 +08:00
2022-04-08 17:11:15 +08:00
2021-11-24 17:49:20 +08:00
2022-04-08 17:11:15 +08:00
2022-04-08 17:11:15 +08:00
2022-02-28 23:57:20 +01:00
2022-04-08 17:11:15 +08:00
2021-12-10 09:27:50 +08:00
2021-12-10 09:27:50 +08:00
2021-11-17 20:34:35 +08:00
2021-12-15 13:39:34 +08:00
2022-03-29 16:57:33 +02:00
2022-04-08 17:11:15 +08:00
2022-04-08 17:11:15 +08:00
2021-12-10 09:27:50 +08:00
2022-03-10 10:09:48 +00:00
2022-04-14 21:58:21 +08:00
2022-04-08 17:11:15 +08:00
2022-04-08 17:11:15 +08:00
2021-11-24 17:49:20 +08:00
2022-04-08 17:11:15 +08:00
2022-03-29 14:29:02 +08:00
2022-04-01 09:53:18 +08:00
2022-03-29 14:29:02 +08:00
2022-03-29 14:29:02 +08:00
2021-12-10 09:27:50 +08:00
2022-03-29 14:29:02 +08:00
2022-01-03 20:45:58 +01:00
2022-03-31 16:53:08 +02:00
2022-04-21 22:55:45 +01:00
2022-02-01 13:20:28 -05:00
2022-01-19 23:26:57 +00:00
2021-12-10 09:27:50 +08:00
2022-03-29 14:29:02 +08:00
2021-06-07 07:27:09 +02:00
2022-03-29 15:23:45 +08:00
2021-11-16 16:53:21 +08:00
2022-03-31 17:20:39 +08:00
2022-03-29 14:29:02 +08:00
2022-04-01 14:05:31 +08:00
2022-03-08 22:48:47 +01:00
2021-12-10 09:27:50 +08:00
2022-03-29 14:29:02 +08:00
2022-04-08 17:11:15 +08:00
2022-01-20 18:46:10 +01:00
2022-04-08 17:11:15 +08:00
2022-04-08 17:11:15 +08:00
2022-03-31 10:25:40 +08:00
2021-11-17 20:34:35 +08:00
2022-01-26 12:10:10 +08:00
2021-11-21 23:41:00 +08:00
2022-03-13 17:40:47 +01:00
2022-03-29 14:29:02 +08:00
2022-03-29 14:29:02 +08:00
2022-03-31 17:20:39 +08:00
2022-03-29 14:29:02 +08:00
2022-03-29 14:29:02 +08:00