githaven-fork/routers/repo
Kyle Evans 38cd9ba47b
Allow unauthenticated users to compare (#11240)
* routers: make /compare route available to unauthenticated users

Remove some bits of the compare interface if the user isn't signed in.
Notably, they don't need to see the "New Pull Request" button box nor the
hidden form that would fail to submit due to the POST request continuing to
require proper privileges.

Follow-up commits will improve the UI a bit around this, removing some
"Pull Request" verbiage in favor of "Compare."

* ui: home: show "compare" button for unauthenticated users

This change requires pulling in the BaseRepo unconditionally and
recording if the pull request is in-fact not allowed
(.PullRequestCtx.Allowed). If the user isn't allowed to create a pull
request, either because this isn't a fork or same-fork branch PRs aren't
allowed, then we'll name the button "Compare" instead of "Pull Request."

* ui: branch list: use the new Compare language when available

When viewing the branch listing as an unauthenticated user, you'll get
"Pull Request" buttons. use the new "Compare" verbiage instead, which
matches GitHub behavior when you can't issue a pull request from the
branches.

Co-authored-by: zeripath <art27@cantab.net>
Co-authored-by: guillep2k <18600385+guillep2k@users.noreply.github.com>
2020-05-04 19:44:30 -03:00
..
activity.go Add top author stats to activity page (#9615) 2020-01-20 12:07:30 +02:00
attachment.go Move dropzone.js to npm/webpack (#10645) 2020-03-07 21:06:15 +00:00
blame.go make avatar lookup occur at image request (#10540) 2020-03-27 14:34:39 +02:00
branch.go Allow unauthenticated users to compare (#11240) 2020-05-04 19:44:30 -03:00
commit.go Fix potential bugs (#10513) 2020-02-27 20:10:27 -03:00
compare.go Show pull request selection even when unrelated branches (#11239) 2020-05-02 16:06:01 +08:00
download.go Fix download file wrong content-type (#9825) 2020-01-17 20:16:05 +08:00
editor_test.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
editor.go Handle push rejection in branch and upload (#10854) 2020-03-28 01:13:18 -03:00
http.go Prevent clones and pushes to disabled wiki (#11131) 2020-04-19 15:26:58 +01:00
issue_dependency.go Fix wrong permissions check when issues/prs shared operations (#9885) 2020-01-20 13:00:32 +01:00
issue_label_test.go fix go vet error (#3740) 2018-03-30 07:21:27 +08:00
issue_label.go Add Organization Wide Labels (#10814) 2020-04-01 01:14:46 -03:00
issue_lock.go Implement "conversation lock" for issue comments (#5073) 2019-02-18 22:55:04 +02:00
issue_stopwatch.go Automatically clear stopwatch on merging a PR (#4327) 2019-02-05 13:38:11 +02:00
issue_timetrack.go [API] Extend times API (#9200) 2019-12-27 20:30:58 +00:00
issue_watch.go Fix PR/issue redirects when having external tracker (#9339) 2019-12-14 01:53:32 +01:00
issue.go [API] ListIssues add filter for milestones (#10148) 2020-04-30 01:15:39 -03:00
lfs.go Migrate to go-git/go-git v5.0.0 (#10735) 2020-03-17 12:19:58 -04:00
main_test.go Unit tests for wiki routers (#3022) 2017-11-30 17:52:15 +02:00
middlewares.go Add gitea-vet (#10948) 2020-04-05 07:20:50 +01:00
milestone.go move jquery-datetimepicker to npm/webpack (#10713) 2020-03-17 15:08:15 -04:00
pull_review.go Add a way to mark Conversation (code comment) resolved (#11037) 2020-04-18 10:50:25 -03:00
pull.go Add a way to mark Conversation (code comment) resolved (#11037) 2020-04-18 10:50:25 -03:00
release_test.go Add Close() method to gogitRepository (#8901) 2019-11-13 07:01:19 +00:00
release.go Add single release page and latest redirect (#11102) 2020-04-18 11:47:15 -03:00
repo.go Fix orgs not being displayed on create repo form (#11279) 2020-05-03 18:08:24 -03:00
search.go Add detected file language to code search (#10256) 2020-02-20 16:53:55 -03:00
setting_protected_branch.go Prevent merge of outdated PRs on protected branches (#11012) 2020-04-16 22:00:36 -03:00
setting.go API endpoint for repo transfer (#9947) 2020-01-31 15:49:04 +00:00
settings_test.go Stop various tests from adding to the source tree (#9515) 2019-12-28 10:08:05 +08:00
topic.go Add API endpoint for accessing repo topics (#7963) 2019-09-03 23:46:24 +08:00
view.go Show Signer in commit lists and add basic trust (#10425) 2020-02-27 16:20:55 -03:00
webhook.go Add Matrix webhook (#10831) 2020-03-28 15:09:55 +02:00
wiki_test.go Fix wiki raw view on sub path (#10002) 2020-01-28 09:44:08 +00:00
wiki.go Show Signer in commit lists and add basic trust (#10425) 2020-02-27 16:20:55 -03:00