forked from Shiloh/githaven
c6c829fe3f
Closes #27455 > The mechanism responsible for long-term authentication (the 'remember me' cookie) uses a weak construction technique. It will hash the user's hashed password and the rands value; it will then call the secure cookie code, which will encrypt the user's name with the computed hash. If one were able to dump the database, they could extract those two values to rebuild that cookie and impersonate a user. That vulnerability exists from the date the dump was obtained until a user changed their password. > > To fix this security issue, the cookie could be created and verified using a different technique such as the one explained at https://paragonie.com/blog/2015/04/secure-authentication-php-with-long-term-persistence#secure-remember-me-cookies. The PR removes the now obsolete setting `COOKIE_USERNAME`.
61 lines
1.4 KiB
Go
61 lines
1.4 KiB
Go
// Copyright 2023 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package auth
|
|
|
|
import (
|
|
"context"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/modules/timeutil"
|
|
"code.gitea.io/gitea/modules/util"
|
|
|
|
"xorm.io/builder"
|
|
)
|
|
|
|
var ErrAuthTokenNotExist = util.NewNotExistErrorf("auth token does not exist")
|
|
|
|
type AuthToken struct { //nolint:revive
|
|
ID string `xorm:"pk"`
|
|
TokenHash string
|
|
UserID int64 `xorm:"INDEX"`
|
|
ExpiresUnix timeutil.TimeStamp `xorm:"INDEX"`
|
|
}
|
|
|
|
func init() {
|
|
db.RegisterModel(new(AuthToken))
|
|
}
|
|
|
|
func InsertAuthToken(ctx context.Context, t *AuthToken) error {
|
|
_, err := db.GetEngine(ctx).Insert(t)
|
|
return err
|
|
}
|
|
|
|
func GetAuthTokenByID(ctx context.Context, id string) (*AuthToken, error) {
|
|
at := &AuthToken{}
|
|
|
|
has, err := db.GetEngine(ctx).ID(id).Get(at)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
if !has {
|
|
return nil, ErrAuthTokenNotExist
|
|
}
|
|
return at, nil
|
|
}
|
|
|
|
func UpdateAuthTokenByID(ctx context.Context, t *AuthToken) error {
|
|
_, err := db.GetEngine(ctx).ID(t.ID).Cols("token_hash", "expires_unix").Update(t)
|
|
return err
|
|
}
|
|
|
|
func DeleteAuthTokenByID(ctx context.Context, id string) error {
|
|
_, err := db.GetEngine(ctx).ID(id).Delete(&AuthToken{})
|
|
return err
|
|
}
|
|
|
|
func DeleteExpiredAuthTokens(ctx context.Context) error {
|
|
_, err := db.GetEngine(ctx).Where(builder.Lt{"expires_unix": timeutil.TimeStampNow()}).Delete(&AuthToken{})
|
|
return err
|
|
}
|