githaven-fork/templates/repo/issue/view_content
wxiaoguang d306ab2b8f
Remove Fomantic-UI's .hidden CSS class for menu elements (#22895)
* Like #22851
* All other dropdown menu elements do not have such `hidden` class.
* Actually the dropdown menu elements do not need it in HTML, so this PR
removes it.
* There is already `.ui.dropdown .menu { display: none; }`, so when
loading the page, the menu is correctly hidden initially, no need to add
any more CSS classes.
* The Fomantic UI's `.hidden` class should still exist until there is no
its checkbox/dropdown module anymore. The Fomantic UI JS code still
addes `hidden` for `ui checkbox` and addes `transition hidden` for `ui
menu` at the moment.
* This PR also cleans the legacy inline `style`, which is quite hacky
and no need anymore.

All these dropdown menus work well.

I have tested these 5 places:

* The code search from User Profile
* The issue sidebar to lock issue
* The repo search form
* The repo setting page: branch list
* The repo setting page: merge option list

Screenshot:

![image](https://user-images.githubusercontent.com/2114189/218534515-e7dfe291-6765-4e0b-833c-b74f17e30117.png)
2023-02-14 19:53:54 +08:00
..
add_reaction.tmpl Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
attachments.tmpl Remove fomantic image module (#21145) 2022-09-12 17:08:46 +08:00
comments_delete_time.tmpl Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
comments.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
context_menu.tmpl Use link in UI which returned a relative url but not html_url which contains an absolute url (#21986) 2023-02-06 12:09:18 -06:00
pull_merge_instruction.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
pull.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00
reactions.tmpl Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
reference_issue_dialog.tmpl Make sure fmt catches all templates (#20979) 2022-08-31 23:58:54 +08:00
sidebar.tmpl Remove Fomantic-UI's .hidden CSS class for menu elements (#22895) 2023-02-14 19:53:54 +08:00
update_branch_by_merge.tmpl Move helpers to be prefixed with gt- (#22879) 2023-02-13 17:59:59 +00:00