githaven-fork/modules/indexer/code
qwerty287 9d943bf374
Add missing X-Total-Count and fix some related bugs (#17968)
* Add missing `X-Total-Count` and fix some related bugs

Adds `X-Total-Count` header to APIs that return a list but doesn't have it yet.
Fixed bugs:
* not returned after reporting error (39eb82446c/routers/api/v1/user/star.go (L70))
* crash with index out of bounds, API issue/issueSubscriptions

I also found various endpoints that return lists but do not apply/support pagination yet:
```
/repos/{owner}/{repo}/issues/{index}/labels
/repos/{owner}/{repo}/issues/comments/{id}/reactions
/repos/{owner}/{repo}/branch_protections
/repos/{owner}/{repo}/contents
/repos/{owner}/{repo}/hooks/git
/repos/{owner}/{repo}/issue_templates
/repos/{owner}/{repo}/releases/{id}/assets
/repos/{owner}/{repo}/reviewers
/repos/{owner}/{repo}/teams
/user/emails
/users/{username}/heatmap
```
If this is not expected, an new issue should be opened.

Closes #13043

* fmt

* Update routers/api/v1/repo/issue_subscription.go

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>

* Use FindAndCount

Co-authored-by: KN4CK3R <admin@oldschoolhack.me>
Co-authored-by: 6543 <6543@obermui.de>
2021-12-15 13:39:34 +08:00
..
bleve_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
bleve.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
elastic_search_test.go Decouple unit test code from business code (#17623) 2021-11-12 22:36:47 +08:00
elastic_search.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
git.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
indexer_test.go Add missing X-Total-Count and fix some related bugs (#17968) 2021-12-15 13:39:34 +08:00
indexer.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00
search.go Add .gitattribute assisted language detection to blame, diff and render (#17590) 2021-11-17 20:37:00 +00:00
wrapped.go Move repository model into models/repo (#17933) 2021-12-10 09:27:50 +08:00