forked from Shiloh/githaven
74874d065f
When deleting a closed issue, we should update both `NumIssues`and `NumClosedIssues`, or `NumOpenIssues`(`= NumIssues -NumClosedIssues`) will be wrong. It's the same for pull requests. Releated to #21557. Alse fixed two harmless problems: - The SQL to check issue/PR total numbers is wrong, that means it will update the numbers even if they are correct. - Replace legacy `num_issues = num_issues + 1` operations with `UpdateRepoIssueNumbers`.
293 lines
8.5 KiB
Go
293 lines
8.5 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// SPDX-License-Identifier: MIT
|
|
|
|
package issue
|
|
|
|
import (
|
|
"fmt"
|
|
|
|
activities_model "code.gitea.io/gitea/models/activities"
|
|
"code.gitea.io/gitea/models/db"
|
|
issues_model "code.gitea.io/gitea/models/issues"
|
|
access_model "code.gitea.io/gitea/models/perm/access"
|
|
project_model "code.gitea.io/gitea/models/project"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
system_model "code.gitea.io/gitea/models/system"
|
|
user_model "code.gitea.io/gitea/models/user"
|
|
"code.gitea.io/gitea/modules/git"
|
|
"code.gitea.io/gitea/modules/notification"
|
|
"code.gitea.io/gitea/modules/storage"
|
|
)
|
|
|
|
// NewIssue creates new issue with labels for repository.
|
|
func NewIssue(repo *repo_model.Repository, issue *issues_model.Issue, labelIDs []int64, uuids []string, assigneeIDs []int64) error {
|
|
if err := issues_model.NewIssue(repo, issue, labelIDs, uuids); err != nil {
|
|
return err
|
|
}
|
|
|
|
for _, assigneeID := range assigneeIDs {
|
|
if err := AddAssigneeIfNotAssigned(issue, issue.Poster, assigneeID); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
mentions, err := issues_model.FindAndUpdateIssueMentions(db.DefaultContext, issue, issue.Poster, issue.Content)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
notification.NotifyNewIssue(db.DefaultContext, issue, mentions)
|
|
if len(issue.Labels) > 0 {
|
|
notification.NotifyIssueChangeLabels(db.DefaultContext, issue.Poster, issue, issue.Labels, nil)
|
|
}
|
|
if issue.Milestone != nil {
|
|
notification.NotifyIssueChangeMilestone(db.DefaultContext, issue.Poster, issue, 0)
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// ChangeTitle changes the title of this issue, as the given user.
|
|
func ChangeTitle(issue *issues_model.Issue, doer *user_model.User, title string) (err error) {
|
|
oldTitle := issue.Title
|
|
issue.Title = title
|
|
|
|
if err = issues_model.ChangeIssueTitle(issue, doer, oldTitle); err != nil {
|
|
return
|
|
}
|
|
|
|
notification.NotifyIssueChangeTitle(db.DefaultContext, doer, issue, oldTitle)
|
|
|
|
return nil
|
|
}
|
|
|
|
// ChangeIssueRef changes the branch of this issue, as the given user.
|
|
func ChangeIssueRef(issue *issues_model.Issue, doer *user_model.User, ref string) error {
|
|
oldRef := issue.Ref
|
|
issue.Ref = ref
|
|
|
|
if err := issues_model.ChangeIssueRef(issue, doer, oldRef); err != nil {
|
|
return err
|
|
}
|
|
|
|
notification.NotifyIssueChangeRef(db.DefaultContext, doer, issue, oldRef)
|
|
|
|
return nil
|
|
}
|
|
|
|
// UpdateAssignees is a helper function to add or delete one or multiple issue assignee(s)
|
|
// Deleting is done the GitHub way (quote from their api documentation):
|
|
// https://developer.github.com/v3/issues/#edit-an-issue
|
|
// "assignees" (array): Logins for Users to assign to this issue.
|
|
// Pass one or more user logins to replace the set of assignees on this Issue.
|
|
// Send an empty array ([]) to clear all assignees from the Issue.
|
|
func UpdateAssignees(issue *issues_model.Issue, oneAssignee string, multipleAssignees []string, doer *user_model.User) (err error) {
|
|
var allNewAssignees []*user_model.User
|
|
|
|
// Keep the old assignee thingy for compatibility reasons
|
|
if oneAssignee != "" {
|
|
// Prevent double adding assignees
|
|
var isDouble bool
|
|
for _, assignee := range multipleAssignees {
|
|
if assignee == oneAssignee {
|
|
isDouble = true
|
|
break
|
|
}
|
|
}
|
|
|
|
if !isDouble {
|
|
multipleAssignees = append(multipleAssignees, oneAssignee)
|
|
}
|
|
}
|
|
|
|
// Loop through all assignees to add them
|
|
for _, assigneeName := range multipleAssignees {
|
|
assignee, err := user_model.GetUserByName(db.DefaultContext, assigneeName)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
allNewAssignees = append(allNewAssignees, assignee)
|
|
}
|
|
|
|
// Delete all old assignees not passed
|
|
if err = DeleteNotPassedAssignee(issue, doer, allNewAssignees); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Add all new assignees
|
|
// Update the assignee. The function will check if the user exists, is already
|
|
// assigned (which he shouldn't as we deleted all assignees before) and
|
|
// has access to the repo.
|
|
for _, assignee := range allNewAssignees {
|
|
// Extra method to prevent double adding (which would result in removing)
|
|
err = AddAssigneeIfNotAssigned(issue, doer, assignee.ID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
return err
|
|
}
|
|
|
|
// DeleteIssue deletes an issue
|
|
func DeleteIssue(doer *user_model.User, gitRepo *git.Repository, issue *issues_model.Issue) error {
|
|
// load issue before deleting it
|
|
if err := issue.LoadAttributes(gitRepo.Ctx); err != nil {
|
|
return err
|
|
}
|
|
if err := issue.LoadPullRequest(gitRepo.Ctx); err != nil {
|
|
return err
|
|
}
|
|
|
|
// delete entries in database
|
|
if err := deleteIssue(issue); err != nil {
|
|
return err
|
|
}
|
|
|
|
// delete pull request related git data
|
|
if issue.IsPull {
|
|
if err := gitRepo.RemoveReference(fmt.Sprintf("%s%d/head", git.PullPrefix, issue.PullRequest.Index)); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
notification.NotifyDeleteIssue(gitRepo.Ctx, doer, issue)
|
|
|
|
return nil
|
|
}
|
|
|
|
// AddAssigneeIfNotAssigned adds an assignee only if he isn't already assigned to the issue.
|
|
// Also checks for access of assigned user
|
|
func AddAssigneeIfNotAssigned(issue *issues_model.Issue, doer *user_model.User, assigneeID int64) (err error) {
|
|
assignee, err := user_model.GetUserByID(db.DefaultContext, assigneeID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
// Check if the user is already assigned
|
|
isAssigned, err := issues_model.IsUserAssignedToIssue(db.DefaultContext, issue, assignee)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if isAssigned {
|
|
// nothing to to
|
|
return nil
|
|
}
|
|
|
|
valid, err := access_model.CanBeAssigned(db.DefaultContext, assignee, issue.Repo, issue.IsPull)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
if !valid {
|
|
return repo_model.ErrUserDoesNotHaveAccessToRepo{UserID: assigneeID, RepoName: issue.Repo.Name}
|
|
}
|
|
|
|
_, _, err = ToggleAssignee(issue, doer, assigneeID)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
|
|
return nil
|
|
}
|
|
|
|
// GetRefEndNamesAndURLs retrieves the ref end names (e.g. refs/heads/branch-name -> branch-name)
|
|
// and their respective URLs.
|
|
func GetRefEndNamesAndURLs(issues []*issues_model.Issue, repoLink string) (map[int64]string, map[int64]string) {
|
|
issueRefEndNames := make(map[int64]string, len(issues))
|
|
issueRefURLs := make(map[int64]string, len(issues))
|
|
for _, issue := range issues {
|
|
if issue.Ref != "" {
|
|
issueRefEndNames[issue.ID] = git.RefEndName(issue.Ref)
|
|
issueRefURLs[issue.ID] = git.RefURL(repoLink, issue.Ref)
|
|
}
|
|
}
|
|
return issueRefEndNames, issueRefURLs
|
|
}
|
|
|
|
// deleteIssue deletes the issue
|
|
func deleteIssue(issue *issues_model.Issue) error {
|
|
ctx, committer, err := db.TxContext(db.DefaultContext)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
defer committer.Close()
|
|
|
|
e := db.GetEngine(ctx)
|
|
if _, err := e.ID(issue.ID).NoAutoCondition().Delete(issue); err != nil {
|
|
return err
|
|
}
|
|
|
|
// update the total issue numbers
|
|
if err := repo_model.UpdateRepoIssueNumbers(ctx, issue.RepoID, issue.IsPull, false); err != nil {
|
|
return err
|
|
}
|
|
// if the issue is closed, update the closed issue numbers
|
|
if issue.IsClosed {
|
|
if err := repo_model.UpdateRepoIssueNumbers(ctx, issue.RepoID, issue.IsPull, true); err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
if err := issues_model.UpdateMilestoneCounters(ctx, issue.MilestoneID); err != nil {
|
|
return fmt.Errorf("error updating counters for milestone id %d: %w",
|
|
issue.MilestoneID, err)
|
|
}
|
|
|
|
if err := activities_model.DeleteIssueActions(ctx, issue.RepoID, issue.ID); err != nil {
|
|
return err
|
|
}
|
|
|
|
// find attachments related to this issue and remove them
|
|
if err := issue.LoadAttributes(ctx); err != nil {
|
|
return err
|
|
}
|
|
|
|
for i := range issue.Attachments {
|
|
system_model.RemoveStorageWithNotice(ctx, storage.Attachments, "Delete issue attachment", issue.Attachments[i].RelativePath())
|
|
}
|
|
|
|
// delete all database data still assigned to this issue
|
|
if err := issues_model.DeleteInIssue(ctx, issue.ID,
|
|
&issues_model.ContentHistory{},
|
|
&issues_model.Comment{},
|
|
&issues_model.IssueLabel{},
|
|
&issues_model.IssueDependency{},
|
|
&issues_model.IssueAssignees{},
|
|
&issues_model.IssueUser{},
|
|
&activities_model.Notification{},
|
|
&issues_model.Reaction{},
|
|
&issues_model.IssueWatch{},
|
|
&issues_model.Stopwatch{},
|
|
&issues_model.TrackedTime{},
|
|
&project_model.ProjectIssue{},
|
|
&repo_model.Attachment{},
|
|
&issues_model.PullRequest{},
|
|
); err != nil {
|
|
return err
|
|
}
|
|
|
|
// References to this issue in other issues
|
|
if _, err := db.DeleteByBean(ctx, &issues_model.Comment{
|
|
RefIssueID: issue.ID,
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
|
|
// Delete dependencies for issues in other repositories
|
|
if _, err := db.DeleteByBean(ctx, &issues_model.IssueDependency{
|
|
DependencyID: issue.ID,
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
|
|
// delete from dependent issues
|
|
if _, err := db.DeleteByBean(ctx, &issues_model.Comment{
|
|
DependentIssueID: issue.ID,
|
|
}); err != nil {
|
|
return err
|
|
}
|
|
|
|
return committer.Commit()
|
|
}
|