forked from Shiloh/githaven
1887c95254
At the moment a repository reference is needed for webhooks. With the upcoming package PR we need to send webhooks without a repository reference. For example a package is uploaded to an organization. In theory this enables the usage of webhooks for future user actions. This PR removes the repository id from `HookTask` and changes how the hooks are processed (see `services/webhook/deliver.go`). In a follow up PR I want to remove the usage of the `UniqueQueue´ and replace it with a normal queue because there is no reason to be unique. Co-authored-by: 6543 <6543@obermui.de>
84 lines
2.7 KiB
Go
84 lines
2.7 KiB
Go
// Copyright 2019 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package webhook
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
repo_model "code.gitea.io/gitea/models/repo"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
webhook_model "code.gitea.io/gitea/models/webhook"
|
|
api "code.gitea.io/gitea/modules/structs"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
func TestWebhook_GetSlackHook(t *testing.T) {
|
|
w := &webhook_model.Webhook{
|
|
Meta: `{"channel": "foo", "username": "username", "color": "blue"}`,
|
|
}
|
|
slackHook := GetSlackHook(w)
|
|
assert.Equal(t, *slackHook, SlackMeta{
|
|
Channel: "foo",
|
|
Username: "username",
|
|
Color: "blue",
|
|
})
|
|
}
|
|
|
|
func TestPrepareWebhooks(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 1})
|
|
hookTasks := []*webhook_model.HookTask{
|
|
{HookID: 1, EventType: webhook_model.HookEventPush},
|
|
}
|
|
for _, hookTask := range hookTasks {
|
|
unittest.AssertNotExistsBean(t, hookTask)
|
|
}
|
|
assert.NoError(t, PrepareWebhooks(db.DefaultContext, EventSource{Repository: repo}, webhook_model.HookEventPush, &api.PushPayload{Commits: []*api.PayloadCommit{{}}}))
|
|
for _, hookTask := range hookTasks {
|
|
unittest.AssertExistsAndLoadBean(t, hookTask)
|
|
}
|
|
}
|
|
|
|
func TestPrepareWebhooksBranchFilterMatch(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
|
|
hookTasks := []*webhook_model.HookTask{
|
|
{HookID: 4, EventType: webhook_model.HookEventPush},
|
|
}
|
|
for _, hookTask := range hookTasks {
|
|
unittest.AssertNotExistsBean(t, hookTask)
|
|
}
|
|
// this test also ensures that * doesn't handle / in any special way (like shell would)
|
|
assert.NoError(t, PrepareWebhooks(db.DefaultContext, EventSource{Repository: repo}, webhook_model.HookEventPush, &api.PushPayload{Ref: "refs/heads/feature/7791", Commits: []*api.PayloadCommit{{}}}))
|
|
for _, hookTask := range hookTasks {
|
|
unittest.AssertExistsAndLoadBean(t, hookTask)
|
|
}
|
|
}
|
|
|
|
func TestPrepareWebhooksBranchFilterNoMatch(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
|
|
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: 2})
|
|
hookTasks := []*webhook_model.HookTask{
|
|
{HookID: 4, EventType: webhook_model.HookEventPush},
|
|
}
|
|
for _, hookTask := range hookTasks {
|
|
unittest.AssertNotExistsBean(t, hookTask)
|
|
}
|
|
assert.NoError(t, PrepareWebhooks(db.DefaultContext, EventSource{Repository: repo}, webhook_model.HookEventPush, &api.PushPayload{Ref: "refs/heads/fix_weird_bug"}))
|
|
|
|
for _, hookTask := range hookTasks {
|
|
unittest.AssertNotExistsBean(t, hookTask)
|
|
}
|
|
}
|
|
|
|
// TODO TestHookTask_deliver
|
|
|
|
// TODO TestDeliverHooks
|