linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity
50166d1f7c
githaven-fork/routers/web/repo
History
Eng Zer Jun 13d5d2e711
Remove redundant len check around loop (#27464) 
This pull request is a minor code cleanup.

From the Go specification (https://go.dev/ref/spec#For_range):

> "1. For a nil slice, the number of iterations is 0."
> "3. If the map is nil, the number of iterations is 0."

`len` returns 0 if the slice or map is nil
(https://pkg.go.dev/builtin#len). Therefore, checking `len(v) > 0`
before a loop is unnecessary.

---

At the time of writing this pull request, there wasn't a lint rule that
catches these issues. The closest I could find is
https://staticcheck.dev/docs/checks/#S103

Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
2023-10-06 14:49:37 +08:00
..
actions Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
setting Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
activity.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
attachment.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
blame.go Improve tree not found page (#26570) 2023-09-29 07:42:39 +00:00
branch.go Search branches (#27055) 2023-09-17 08:24:40 +00:00
cherry_pick.go Sync branches into databases (#22743) 2023-06-29 10:03:20 +00:00
commit.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
compare.go When comparing with an non-exist repository, return 404 but 500 (#27437) 2023-10-04 13:59:03 +00:00
download.go Less naked returns (#25713) 2023-07-07 05:31:56 +00:00
editor_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
editor.go Improve tree not found page (#26570) 2023-09-29 07:42:39 +00:00
find.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
helper_test.go Make web context initialize correctly for different cases (#26726) 2023-08-25 19:07:42 +08:00
helper.go Improve tree not found page (#26570) 2023-09-29 07:42:39 +00:00
http_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
http.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
issue_content_history.go Improve issue history dialog and make poster can delete their own history (#27323) 2023-09-28 08:43:20 +00:00
issue_dependency.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_label_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
issue_label.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_lock.go Use fetch form action for lock/unlock/pin/unpin on sidebar (#25380) 2023-06-29 04:16:04 +00:00
issue_pin.go Add context parameter to some database functions (#26055) 2023-07-22 22:14:27 +08:00
issue_stopwatch.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
issue_timetrack.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
issue_watch.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
issue.go Remove redundant len check around loop (#27464) 2023-10-06 14:49:37 +08:00
main_test.go make writing main test easier (#27270) 2023-09-28 01:38:53 +00:00
middlewares.go More refactoring of db.DefaultContext (#27083) 2023-09-15 06:13:19 +00:00
migrate.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
milestone.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
packages.go Fix the display of org level badges (#26504) 2023-09-06 14:38:14 +08:00
patch.go Sync branches into databases (#22743) 2023-06-29 10:03:20 +00:00
projects_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
projects.go More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
pull_review.go More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
pull.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
release_test.go Improvements of releases list and tags list (#25859) 2023-09-28 13:21:47 +00:00
release.go Improvements of releases list and tags list (#25859) 2023-09-28 13:21:47 +00:00
render.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
repo.go Even more db.DefaultContext refactor (#27352) 2023-10-03 10:30:41 +00:00
search.go Refactor indexer (#25174) 2023-06-23 12:37:56 +00:00
topic.go Next round of db.DefaultContext refactor (#27089) 2023-09-16 14:39:12 +00:00
treelist.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
view_test.go Implement FSFE REUSE for golang files (#21840) 2022-11-27 18:20:29 +00:00
view.go Document the line-number counting behavior (#27386) 2023-10-02 07:23:18 +00:00
wiki_test.go Move web/api context related testing function into a separate package (#26859) 2023-09-01 11:26:07 +00:00
wiki.go Move notification interface to services layer (#26915) 2023-09-05 18:37:47 +00:00