githaven-fork/services
Rowan Bohde 416c36f303
allow synchronizing user status from OAuth2 login providers (#31572)
This leverages the existing `sync_external_users` cron job to
synchronize the `IsActive` flag on users who use an OAuth2 provider set
to synchronize. This synchronization is done by checking for expired
access tokens, and using the stored refresh token to request a new
access token. If the response back from the OAuth2 provider is the
`invalid_grant` error code, the user is marked as inactive. However, the
user is able to reactivate their account by logging in the web browser
through their OAuth2 flow.

Also changed to support this is that a linked `ExternalLoginUser` is
always created upon a login or signup via OAuth2.

### Notes on updating permissions
Ideally, we would also refresh permissions from the configured OAuth
provider (e.g., admin, restricted and group mappings) to match the
implementation of LDAP. However, the OAuth library used for this `goth`,
doesn't seem to support issuing a session via refresh tokens. The
interface provides a [`RefreshToken`
method](https://github.com/markbates/goth/blob/master/provider.go#L20),
but the returned `oauth.Token` doesn't implement the `goth.Session` we
would need to call `FetchUser`. Due to specific implementations, we
would need to build a compatibility function for every provider, since
they cast to concrete types (e.g.
[Azure](https://github.com/markbates/goth/blob/master/providers/azureadv2/azureadv2.go#L132))

---------

Co-authored-by: Kyle D <kdumontnu@gmail.com>
2024-07-16 20:33:16 +02:00
..
actions Improve the handling of jobs.<job_id>.if (#31070) 2024-05-27 14:15:34 +08:00
agit Performance optimization for git push (#30104) 2024-04-09 03:43:17 +00:00
asymkey Fix some pending problems (#29985) 2024-03-22 19:17:30 +08:00
attachment Add support for API blob upload of release attachments (#29507) 2024-03-02 17:02:01 +00:00
auth allow synchronizing user status from OAuth2 login providers (#31572) 2024-07-16 20:33:16 +02:00
automerge Fix automerge will not work because of some events haven't been triggered (#30780) 2024-05-21 23:23:22 +08:00
context Refactor names (#31405) 2024-06-19 06:32:45 +08:00
contexttest Check if reverse proxy is correctly configured (#30890) 2024-05-10 20:07:01 +08:00
convert Refactor webhook (#31587) 2024-07-10 11:37:16 +00:00
cron Move some asymkey functions to service layer (#28894) 2024-03-04 08:57:39 +00:00
doctor Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-04-29 08:47:56 +00:00
externalaccount allow synchronizing user status from OAuth2 login providers (#31572) 2024-07-16 20:33:16 +02:00
feed More db.DefaultContext refactor (#27265) 2023-09-29 12:12:54 +00:00
forms Fix: Allow org team names of length 255 in create team form (#31564) 2024-07-10 02:15:17 +00:00
gitdiff Update golangci-lint to v1.59.0 (#31221) 2024-06-03 07:04:35 +00:00
indexer Update issue indexer after merging a PR (#30715) 2024-05-08 14:45:15 +00:00
issue Performance improvements for pull request list API (#30490) 2024-05-31 12:10:11 +00:00
lfs Refactor names (#31405) 2024-06-19 06:32:45 +08:00
mailer Add option to change mail from user display name (#31528) 2024-07-14 23:27:00 +02:00
markup Enable more revive linter rules (#30608) 2024-04-22 11:48:42 +00:00
migrations Add lint-go-gopls (#30729) 2024-06-05 09:22:38 +08:00
mirror Resolve lint for unused parameter and unnecessary type arguments (#30750) 2024-04-29 08:47:56 +00:00
notify Clean up log messages (#30313) 2024-04-07 19:17:06 +08:00
org Update misspell to 0.5.1 and add misspellings.csv (#30573) 2024-04-27 08:03:49 +00:00
packages remove util.OptionalBool and related functions (#29513) 2024-03-02 16:42:31 +01:00
pull Allow force push to protected branches (#28086) 2024-07-05 18:21:56 +00:00
release Check if the release is converted from the tag when updating the release (#30984) 2024-05-15 14:25:47 +00:00
repository Add YEAR, MONTH, MONTH_ENGLISH, DAY variables for template repos (#31584) 2024-07-09 18:05:12 +00:00
secrets Refactor deletion (#28610) 2023-12-25 21:25:29 +01:00
task Fix "force private" logic (#31012) 2024-05-20 00:56:45 +00:00
uinotification Penultimate round of db.DefaultContext refactor (#27414) 2023-10-11 04:24:07 +00:00
user Fix bug on avatar (#31008) 2024-05-19 12:58:39 +08:00
webhook Refactor webhook (#31587) 2024-07-10 11:37:16 +00:00
webtheme Initial support for colorblindness-friendly themes (#30625) 2024-04-24 00:18:41 +08:00
wiki Refactor names (#31405) 2024-06-19 06:32:45 +08:00