forked from Shiloh/githaven
34283a74e8
Fix #19513 This PR introduce a new db method `InTransaction(context.Context)`, and also builtin check on `db.TxContext` and `db.WithTx`. There is also a new method `db.AutoTx` has been introduced but could be used by other PRs. `WithTx` will always open a new transaction, if a transaction exist in context, return an error. `AutoTx` will try to open a new transaction if no transaction exist in context. That means it will always enter a transaction if there is no error. Co-authored-by: delvh <dev.lh@web.de> Co-authored-by: 6543 <6543@obermui.de>
128 lines
4.0 KiB
Go
128 lines
4.0 KiB
Go
// Copyright 2022 The Gitea Authors. All rights reserved.
|
|
// Use of this source code is governed by a MIT-style
|
|
// license that can be found in the LICENSE file.
|
|
|
|
package db_test
|
|
|
|
import (
|
|
"context"
|
|
"errors"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"code.gitea.io/gitea/models/db"
|
|
"code.gitea.io/gitea/models/unittest"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
)
|
|
|
|
type TestIndex db.ResourceIndex
|
|
|
|
func getCurrentResourceIndex(ctx context.Context, tableName string, groupID int64) (int64, error) {
|
|
e := db.GetEngine(ctx)
|
|
var idx int64
|
|
has, err := e.SQL(fmt.Sprintf("SELECT max_index FROM %s WHERE group_id=?", tableName), groupID).Get(&idx)
|
|
if err != nil {
|
|
return 0, err
|
|
}
|
|
if !has {
|
|
return 0, errors.New("no record")
|
|
}
|
|
return idx, nil
|
|
}
|
|
|
|
func TestSyncMaxResourceIndex(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
xe := unittest.GetXORMEngine()
|
|
assert.NoError(t, xe.Sync(&TestIndex{}))
|
|
|
|
err := db.SyncMaxResourceIndex(db.DefaultContext, "test_index", 10, 51)
|
|
assert.NoError(t, err)
|
|
|
|
// sync new max index
|
|
maxIndex, err := getCurrentResourceIndex(db.DefaultContext, "test_index", 10)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 51, maxIndex)
|
|
|
|
// smaller index doesn't change
|
|
err = db.SyncMaxResourceIndex(db.DefaultContext, "test_index", 10, 30)
|
|
assert.NoError(t, err)
|
|
maxIndex, err = getCurrentResourceIndex(db.DefaultContext, "test_index", 10)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 51, maxIndex)
|
|
|
|
// larger index changes
|
|
err = db.SyncMaxResourceIndex(db.DefaultContext, "test_index", 10, 62)
|
|
assert.NoError(t, err)
|
|
maxIndex, err = getCurrentResourceIndex(db.DefaultContext, "test_index", 10)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 62, maxIndex)
|
|
|
|
// commit transaction
|
|
err = db.WithTx(db.DefaultContext, func(ctx context.Context) error {
|
|
err = db.SyncMaxResourceIndex(ctx, "test_index", 10, 73)
|
|
assert.NoError(t, err)
|
|
maxIndex, err = getCurrentResourceIndex(ctx, "test_index", 10)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 73, maxIndex)
|
|
return nil
|
|
})
|
|
assert.NoError(t, err)
|
|
maxIndex, err = getCurrentResourceIndex(db.DefaultContext, "test_index", 10)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 73, maxIndex)
|
|
|
|
// rollback transaction
|
|
err = db.WithTx(db.DefaultContext, func(ctx context.Context) error {
|
|
err = db.SyncMaxResourceIndex(ctx, "test_index", 10, 84)
|
|
maxIndex, err = getCurrentResourceIndex(ctx, "test_index", 10)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 84, maxIndex)
|
|
return errors.New("test rollback")
|
|
})
|
|
assert.Error(t, err)
|
|
maxIndex, err = getCurrentResourceIndex(db.DefaultContext, "test_index", 10)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 73, maxIndex) // the max index doesn't change because the transaction was rolled back
|
|
}
|
|
|
|
func TestGetNextResourceIndex(t *testing.T) {
|
|
assert.NoError(t, unittest.PrepareTestDatabase())
|
|
xe := unittest.GetXORMEngine()
|
|
assert.NoError(t, xe.Sync(&TestIndex{}))
|
|
|
|
// create a new record
|
|
maxIndex, err := db.GetNextResourceIndex(db.DefaultContext, "test_index", 20)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 1, maxIndex)
|
|
|
|
// increase the existing record
|
|
maxIndex, err = db.GetNextResourceIndex(db.DefaultContext, "test_index", 20)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 2, maxIndex)
|
|
|
|
// commit transaction
|
|
err = db.WithTx(db.DefaultContext, func(ctx context.Context) error {
|
|
maxIndex, err = db.GetNextResourceIndex(ctx, "test_index", 20)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 3, maxIndex)
|
|
return nil
|
|
})
|
|
assert.NoError(t, err)
|
|
maxIndex, err = getCurrentResourceIndex(db.DefaultContext, "test_index", 20)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 3, maxIndex)
|
|
|
|
// rollback transaction
|
|
err = db.WithTx(db.DefaultContext, func(ctx context.Context) error {
|
|
maxIndex, err = db.GetNextResourceIndex(ctx, "test_index", 20)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 4, maxIndex)
|
|
return errors.New("test rollback")
|
|
})
|
|
assert.Error(t, err)
|
|
maxIndex, err = getCurrentResourceIndex(db.DefaultContext, "test_index", 20)
|
|
assert.NoError(t, err)
|
|
assert.EqualValues(t, 3, maxIndex) // the max index doesn't change because the transaction was rolled back
|
|
}
|