linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity
18,226 Commits 1 Branch 0 Tags 272 MiB
9bc5552c11
Commit Graph

1842 Commits

Author SHA1 Message Date
Tyrone Yeh
9bc5552c11
Improve attachment upload methods (#30513) 
* Use dropzone to handle file uploading for all cases, including pasting
and dragging
* Merge duplicate code, use consistent behavior for link generating

Close #20130

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2024-06-27 09:31:49 +00:00
wxiaoguang
a88f718c10
Refactor dropzone (#31482) 
Refactor the legacy code and remove some jQuery calls.
 2024-06-27 01:01:20 +08:00
Brecht Van Lommel
4af97cf383
Fix overflow menu flickering on mobile (#31484) 
The overflow menu button was incorrectly included in the measurement of
the width of the items. As a result, it could get stuck in a loop
alternating between different measurements as the button appears and
disappears.
 2024-06-25 10:24:15 -04:00
Brecht Van Lommel
053e5829a3
Fix poor table column width due to breaking words (#31473) 
Caused by #31091

---------

Co-authored-by: silverwind <me@silverwind.io>
 2024-06-24 17:48:43 +00:00
Kemal Zebari
0c4ff01109
Disable issue/PR comment button given empty input (#31463) 
Given an empty issue/PR comment, the comment history would not be
updated if the user were to submit it. Therefore, it would make since to
just disable the comment button when the text editor is empty.

This is inline with what GitHub does when given empty text editor input.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2024-06-23 18:41:01 +00:00
wxiaoguang
f4921b9daa
Simplify 404/500 page (#31409) 2024-06-23 17:45:21 +00:00
wxiaoguang
bda875b6e6
Switch to "Write" tab when edit comment again (#31445) 
Fix #19031
 2024-06-22 09:25:04 +00:00
wxiaoguang
1d76e9aabf
Add simple JS init performance trace (#31459) 
Related to #23461, and help some cases like #31412

For developers, they could use browser's Performance tool to collect
performance data, while this PR is also quite handy to optimize the
`index.js`.

For end users, this PR is simple enough and could figure out the slow
function quickly.


![image](https://github.com/go-gitea/gitea/assets/2114189/a557b08e-6594-474b-81a3-03d5ac2bd68e)
 2024-06-22 17:20:20 +08:00
wxiaoguang
1a811c0bd1
Refactor image diff (#31444) 
And remove some jQuery functions
 2024-06-22 04:52:09 +00:00
wxiaoguang
621e1ff9c9
Improve markdown textarea for indentation and lists (#31406) 
Almost works like GitHub

* use Tab/Shift-Tab to indent/unindent the selected lines
* use Enter to insert a new line with the same indentation and prefix
 2024-06-21 08:14:40 +00:00
wxiaoguang
06782872c4
Split common-global.js into separate files (#31438) 
To improve maintainability
 2024-06-21 15:40:33 +08:00
Yarden Shoham
a5a9885f72
Bump htmx to 2.0.0 (#31413) 
Tested Subscribe, Follow, Star, Watch, and System Status.

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: silverwind <me@silverwind.io>
 2024-06-20 20:04:09 +00:00
Brecht Van Lommel
5afafe22a3
Fix labels and projects menu overflow on issue page (#31435) 
It was correct only on the new issue page.

Resolves #31415
 2024-06-20 16:54:19 +00:00
silverwind
566d87bb8e
Fix new issue/pr avatar (#31419) 
The avatar on "New Issue" and "New Pull Request" pages was inconsistent.
Removed the extra margin and the new CSS rules now use common parent
`<form id="#new-issue">` because `.repository.new.issue` is not present
on pull request page.
 2024-06-19 16:19:59 +00:00
silverwind
17baf1af10
Update JS dependencies, remove eslint-plugin-jquery (#31402) 
- Result of `make update-js`
- Added 1 new eslint rule
- Autofixed 1 new eslint issue
- Remove `eslint-plugin-jquery` as `eslint-plugin-no-jquery` does all it
does and is actually the maintained fork of it.
- Tested all affected `dependencies`

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2024-06-18 08:10:30 +00:00
wxiaoguang
f446e3b4ab
Fix JS error when creating new issue (#31383) 
Fix #31336
 2024-06-16 02:07:21 +00:00
wxiaoguang
47ca61d8ba
Improve detecting empty files (#31332) 
Co-authored-by: silverwind <me@silverwind.io>
 2024-06-13 01:06:46 +00:00
silverwind
90bcdf9829
Fix line number widths (#31341) 
Fixes regression
https://github.com/go-gitea/gitea/pull/31307#issuecomment-2162554913

Table CSS is weird. A `auto` value does not work and causes the
regression while any pixel value causes another regression in diff where
the code lines do not stretch. Partially revert that PR and clean up
some related too-deep CSS selectors.

<img width="109" alt="Screenshot 2024-06-12 at 15 07 22"
src="https://github.com/go-gitea/gitea/assets/115237/756c5dea-44b8-49f9-8a08-acef68075f62">
<img width="119" alt="Screenshot 2024-06-12 at 15 07 43"
src="https://github.com/go-gitea/gitea/assets/115237/28ae1adc-118e-4016-8d09-033b9f1c9a6f">
<img width="151" alt="Screenshot 2024-06-12 at 15 07 07"
src="https://github.com/go-gitea/gitea/assets/115237/08db7ed9-de4e-405e-874d-c7ebe3082557">
<img width="141" alt="Screenshot 2024-06-12 at 15 07 14"
src="https://github.com/go-gitea/gitea/assets/115237/c4a5492b-1bf1-4773-bc8d-64eb36d823f9">
 2024-06-12 15:23:42 +00:00
silverwind
21ba5ca03b
Fix navbar + menu flashing on page load (#31281) 
Fixes
https://github.com/go-gitea/gitea/pull/31273#issuecomment-2153771331.
Same method as used in https://github.com/go-gitea/gitea/pull/30215. All
left-opening dropdowns need to use it method.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
 2024-06-12 14:58:03 +00:00
silverwind
397930d8c1
Fix line number width in code preview (#31307) 
Line numbers were using some hacky CSS `width: 1%` that did nothing to
the code rendering as far as I can tell but broken the inline preview in
markup when line numbers are greater than 2 digits. Also I removed one
duplicate `font-family` rule (it is set below in the `.lines-num,
.lines-code` selector.
 2024-06-11 04:54:39 +00:00
silverwind
507fbf4c3c
Use querySelector over alternative DOM methods (#31280) 
As per
https://github.com/go-gitea/gitea/pull/30115#discussion_r1626060164,
prefer `querySelector` by enabling
[`unicorn/prefer-query-selector`](https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-query-selector.md)
and autofixing all except 10 issues.

According to
[this](https://old.reddit.com/r/learnjavascript/comments/i0f5o8/performance_of_getelementbyid_vs_queryselector/),
querySelector may be faster as well, so it's a win-win.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
 2024-06-10 22:49:33 +02:00
silverwind
a2304cb163
Remove jQuery .text() (#30506) 
Remove and forbid [.text()](https://api.jquery.com/text/). Tested some,
but not all functionality, but I think these are pretty safe
replacements.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
 2024-06-10 18:12:31 +08:00
silverwind
291a00dc57
Fix and clean up ConfirmModal (#31283) 
Bug: orange button color was removed in
https://github.com/go-gitea/gitea/pull/30475, replaced with red
Bug: translation text was not html-escaped
Refactor: Replaced as much jQuery as possible, added useful
`createElementFromHTML`
Refactor: Remove colors checks that don't exist on `.link-action`

<img width="381" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/5900bf6a-8a86-4a86-b368-0559cbfea66e">

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: delvh <dev.lh@web.de>
 2024-06-07 13:42:31 +00:00
Kerwin Bryant
8e33746746
Optimize repo-list layout to enhance visual experience (#31272) 
before: 

![1717655078227](https://github.com/go-gitea/gitea/assets/3371163/4d564f96-c2f8-46b1-996f-6cc7abb940ef)
***The problem was that the icon and text were not on a horizontal line,
and the horizontal was not centered;***

after: 

![1717655094071](https://github.com/go-gitea/gitea/assets/3371163/b11797f6-05f8-486c-b5fd-df89d0cbdcfd)

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
Co-authored-by: Giteabot <teabot@gitea.io>
 2024-06-07 01:22:03 +02:00
wxiaoguang
e728fd741b
Fix Activity Page Contributors dropdown (#31264) 
Fix #31261
 2024-06-06 10:28:33 +08:00
wxiaoguang
fcc061ae44
Fix admin oauth2 custom URL settings (#31246) 
Fix #31244
 2024-06-04 23:06:21 +08:00
silverwind
138e946c3d
Replace gt-word-break with tw-break-anywhere (#31183) 
`overflow-wrap: anywhere` is a superior alternative to `word-wrap:
break-word` and we were already setting it in the class. I tested a few
cases, all look good.
 2024-06-04 13:57:11 +00:00
wxiaoguang
9000811118
Make pasted "img" tag has the same behavior as markdown image (#31235) 
Fix #31230

---------

Co-authored-by: Lunny Xiao <xiaolunwen@gmail.com>
 2024-06-04 12:19:41 +00:00
silverwind
4ca65fabda
Remove .segment from .project-column (#31204) 
Using `.segment` on the project columns is a major abuse of that class,
so remove it and instead set the border-radius directly on it.

Fixes: https://github.com/go-gitea/gitea/issues/31129
 2024-06-04 07:46:05 +00:00
silverwind
8c68c5e436
Move custom tw- helpers to tailwind plugin (#31184) 
Move the previous custom `tw-` classes to be defined in a tailwind
plugin. I think it's cleaner that way and I also verified double-class
works as expected:

<img width="299" alt="Screenshot 2024-05-30 at 19 06 24"
src="https://github.com/go-gitea/gitea/assets/115237/003cbc76-2013-46a0-9e27-63023fa7c7a4">
 2024-06-03 18:21:28 +00:00
silverwind
0f0db6a14f
Remove unnecessary inline style for tab-size (#31224) 
Move the rule to the parent node. `tab-size` is inherited so will work
just as before.
 2024-06-03 17:21:45 +00:00
silverwind
7034efc7dc
Use vertical layout for multiple code expander buttons (#31122) 
Fixes: https://github.com/go-gitea/gitea/issues/31068

- Now it only does a single call to `GetExpandDirection` per line
instead of multiples.
- Exposed `data-expand-direction` to frontend so it can correctly size
the buttons (it's a pain to do in tables).

<img width="142" alt="Screenshot 2024-05-27 at 20 44 56"
src="https://github.com/go-gitea/gitea/assets/115237/8b0b45a6-8e50-4081-8822-5e0775d8d941">
<img width="142" alt="Screenshot 2024-05-27 at 20 44 51"
src="https://github.com/go-gitea/gitea/assets/115237/b7ba2c57-8f55-4e9f-9606-c96d16b77892">
<img width="132" alt="Screenshot 2024-05-27 at 20 44 46"
src="https://github.com/go-gitea/gitea/assets/115237/0e838fb8-5e8c-4250-9843-a68b88d5418b">
<img width="80" alt="Screenshot 2024-05-27 at 20 44 33"
src="https://github.com/go-gitea/gitea/assets/115237/da6c7f83-c160-4389-8ab2-889d0568cbe8">
<img width="80" alt="Screenshot 2024-05-27 at 20 44 26"
src="https://github.com/go-gitea/gitea/assets/115237/cdb490b2-5040-484a-92e5-46fc5e37c199">
<img width="78" alt="Screenshot 2024-05-27 at 20 44 20"
src="https://github.com/go-gitea/gitea/assets/115237/d2978ab0-764e-41ff-922c-25f8fe749f28">

Would backport as trivial enhancement.
 2024-05-29 06:08:45 +00:00
silverwind
1e3c4d8fc7
Improve mobile review ui (#31091) 
Fixes: https://github.com/go-gitea/gitea/issues/31071

Not perfect but much better than before.

Before: Overflows, sticky not working, filename unreadable:

<img width="506" alt="Screenshot 2024-05-27 at 02 02 40"
src="https://github.com/go-gitea/gitea/assets/115237/a06b1edf-dece-4402-98c2-68670fca265f">

After:
<img width="457" alt="Screenshot 2024-05-27 at 01 59 06"
src="https://github.com/go-gitea/gitea/assets/115237/2a282c96-e719-4554-b418-81963ae6269c">
 2024-05-28 13:41:37 +00:00
silverwind
858d4f221d
Fix DashboardRepoList margin (#31121) 
Fixes: https://github.com/go-gitea/gitea/issues/31115

<img width="476" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/ba508ba9-b02d-47c6-ad9f-495101c81330">
 2024-05-28 02:13:42 +00:00
metiftikci
aa92b13164
Prevent simultaneous editing of comments and issues (#31053) 
fixes #22907 

Tested:
- [x] issue content edit
- [x] issue content change tasklist
- [x] pull request content edit
- [x] pull request change tasklist

![issue-content-edit](https://github.com/go-gitea/gitea/assets/29250154/a0828889-fb96-4bc4-8600-da92e3205812)
 2024-05-27 15:34:18 +00:00
Lunny Xiao
98751108b1
Rename project board -> column to make the UI less confusing (#30170) 
This PR split the `Board` into two parts. One is the struct has been
renamed to `Column` and the second we have a `Template Type`.

But to make it easier to review, this PR will not change the database
schemas, they are just renames. The database schema changes could be in
future PRs.

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: yp05327 <576951401@qq.com>
 2024-05-27 08:59:54 +00:00
silverwind
6e140b58dd
Prevent tab shifting, remove extra margin on fluid pages (#31090) 
1. Extend concept of https://github.com/go-gitea/gitea/pull/29831 to all
tabular menus, there were only three left that weren't already
`<overflow-menu>`.

<img width="634" alt="Screenshot 2024-05-27 at 00 42 16"
src="https://github.com/go-gitea/gitea/assets/115237/d9a7e219-d05e-40a1-9e93-777f9a8a90dd">
<img width="965" alt="Screenshot 2024-05-27 at 00 29 32"
src="https://github.com/go-gitea/gitea/assets/115237/e6ed71b1-11fb-4a74-9adb-af4524286cff">

2. Remove extra padding on `fluid padded` container like for example PR
diff view. The page margin is already correctly sized via
`.ui.container`, so this was just extraneous padding that looked ugly.

Before:
<img width="1351" alt="Screenshot 2024-05-27 at 00 45 11"
src="https://github.com/go-gitea/gitea/assets/115237/4b45fd11-b1b2-4fbb-a618-26eb22be9472">

After:
<img width="1344" alt="Screenshot 2024-05-27 at 00 45 22"
src="https://github.com/go-gitea/gitea/assets/115237/d09593eb-6c7f-45e7-85b6-f0050047004b">

3. Replace `gt-word-break` with `tw-break-anywhere` in issue-title,
fixing overflow.

Before:
<img width="1333" alt="Screenshot 2024-05-27 at 00 50 14"
src="https://github.com/go-gitea/gitea/assets/115237/64d15d04-b456-401e-a972-df636965f0eb">

After:
<img width="1316" alt="Screenshot 2024-05-27 at 00 50 26"
src="https://github.com/go-gitea/gitea/assets/115237/ed1ce830-1408-414b-8263-eeaf773f52c8">
 2024-05-27 06:45:16 +00:00
silverwind
145baa2b3f
Fix border radius on hovered secondary menu (#31089) 
Presumably a regression from
https://github.com/go-gitea/gitea/pull/30325, these menus were showing a
border radius on hover, which is fixed with this change.

<img width="154" alt="image"
src="https://github.com/go-gitea/gitea/assets/115237/eafdc1c5-3cf5-48d1-86c4-21c58f92cfaf">
 2024-05-27 04:48:41 +00:00
silverwind
2ced31e81d
Change --border-radius-circle to --border-radius-full (#30936) 
Percentage-based `border-radius` [creates undesirable
ellipse](https://jsfiddle.net/silverwind/j9ko5wnt/4/) on non-square
content. Instead, use pixel value and use same wording `full` like
tailwind does, but increast to 99999px over their 9999px.
 2024-05-25 14:33:34 +00:00
wxiaoguang
b6574099ed
Fix project column title overflow (#31011) 
By the way:
* Re-format the "color.go" to Golang code style
* Remove unused `overflow-y: scroll;` from `.project-column` because
there is `overflow: visible`
 2024-05-20 05:21:01 +00:00
wxiaoguang
740b6e1389
Fix JS error when editing a merged PR's title (#30990) 2024-05-16 13:04:25 +00:00
silverwind
ed25676a9a
Restyle release list, fix branch dropdown (#30837) 
Fixes https://github.com/go-gitea/gitea/issues/30821 and restyles the
release list.

Desktop:

<img width="1199" alt="Screenshot 2024-05-02 at 20 46 10"
src="https://github.com/go-gitea/gitea/assets/115237/bee92423-d4a9-4b26-8301-3a1e09eef4cd">


Mobile:

<img width="443" alt="Screenshot 2024-05-02 at 20 46 21"
src="https://github.com/go-gitea/gitea/assets/115237/42ecbae5-bdb6-4b16-a0ee-9c64daede68d">

---------

Co-authored-by: Giteabot <teabot@gitea.io>
 2024-05-13 23:33:51 +02:00
silverwind
301eaf60bf
Fix file path width in repo non-homepage view (#30951) 
Fixes: https://github.com/go-gitea/gitea/issues/30940

<img width="1310" alt="Screenshot 2024-05-11 at 20 48 41"
src="https://github.com/go-gitea/gitea/assets/115237/f163dfd4-1299-421f-a99e-cd0c793e0e3d">
 2024-05-12 04:02:25 +00:00
silverwind
46b7004f05
Enable declaration-block-no-redundant-longhand-properties (#30950) 
Enable
[`declaration-block-no-redundant-longhand-properties`](https://stylelint.io/user-guide/rules/declaration-block-no-redundant-longhand-properties/)
and autofix issues. The exclusions are because I find these two
shorthands to be harder to read.
 2024-05-12 02:33:05 +00:00
silverwind
3c2406a2f3
Use CSS inset shorthand (#30939) 
Use [inset](https://developer.mozilla.org/en-US/docs/Web/CSS/inset)
shorthand instead of longhands. There may be more cases but these ones I
was able to definitely identify.
 2024-05-11 14:28:56 +00:00
wxiaoguang
080486e47d
Fix some UI regressions for commit list (#30920) 
Close #30919

---------

Co-authored-by: silverwind <me@silverwind.io>
 2024-05-10 12:58:05 +00:00
silverwind
5556782ebe
Forbid deprecated break-word in CSS (#30934) 
Forbid
[deprecated](https://drafts.csswg.org/css-text-3/#word-break-property)
`break-word` and fix all occurences.

Regarding `overflow-wrap: break-word` vs `overflow-wrap: anywhere`:

Example of difference: https://jsfiddle.net/silverwind/1va6972r/

[Here](https://stackoverflow.com/questions/77651244) it says:

> The differences between normal, break-word and anywhere are only clear
if you are using width: min-content on the element containing the text,
and you also set a max-width. A pretty rare scenario.

I don't think this difference will make any practical impact as we are
not hitting this rare scenario.
 2024-05-10 12:25:49 +00:00
wxiaoguang
7424f27cf3
Check if reverse proxy is correctly configured (#30890) 
Follow #27011
Follow #30885

---------

Co-authored-by: silverwind <me@silverwind.io>
Co-authored-by: Giteabot <teabot@gitea.io>
 2024-05-10 20:07:01 +08:00
wxiaoguang
ed0fc2729e
Add missing menu active item background back (#30897) 
Fix #30578
 2024-05-08 23:01:25 +00:00
wxiaoguang
3fdb2d4ad8
Fix incorrect issue form (#30881) 
Fix #30864
 2024-05-08 15:39:13 +00:00