linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity

Set the initial commit status to Success otherwise it will always be Pending (#10317)

Browse Source 
The commit status code has a bug whereby setting the initial status to Pending means you can never have the status of Success - it should be set to Success.
This commit is contained in:
zeripath 2020-02-17 20:22:36 +00:00 committed by GitHub
parent 314740e215
commit e96f3542d0
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
services/pull/commit_status.go
View File

@ -23,7 +23,7 @@ func MergeRequiredContextsCommitStatus(commitStatuses []*models.CommitStatus, re
return structs.CommitStatusSuccess return structs.CommitStatusSuccess
} }
var returnedStatus = structs.CommitStatusPending var returnedStatus = structs.CommitStatusSuccess
for _, ctx := range requiredContexts { for _, ctx := range requiredContexts {
var targetStatus structs.CommitStatusState var targetStatus structs.CommitStatusState
for _, commitStatus := range commitStatuses { for _, commitStatus := range commitStatuses {