linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity

Remove jQuery .attr from the archive download and compare page branch selector (#29918)

Browse Source 
- Switched from jQuery `.attr` to plain javascript `.getAttribute`
- Tested the archive download and compare page branch selector
functionality and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
This commit is contained in:
Yarden Shoham 2024-03-20 02:04:24 +02:00 committed by GitHub
parent cb98e27992
commit dd043854ee
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web_src/js/features/repo-common.js
View File

@ -34,7 +34,7 @@ async function getArchive($target, url, first) {
export function initRepoArchiveLinks() { export function initRepoArchiveLinks() {
$('.archive-link').on('click', function (event) { $('.archive-link').on('click', function (event) {
event.preventDefault(); event.preventDefault();
const url = $(this).attr('href'); const url = this.getAttribute('href');
if (!url) return; if (!url) return;
getArchive($(event.target), url, true); getArchive($(event.target), url, true);
}); });
@ -80,10 +80,10 @@ export function initRepoCommonFilterSearchDropdown(selector) {
fullTextSearch: 'exact', fullTextSearch: 'exact',
selectOnKeydown: false, selectOnKeydown: false,
onChange(_text, _value, $choice) { onChange(_text, _value, $choice) {
if ($choice.attr('data-url')) { if ($choice[0].getAttribute('data-url')) {
window.location.href = $choice.attr('data-url'); window.location.href = $choice[0].getAttribute('data-url');
} }
}, },
message: {noResults: $dropdown.attr('data-no-results')}, message: {noResults: $dropdown[0].getAttribute('data-no-results')},
}); });
} }