linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity

Remove jQuery from the repo release form (#29225)

Browse Source 
- Switched to plain JavaScript
- Tested the repo release form functionality and it works as before

# Demo using JavaScript without jQuery

![action](https://github.com/go-gitea/gitea/assets/20454870/ede2072a-823d-418f-9890-a5a7445a1cc6)

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Yarden Shoham 2024-02-18 03:22:09 +02:00 committed by GitHub
parent 658cbddbfb
commit d73223bfc6
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

22
web_src/js/features/repo-release.js
View File

@ -1,19 +1,19 @@
import $ from 'jquery';
import {hideElem, showElem} from '../utils/dom.js'; import {hideElem, showElem} from '../utils/dom.js';
import {initComboMarkdownEditor} from './comp/ComboMarkdownEditor.js'; import {initComboMarkdownEditor} from './comp/ComboMarkdownEditor.js';
export function initRepoRelease() { export function initRepoRelease() {
$(document).on('click', '.remove-rel-attach', function() { document.addEventListener('click', (e) => {
const uuid = $(this).data('uuid'); if (e.target.matches('.remove-rel-attach')) {
const id = $(this).data('id'); const uuid = e.target.getAttribute('data-uuid');
$(`input[name='attachment-del-${uuid}']`).attr('value', true); const id = e.target.getAttribute('data-id');
hideElem($(`#attachment-${id}`)); document.querySelector(`input[name='attachment-del-${uuid}']`).value = 'true';
hideElem(`#attachment-${id}`);
}
}); });
} }
export function initRepoReleaseNew() { export function initRepoReleaseNew() {
const $repoReleaseNew = $('.repository.new.release'); if (!document.querySelector('.repository.new.release')) return;
if (!$repoReleaseNew.length) return;
initTagNameEditor(); initTagNameEditor();
initRepoReleaseEditor(); initRepoReleaseEditor();
@ -45,9 +45,9 @@ function initTagNameEditor() {
} }
function initRepoReleaseEditor() { function initRepoReleaseEditor() {
const $editor = $('.repository.new.release .combo-markdown-editor'); const editor = document.querySelector('.repository.new.release .combo-markdown-editor');
if ($editor.length === 0) { if (!editor) {
return; return;
} }
const _promise = initComboMarkdownEditor($editor); initComboMarkdownEditor(editor);
} }