linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity

Remove jQuery .attr from the commit graph (#30006)

Browse Source 
Switched from jQuery `.attr` to plain javascript `.getAttribute` and
`.setAttribute`

---------

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
This commit is contained in:
Yarden Shoham 2024-03-23 01:22:01 +02:00 committed by GitHub
parent dade40407e
commit d4ac1bd26e
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
web_src/js/features/repo-graph.js
View File

@ -18,13 +18,13 @@ export function initRepoGraphGit() {
window.history.replaceState({}, '', window.location.pathname); window.history.replaceState({}, '', window.location.pathname);
} }
$('.pagination a').each((_, that) => { $('.pagination a').each((_, that) => {
const href = $(that).attr('href'); const href = that.getAttribute('href');
if (!href) return; if (!href) return;
const url = new URL(href, window.location); const url = new URL(href, window.location);
const params = url.searchParams; const params = url.searchParams;
params.set('mode', 'monochrome'); params.set('mode', 'monochrome');
url.search = `?${params.toString()}`; url.search = `?${params.toString()}`;
$(that).attr('href', url.href); that.setAttribute('href', url.href);
}); });
}); });
$('#flow-color-colored').on('click', () => { $('#flow-color-colored').on('click', () => {
@ -32,13 +32,13 @@ export function initRepoGraphGit() {
$('#flow-color-monochrome').removeClass('active'); $('#flow-color-monochrome').removeClass('active');
$('#git-graph-container').addClass('colored').removeClass('monochrome'); $('#git-graph-container').addClass('colored').removeClass('monochrome');
$('.pagination a').each((_, that) => { $('.pagination a').each((_, that) => {
const href = $(that).attr('href'); const href = that.getAttribute('href');
if (!href) return; if (!href) return;
const url = new URL(href, window.location); const url = new URL(href, window.location);
const params = url.searchParams; const params = url.searchParams;
params.delete('mode'); params.delete('mode');
url.search = `?${params.toString()}`; url.search = `?${params.toString()}`;
$(that).attr('href', url.href); that.setAttribute('href', url.href);
}); });
const params = new URLSearchParams(window.location.search); const params = new URLSearchParams(window.location.search);
params.delete('mode'); params.delete('mode');