linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity

fix testing instructions in CONTRIBUTING.md (#6305)

Browse Source 
* add scripts/test-local.sh and fix CONTRIBUTING.md

- fixes #6243
- partial fix for #6269

Signed-off-by: Steve Traugott <stevegt@t7a.org>

* remove reference to possible automated drone run

* remove bash version of drone-cli test script

* fix issue number links in testing instructions

* remove scripts/test-local.sh
This commit is contained in:
stevegt 2019-03-18 01:38:08 +01:00 committed by Lunny Xiao
parent 1155f1b02d
commit cd8cdbd9d2
1 changed files with 20 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

29
CONTRIBUTING.md
View File

@ -64,15 +64,26 @@ high-level discussions.
## Testing redux ## Testing redux
Before sending code out for review, run all the tests for the Before submitting a pull request, run all the tests for the whole tree
whole tree to make sure the changes don't break other usage to make sure your changes don't cause regression elsewhere.
and keep the compatibility on upgrade. To make sure you are
running the test suite exactly like we do, you should install Here's how to run the test suite:
the CLI for [Drone CI](https://github.com/drone/drone), as
we are using the server for continuous testing, following [these - Install the correct version of the drone-cli package. As of this
instructions](http://docs.drone.io/cli-installation/). After that, writing, the correct drone-cli version is
you can simply call `drone exec --local --build-event "pull_request"` within [0.8.6](https://0-8-0.docs.drone.io/cli-installation/).
your working directory and it will try to run the test suite locally. - Ensure you have enough free disk space. You will need at least
15-20 Gb of free disk space to hold all of the containers drone
creates (a default AWS or GCE disk size won't work -- see
[#6243](https://github.com/go-gitea/gitea/issues/6243)).
- Change into the base directory of your copy of the gitea repository,
and run `drone exec --local --build-event pull_request`.
The drone version, command line, and disk requirements do change over
time (see [#4053](https://github.com/go-gitea/gitea/issues/4053) and
[#6243](https://github.com/go-gitea/gitea/issues/6243)); if you
discover any issues, please feel free to send us a pull request to
update these instructions.
## Vendoring ## Vendoring