linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity

Remove jQuery .attr from the label edit exclusive checkbox (#30053)

Browse Source 
- Switched from jQuery `attr` to plain javascript `getAttribute`
- Tested the label edit exclusive checkbox and it works as before

Signed-off-by: Yarden Shoham <git@yardenshoham.com>
This commit is contained in:
Yarden Shoham 2024-03-25 01:50:39 +02:00 committed by GitHub
parent 314cd1ec98
commit a7d0c5de4c
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
web_src/js/features/comp/LabelEdit.js
View File

@ -6,23 +6,23 @@ function isExclusiveScopeName(name) {
} }
function updateExclusiveLabelEdit(form) { function updateExclusiveLabelEdit(form) {
const $nameInput = $(`${form} .label-name-input`); const nameInput = document.querySelector(`${form} .label-name-input`);
const $exclusiveField = $(`${form} .label-exclusive-input-field`); const exclusiveField = document.querySelector(`${form} .label-exclusive-input-field`);
const $exclusiveCheckbox = $(`${form} .label-exclusive-input`); const exclusiveCheckbox = document.querySelector(`${form} .label-exclusive-input`);
const $exclusiveWarning = $(`${form} .label-exclusive-warning`); const exclusiveWarning = document.querySelector(`${form} .label-exclusive-warning`);
if (isExclusiveScopeName($nameInput.val())) { if (isExclusiveScopeName(nameInput.value)) {
$exclusiveField.removeClass('muted'); exclusiveField?.classList.remove('muted');
$exclusiveField.removeAttr('aria-disabled'); exclusiveField?.removeAttribute('aria-disabled');
if ($exclusiveCheckbox[0].checked && $exclusiveCheckbox.data('exclusive-warn')) { if (exclusiveCheckbox.checked && exclusiveCheckbox.getAttribute('data-exclusive-warn')) {
$exclusiveWarning.removeClass('tw-hidden'); exclusiveWarning?.classList.remove('tw-hidden');
} else { } else {
$exclusiveWarning.addClass('tw-hidden'); exclusiveWarning?.classList.add('tw-hidden');
} }
} else { } else {
$exclusiveField.addClass('muted'); exclusiveField?.classList.add('muted');
$exclusiveField.attr('aria-disabled', 'true'); exclusiveField?.setAttribute('aria-disabled', 'true');
$exclusiveWarning.addClass('tw-hidden'); exclusiveWarning?.classList.add('tw-hidden');
} }
} }