linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity

Revert "Do not send notifications for draft releases (#21451)" (#21594)

Browse Source 
This reverts commit a37e8b275d / #21451

Temporarily revert this PR to be able to continue discussion, and
potentially get it into 1.19.0
This commit is contained in:
techknowlogick 2022-10-25 18:00:00 -04:00 committed by GitHub
parent 5c2089a01d
commit 3f7cab42dc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
services/release/release.go
View File

@ -271,12 +271,13 @@ func UpdateRelease(doer *user_model.User, gitRepo *git.Repository, rel *repo_mod
}
}
if !rel.IsDraft {
if isCreated {
notification.NotifyNewRelease(rel)
} else {
if !isCreated {
notification.NotifyUpdateRelease(doer, rel)
return
}
if !rel.IsDraft {
notification.NotifyNewRelease(rel)
}
return err
@ -352,9 +353,7 @@ func DeleteReleaseByID(ctx context.Context, id int64, doer *user_model.User, del
}
}
if !rel.IsDraft {
notification.NotifyDeleteRelease(doer, rel)
}
return nil
}