linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity

Enable no-jquery/no-class-state (#31639)

Browse Source 
Just 4 validations and I specifically tested this by
selecting/unselecting issue labels.

Co-authored-by: Giteabot <teabot@gitea.io>
This commit is contained in:
silverwind 2024-07-16 12:14:27 +02:00 committed by GitHub
parent e8d4b7a8b1
commit 3a7454df7a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.eslintrc.yaml
View File

@ -512,7 +512,7 @@ rules:
no-jquery/no-box-model: [2] no-jquery/no-box-model: [2]
no-jquery/no-browser: [2] no-jquery/no-browser: [2]
no-jquery/no-camel-case: [2] no-jquery/no-camel-case: [2]
no-jquery/no-class-state: [0] no-jquery/no-class-state: [2]
no-jquery/no-class: [0] no-jquery/no-class: [0]
no-jquery/no-clone: [2] no-jquery/no-clone: [2]
no-jquery/no-closest: [0] no-jquery/no-closest: [0]

8
web_src/js/features/repo-legacy.ts
View File

@ -125,7 +125,7 @@ export function initRepoCommentForm() {
$listMenu.find('.item:not(.no-select)').on('click', function (e) { $listMenu.find('.item:not(.no-select)').on('click', function (e) {
e.preventDefault(); e.preventDefault();
if ($(this).hasClass('ban-change')) { if (this.classList.contains('ban-change')) {
return false; return false;
} }
@ -140,7 +140,7 @@ export function initRepoCommentForm() {
if (this.getAttribute('data-scope') !== scope) { if (this.getAttribute('data-scope') !== scope) {
return true; return true;
} }
if (this !== clickedItem && !$(this).hasClass('checked')) { if (this !== clickedItem && !this.classList.contains('checked')) {
return true; return true;
} }
} else if (this !== clickedItem) { } else if (this !== clickedItem) {
@ -148,7 +148,7 @@ export function initRepoCommentForm() {
return true; return true;
} }
if ($(this).hasClass('checked')) { if (this.classList.contains('checked')) {
$(this).removeClass('checked'); $(this).removeClass('checked');
$(this).find('.octicon-check').addClass('tw-invisible'); $(this).find('.octicon-check').addClass('tw-invisible');
if (hasUpdateAction) { if (hasUpdateAction) {
@ -187,7 +187,7 @@ export function initRepoCommentForm() {
const listIds = []; const listIds = [];
$(this).parent().find('.item').each(function () { $(this).parent().find('.item').each(function () {
if ($(this).hasClass('checked')) { if (this.classList.contains('checked')) {
listIds.push($(this).data('id')); listIds.push($(this).data('id'));
$($(this).data('id-selector')).removeClass('tw-hidden'); $($(this).data('id-selector')).removeClass('tw-hidden');
} else { } else {