linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity

routers/repo/issue: remove redundant format string

Browse Source
This commit is contained in:
Unknwon 2016-07-26 18:42:18 +08:00
parent 8aa0a76702
commit 29ccf047d8
1 changed files with 13 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

26
routers/repo/issue.go
View File

@ -74,7 +74,7 @@ func MustAllowPulls(ctx *context.Context) {
func RetrieveLabels(ctx *context.Context) { func RetrieveLabels(ctx *context.Context) {
labels, err := models.GetLabelsByRepoID(ctx.Repo.Repository.ID) labels, err := models.GetLabelsByRepoID(ctx.Repo.Repository.ID)
if err != nil { if err != nil {
ctx.Handle(500, "RetrieveLabels.GetLabels: %v", err) ctx.Handle(500, "RetrieveLabels.GetLabels", err)
return return
} }
for _, l := range labels { for _, l := range labels {
@ -181,14 +181,14 @@ func Issues(ctx *context.Context) {
SortType: sortType, SortType: sortType,
}) })
if err != nil { if err != nil {
ctx.Handle(500, "Issues: %v", err) ctx.Handle(500, "Issues", err)
return return
} }
// Get issue-user relations. // Get issue-user relations.
pairs, err := models.GetIssueUsers(repo.ID, posterID, isShowClosed) pairs, err := models.GetIssueUsers(repo.ID, posterID, isShowClosed)
if err != nil { if err != nil {
ctx.Handle(500, "GetIssueUsers: %v", err) ctx.Handle(500, "GetIssueUsers", err)
return return
} }
@ -212,14 +212,14 @@ func Issues(ctx *context.Context) {
// Get milestones. // Get milestones.
ctx.Data["Milestones"], err = models.GetAllRepoMilestones(repo.ID) ctx.Data["Milestones"], err = models.GetAllRepoMilestones(repo.ID)
if err != nil { if err != nil {
ctx.Handle(500, "GetAllRepoMilestones: %v", err) ctx.Handle(500, "GetAllRepoMilestones", err)
return return
} }
// Get assignees. // Get assignees.
ctx.Data["Assignees"], err = repo.GetAssignees() ctx.Data["Assignees"], err = repo.GetAssignees()
if err != nil { if err != nil {
ctx.Handle(500, "GetAssignees: %v", err) ctx.Handle(500, "GetAssignees", err)
return return
} }
@ -255,18 +255,18 @@ func RetrieveRepoMilestonesAndAssignees(ctx *context.Context, repo *models.Repos
var err error var err error
ctx.Data["OpenMilestones"], err = models.GetMilestones(repo.ID, -1, false) ctx.Data["OpenMilestones"], err = models.GetMilestones(repo.ID, -1, false)
if err != nil { if err != nil {
ctx.Handle(500, "GetMilestones: %v", err) ctx.Handle(500, "GetMilestones", err)
return return
} }
ctx.Data["ClosedMilestones"], err = models.GetMilestones(repo.ID, -1, true) ctx.Data["ClosedMilestones"], err = models.GetMilestones(repo.ID, -1, true)
if err != nil { if err != nil {
ctx.Handle(500, "GetMilestones: %v", err) ctx.Handle(500, "GetMilestones", err)
return return
} }
ctx.Data["Assignees"], err = repo.GetAssignees() ctx.Data["Assignees"], err = repo.GetAssignees()
if err != nil { if err != nil {
ctx.Handle(500, "GetAssignees: %v", err) ctx.Handle(500, "GetAssignees", err)
return return
} }
} }
@ -278,7 +278,7 @@ func RetrieveRepoMetas(ctx *context.Context, repo *models.Repository) []*models.
labels, err := models.GetLabelsByRepoID(repo.ID) labels, err := models.GetLabelsByRepoID(repo.ID)
if err != nil { if err != nil {
ctx.Handle(500, "GetLabelsByRepoID: %v", err) ctx.Handle(500, "GetLabelsByRepoID", err)
return nil return nil
} }
ctx.Data["Labels"] = labels ctx.Data["Labels"] = labels
@ -378,7 +378,7 @@ func ValidateRepoMetas(ctx *context.Context, form auth.CreateIssueForm) ([]int64
if milestoneID > 0 { if milestoneID > 0 {
ctx.Data["Milestone"], err = repo.GetMilestoneByID(milestoneID) ctx.Data["Milestone"], err = repo.GetMilestoneByID(milestoneID)
if err != nil { if err != nil {
ctx.Handle(500, "GetMilestoneByID: %v", err) ctx.Handle(500, "GetMilestoneByID", err)
return nil, 0, 0 return nil, 0, 0
} }
ctx.Data["milestone_id"] = milestoneID ctx.Data["milestone_id"] = milestoneID
@ -389,7 +389,7 @@ func ValidateRepoMetas(ctx *context.Context, form auth.CreateIssueForm) ([]int64
if assigneeID > 0 { if assigneeID > 0 {
ctx.Data["Assignee"], err = repo.GetAssigneeByID(assigneeID) ctx.Data["Assignee"], err = repo.GetAssigneeByID(assigneeID)
if err != nil { if err != nil {
ctx.Handle(500, "GetAssigneeByID: %v", err) ctx.Handle(500, "GetAssigneeByID", err)
return nil, 0, 0 return nil, 0, 0
} }
ctx.Data["assignee_id"] = assigneeID ctx.Data["assignee_id"] = assigneeID
@ -558,7 +558,7 @@ func ViewIssue(ctx *context.Context) {
} }
labels, err := models.GetLabelsByRepoID(repo.ID) labels, err := models.GetLabelsByRepoID(repo.ID)
if err != nil { if err != nil {
ctx.Handle(500, "GetLabelsByRepoID: %v", err) ctx.Handle(500, "GetLabelsByRepoID", err)
return return
} }
hasSelected := false hasSelected := false
@ -791,7 +791,7 @@ func UpdateIssueAssignee(ctx *context.Context) {
// Not check for invalid assignee id and give responsibility to owners. // Not check for invalid assignee id and give responsibility to owners.
issue.AssigneeID = aid issue.AssigneeID = aid
if err := models.UpdateIssueUserByAssignee(issue); err != nil { if err := models.UpdateIssueUserByAssignee(issue); err != nil {
ctx.Handle(500, "UpdateIssueUserByAssignee: %v", err) ctx.Handle(500, "UpdateIssueUserByAssignee", err)
return return
} }