linden123/githaven-fork
1
1
Fork 0
forked from Shiloh/githaven
Code Pull Requests Activity

Disable issue/PR comment button given empty input (#31463)

Browse Source 
Given an empty issue/PR comment, the comment history would not be
updated if the user were to submit it. Therefore, it would make since to
just disable the comment button when the text editor is empty.

This is inline with what GitHub does when given empty text editor input.

---------

Co-authored-by: wxiaoguang <wxiaoguang@gmail.com>
This commit is contained in:
Kemal Zebari 2024-06-23 11:41:01 -07:00 committed by GitHub
parent f4921b9daa
commit 0c4ff01109
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 18 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
templates/repo/issue/view_content.tmpl
View File

@ -106,7 +106,7 @@
</button> </button>
{{end}} {{end}}
{{end}} {{end}}
<button class="ui primary button"> <button id="comment-button" class="ui primary button">
{{ctx.Locale.Tr "repo.issues.create_comment"}} {{ctx.Locale.Tr "repo.issues.create_comment"}}
</button> </button>
</div> </div>

29
web_src/js/features/repo-issue.js
View File

@ -1,12 +1,12 @@
import $ from 'jquery'; import $ from 'jquery';
import {htmlEscape} from 'escape-goat'; import {htmlEscape} from 'escape-goat';
import {showTemporaryTooltip, createTippy} from '../modules/tippy.js'; import {createTippy, showTemporaryTooltip} from '../modules/tippy.js';
import {hideElem, showElem, toggleElem} from '../utils/dom.js'; import {hideElem, showElem, toggleElem} from '../utils/dom.js';
import {setFileFolding} from './file-fold.js'; import {setFileFolding} from './file-fold.js';
import {getComboMarkdownEditor, initComboMarkdownEditor} from './comp/ComboMarkdownEditor.js'; import {getComboMarkdownEditor, initComboMarkdownEditor} from './comp/ComboMarkdownEditor.js';
import {toAbsoluteUrl} from '../utils.js'; import {toAbsoluteUrl} from '../utils.js';
import {initDropzone} from './dropzone.js'; import {initDropzone} from './dropzone.js';
import {POST, GET} from '../modules/fetch.js'; import {GET, POST} from '../modules/fetch.js';
import {showErrorToast} from '../modules/toast.js'; import {showErrorToast} from '../modules/toast.js';
const {appSubUrl} = window.config; const {appSubUrl} = window.config;
@ -673,19 +673,24 @@ export function initRepoIssueBranchSelect() {
}); });
} }
export function initSingleCommentEditor($commentForm) { export async function initSingleCommentEditor($commentForm) {
// pages: // pages:
// * normal new issue/pr page, no status-button // * normal new issue/pr page: no status-button, no comment-button (there is only a normal submit button which can submit empty content)
// * issue/pr view page, with comment form, has status-button // * issue/pr view page: with comment form, has status-button and comment-button
const opts = {}; const opts = {};
const statusButton = document.querySelector('#status-button'); const statusButton = document.querySelector('#status-button');
if (statusButton) { const commentButton = document.querySelector('#comment-button');
opts.onContentChanged = (editor) => { opts.onContentChanged = (editor) => {
const statusText = statusButton.getAttribute(editor.value().trim() ? 'data-status-and-comment' : 'data-status'); const editorText = editor.value().trim();
statusButton.textContent = statusText; if (statusButton) {
}; statusButton.textContent = statusButton.getAttribute(editorText ? 'data-status-and-comment' : 'data-status');
} }
initComboMarkdownEditor($commentForm.find('.combo-markdown-editor'), opts); if (commentButton) {
commentButton.disabled = !editorText;
}
};
const editor = await initComboMarkdownEditor($commentForm.find('.combo-markdown-editor'), opts);
opts.onContentChanged(editor); // sync state of buttons with the initial content
} }
export function initIssueTemplateCommentEditors($commentForm) { export function initIssueTemplateCommentEditors($commentForm) {