From a6ffb5c61c96187f4a26264f2d197ee8e89ed50f Mon Sep 17 00:00:00 2001
From: Andras Bacsai <andras.bacsai@protonmail.com>
Date: Sat, 27 Aug 2022 20:42:04 +0000
Subject: [PATCH] fix: pr deployment

---
 apps/api/src/routes/api/v1/applications/handlers.ts | 2 +-
 apps/api/src/routes/webhooks/gitlab/handlers.ts     | 1 -
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/apps/api/src/routes/api/v1/applications/handlers.ts b/apps/api/src/routes/api/v1/applications/handlers.ts
index 1dda22dc5..1eadc625e 100644
--- a/apps/api/src/routes/api/v1/applications/handlers.ts
+++ b/apps/api/src/routes/api/v1/applications/handlers.ts
@@ -451,7 +451,7 @@ export async function deployApplication(request: FastifyRequest<DeployApplicatio
                     applicationId: id,
                     sourceBranch: branch,
                     branch: application.branch,
-                    pullmergeRequestId,
+                    pullmergeRequestId: pullmergeRequestId.toString(),
                     forceRebuild,
                     destinationDockerId: application.destinationDocker?.id,
                     gitSourceId: application.gitSource?.id,
diff --git a/apps/api/src/routes/webhooks/gitlab/handlers.ts b/apps/api/src/routes/webhooks/gitlab/handlers.ts
index df848e45c..52512c5fc 100644
--- a/apps/api/src/routes/webhooks/gitlab/handlers.ts
+++ b/apps/api/src/routes/webhooks/gitlab/handlers.ts
@@ -152,7 +152,6 @@ export async function gitLabEvents(request: FastifyRequest<GitLabEvents>) {
                     } else if (action === 'close') {
                         if (applicationFound.destinationDockerId) {
                             const id = `${applicationFound.id}-${pullmergeRequestId}`;
-                            const engine = applicationFound.destinationDocker.engine;
                             await removeContainer({ id, dockerId: applicationFound.destinationDocker.id });
                         }
                         return {