From 9eba058cf7b6bca0375a290e801d4f6be61022ec Mon Sep 17 00:00:00 2001 From: Andras Bacsai Date: Wed, 13 Sep 2023 12:08:44 +0200 Subject: [PATCH] fix: disable dockerfile based healtcheck for now --- app/Jobs/ApplicationDeploymentJob.php | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/app/Jobs/ApplicationDeploymentJob.php b/app/Jobs/ApplicationDeploymentJob.php index a92bf4939..81778203d 100644 --- a/app/Jobs/ApplicationDeploymentJob.php +++ b/app/Jobs/ApplicationDeploymentJob.php @@ -500,7 +500,7 @@ class ApplicationDeploymentJob implements ShouldQueue $this->destination->network => [ 'external' => true, 'name' => $this->destination->network, - 'attachable' => true, + 'attachable' => true ] ] ]; @@ -640,6 +640,10 @@ class ApplicationDeploymentJob implements ShouldQueue private function generate_healthcheck_commands() { + if ($this->application->dockerfile) { + // TODO: disabled HC because there are several ways to hc a simple docker image, hard to figure out a good way. Like some docker images (pocketbase) does not have curl. + return 'exit 0'; + } if (!$this->application->health_check_port) { $this->application->health_check_port = $this->application->ports_exposes_array[0]; }