From 93430e560763dbd19c1e8ba035a6799f1d0709a8 Mon Sep 17 00:00:00 2001
From: Andras Bacsai <andras.bacsai@gmail.com>
Date: Mon, 19 Dec 2022 23:07:01 +0100
Subject: [PATCH] fix: add default node_env variable

---
 apps/api/src/lib/buildPacks/compose.ts              | 2 +-
 apps/api/src/routes/api/v1/applications/handlers.ts | 8 +++++---
 apps/server/src/trpc/routers/applications/index.ts  | 2 +-
 3 files changed, 7 insertions(+), 5 deletions(-)

diff --git a/apps/api/src/lib/buildPacks/compose.ts b/apps/api/src/lib/buildPacks/compose.ts
index 8b380247c..229f44917 100644
--- a/apps/api/src/lib/buildPacks/compose.ts
+++ b/apps/api/src/lib/buildPacks/compose.ts
@@ -25,7 +25,7 @@ export default async function (data) {
 	if (!dockerComposeYaml.services) {
 		throw 'No Services found in docker-compose file.';
 	}
-	const envs = [];
+	const envs = ['NODE_ENV=production'];
 	if (secrets.length > 0) {
 		secrets.forEach((secret) => {
 			if (pullmergeRequestId) {
diff --git a/apps/api/src/routes/api/v1/applications/handlers.ts b/apps/api/src/routes/api/v1/applications/handlers.ts
index c0399959a..2d9acbd30 100644
--- a/apps/api/src/routes/api/v1/applications/handlers.ts
+++ b/apps/api/src/routes/api/v1/applications/handlers.ts
@@ -461,7 +461,8 @@ export async function restartApplication(request: FastifyRequest<RestartApplicat
             const { dockerRegistry, secrets, pullmergeRequestId, port, repository, persistentStorage, id: applicationId, buildPack, exposePort } = application;
             let location = null;
             const envs = [
-                `PORT=${port}`
+                `PORT=${port}`,
+                'NODE_ENV=production'
             ];
             if (secrets.length > 0) {
                 secrets.forEach((secret) => {
@@ -484,7 +485,7 @@ export async function restartApplication(request: FastifyRequest<RestartApplicat
                     } else {
                         if (!secret.isPRMRSecret) {
                             if (secret.value.includes('\\n')|| secret.value.includes("'")) {
-                            envs.push(`${secret.name}=${secret.value}`);
+														envs.push(`${secret.name}=${secret.value}`);
                             } else {
                             envs.push(`${secret.name}='${secret.value}'`);
                             }
@@ -1175,7 +1176,8 @@ export async function restartPreview(request: FastifyRequest<RestartPreviewAppli
             const { secrets, port, repository, persistentStorage, id: applicationId, buildPack, exposePort } = application;
 
             const envs = [
-                `PORT=${port}`
+                `PORT=${port}`,
+                'NODE_ENV=production'
             ];
             if (secrets.length > 0) {
                 secrets.forEach((secret) => {
diff --git a/apps/server/src/trpc/routers/applications/index.ts b/apps/server/src/trpc/routers/applications/index.ts
index bd27a8a47..563f9fb12 100644
--- a/apps/server/src/trpc/routers/applications/index.ts
+++ b/apps/server/src/trpc/routers/applications/index.ts
@@ -203,7 +203,7 @@ export const applicationsRouter = router({
 			let location = null;
 			const labels = [];
 			let image = null;
-			const envs = [`PORT=${port}`];
+			const envs = [`PORT=${port}`, 'NODE_ENV=production'];
 
 			if (secrets.length > 0) {
 				secrets.forEach((secret) => {