From 9168cd1dc6908ae5c3a63473bd454fcf93227947 Mon Sep 17 00:00:00 2001 From: Andras Bacsai Date: Mon, 25 Jul 2022 14:00:49 +0000 Subject: [PATCH] update todo --- TODO.md | 3 ++- apps/api/src/routes/api/v1/applications/handlers.ts | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/TODO.md b/TODO.md index 12e6d72ac..4cabd88fd 100644 --- a/TODO.md +++ b/TODO.md @@ -1,2 +1,3 @@ - RDE Application DNS check not working -- Check DNS configurations for app/service/coolify with RDE and local engines \ No newline at end of file +- Check DNS configurations for app/service/coolify with RDE and local engines +- Refactor PR deployments (/apps/api/src/routes/api/v1/applications/handlers.ts#L744) and create previews model inside coolify db? \ No newline at end of file diff --git a/apps/api/src/routes/api/v1/applications/handlers.ts b/apps/api/src/routes/api/v1/applications/handlers.ts index a32b50b5d..4b37b071b 100644 --- a/apps/api/src/routes/api/v1/applications/handlers.ts +++ b/apps/api/src/routes/api/v1/applications/handlers.ts @@ -733,7 +733,7 @@ export async function getPreviews(request: FastifyRequest) { const applicationSecrets = secrets.filter((secret) => !secret.isPRMRSecret); const PRMRSecrets = secrets.filter((secret) => secret.isPRMRSecret); const application = await prisma.application.findUnique({ where: { id }, include: { destinationDocker: true } }); - const { stdout } = await executeDockerCmd({ dockerId: application.destinationDocker.id, command: `docker container ls --filter 'name=${id}-' --format "{{json .}}"` }) + const { stdout } = await executeDockerCmd({ dockerId: application.destinationDocker.id, command: `docker container ls --filter 'name=${id}-' --format "{{json .}}"` }) if (stdout === '') { return { containers: [],