Shiloh/lasthourcloud
Shiloh/lasthourcloud
1
1
Fork 0
Code Issues Pull Requests Packages Projects Releases 4 Wiki Activity

Fix image environment variable bug

Browse Source
This commit is contained in:
Andras Bacsai 2024-04-02 15:40:25 +02:00
parent fd9dae6e4b
commit 6333d3fd13
1 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
app/Jobs/ApplicationDeploymentJob.php
View File

@ -325,6 +325,7 @@ private function deploy_simple_dockerfile()
executeInDocker($this->deployment_uuid, "echo '$dockerfile_base64' | base64 -d > {$this->workdir}{$this->dockerfile_location}")
],
);
// TODO: If the image exists and envs are changed, they are not applied.
$this->generate_image_names();
if (!$this->force_rebuild) {
$this->check_image_locally_or_remotely();
@ -1373,6 +1374,7 @@ private function generate_environment_variables($ports)
$environment_variables = collect();
if ($this->pull_request_id === 0) {
foreach ($this->application->runtime_environment_variables as $env) {
ray($env);
// This is necessary because we have to escape the value of the environment variable
// but only if the environment variable is created after 4.0.0-beta.240
// when I implemented the escaping feature.