From 086dd891440e9f10c83f9c3285bd4117aecd8b31 Mon Sep 17 00:00:00 2001
From: Andras Bacsai <andras.bacsai@gmail.com>
Date: Tue, 10 Jan 2023 11:50:41 +0100
Subject: [PATCH] fix: temporary disable dns check with dns servers

---
 .../src/routes/api/v1/applications/handlers.ts    | 15 +++++++++------
 apps/api/src/routes/api/v1/services/handlers.ts   | 15 +++++++++------
 2 files changed, 18 insertions(+), 12 deletions(-)

diff --git a/apps/api/src/routes/api/v1/applications/handlers.ts b/apps/api/src/routes/api/v1/applications/handlers.ts
index d9abbd852..4f0a2e9fe 100644
--- a/apps/api/src/routes/api/v1/applications/handlers.ts
+++ b/apps/api/src/routes/api/v1/applications/handlers.ts
@@ -764,7 +764,9 @@ export async function checkDomain(request: FastifyRequest<CheckDomain>) {
 			fqdn,
 			settings: { dualCerts }
 		} = await prisma.application.findUnique({ where: { id }, include: { settings: true } });
-		return await checkDomainsIsValidInDNS({ hostname: domain, fqdn, dualCerts });
+		// TODO: Disabled this because it is having problems with remote docker engines.
+		// return await checkDomainsIsValidInDNS({ hostname: domain, fqdn, dualCerts });
+		return {};
 	} catch ({ status, message }) {
 		return errorHandler({ status, message });
 	}
@@ -805,11 +807,12 @@ export async function checkDNS(request: FastifyRequest<CheckDNS>) {
 				remoteEngine,
 				remoteIpAddress
 			});
-		if (isDNSCheckEnabled && !isDev && !forceSave) {
-			let hostname = request.hostname.split(':')[0];
-			if (remoteEngine) hostname = remoteIpAddress;
-			return await checkDomainsIsValidInDNS({ hostname, fqdn, dualCerts });
-		}
+		// TODO: Disabled this because it is having problems with remote docker engines.
+		// if (isDNSCheckEnabled && !isDev && !forceSave) {
+		// 	let hostname = request.hostname.split(':')[0];
+		// 	if (remoteEngine) hostname = remoteIpAddress;
+		// 	return await checkDomainsIsValidInDNS({ hostname, fqdn, dualCerts });
+		// }
 		return {};
 	} catch ({ status, message }) {
 		return errorHandler({ status, message });
diff --git a/apps/api/src/routes/api/v1/services/handlers.ts b/apps/api/src/routes/api/v1/services/handlers.ts
index f090689b1..23e63ead9 100644
--- a/apps/api/src/routes/api/v1/services/handlers.ts
+++ b/apps/api/src/routes/api/v1/services/handlers.ts
@@ -505,7 +505,9 @@ export async function checkServiceDomain(request: FastifyRequest<CheckServiceDom
         const { id } = request.params
         const { domain } = request.query
         const { fqdn, dualCerts } = await prisma.service.findUnique({ where: { id } })
-        return await checkDomainsIsValidInDNS({ hostname: domain, fqdn, dualCerts });
+        // TODO: Disabled this because it is having problems with remote docker engines.
+        // return await checkDomainsIsValidInDNS({ hostname: domain, fqdn, dualCerts });
+        return {}
     } catch ({ status, message }) {
         return errorHandler({ status, message })
     }
@@ -531,11 +533,12 @@ export async function checkService(request: FastifyRequest<CheckService>) {
             throw { status: 500, message: `Domain ${getDomain(fqdn).replace('www.', '')} is already in use!` }
         }
         if (exposePort) await checkExposedPort({ id, configuredPort, exposePort, engine, remoteEngine, remoteIpAddress })
-        if (isDNSCheckEnabled && !isDev && !forceSave) {
-            let hostname = request.hostname.split(':')[0];
-            if (remoteEngine) hostname = remoteIpAddress;
-            return await checkDomainsIsValidInDNS({ hostname, fqdn, dualCerts });
-        }
+        // TODO: Disabled this because it is having problems with remote docker engines.
+        // if (isDNSCheckEnabled && !isDev && !forceSave) {
+        //     let hostname = request.hostname.split(':')[0];
+        //     if (remoteEngine) hostname = remoteIpAddress;
+        //     return await checkDomainsIsValidInDNS({ hostname, fqdn, dualCerts });
+        // }
         return {}
     } catch ({ status, message }) {
         return errorHandler({ status, message })