From 68a1a28b88c11d41a03dc957514fb9c9574cfc6c Mon Sep 17 00:00:00 2001 From: Florian HENRY Date: Sun, 1 Nov 2020 17:43:08 +0100 Subject: [PATCH 1/4] update documentation --- development/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/development/README.md b/development/README.md index 3bc2fa31..3cef19d7 100644 --- a/development/README.md +++ b/development/README.md @@ -73,7 +73,7 @@ bench set-redis-queue-host redis-queue:6379 bench set-redis-socketio-host redis-socketio:6379 ``` -### Edit Honcho's Procfile +### Edit Honcho's Procfile (if you didn't use "--skip-redis-config-generation"" option during bench init) Honcho is the tool used by Bench to manage all the processes Frappe requires. Usually, these all run in localhost, but in this case, we have external containers for Redis. For this reason, we have to stop Honcho from trying to start Redis processes. From a2c4ecef2dd1a0b4f226cc11c0abbc719d6734b7 Mon Sep 17 00:00:00 2001 From: Florian HENRY Date: Thu, 5 Nov 2020 20:07:08 +0100 Subject: [PATCH 2/4] review comment --- development/README.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/development/README.md b/development/README.md index 3cef19d7..efb28191 100644 --- a/development/README.md +++ b/development/README.md @@ -73,7 +73,7 @@ bench set-redis-queue-host redis-queue:6379 bench set-redis-socketio-host redis-socketio:6379 ``` -### Edit Honcho's Procfile (if you didn't use "--skip-redis-config-generation"" option during bench init) +### Edit Honcho's Procfile Honcho is the tool used by Bench to manage all the processes Frappe requires. Usually, these all run in localhost, but in this case, we have external containers for Redis. For this reason, we have to stop Honcho from trying to start Redis processes. @@ -88,6 +88,8 @@ Or running the following command: sed -i '/redis/d' ./Procfile ``` +Note: with the option '--skip-redis-config-generation' during bench init, this part is no more needed. But at least, take a look to ProcFile to see what going on when bench launch honcho on start + ### Create a new site with bench You can create a new site with the following command: From 3dedd7b0180bdbcbceac628cdd2c558277ba6fc0 Mon Sep 17 00:00:00 2001 From: Florian HENRY Date: Thu, 5 Nov 2020 20:07:48 +0100 Subject: [PATCH 3/4] review comment --- development/README.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/development/README.md b/development/README.md index efb28191..c524d525 100644 --- a/development/README.md +++ b/development/README.md @@ -75,6 +75,8 @@ bench set-redis-socketio-host redis-socketio:6379 ### Edit Honcho's Procfile +Note : With the option '--skip-redis-config-generation' during bench init, this part is no more needed. But at least, take a look to ProcFile to see what going on when bench launch honcho on start + Honcho is the tool used by Bench to manage all the processes Frappe requires. Usually, these all run in localhost, but in this case, we have external containers for Redis. For this reason, we have to stop Honcho from trying to start Redis processes. Open the Procfile file and remove the three lines containing the configuration from Redis, either by editing manually the file: @@ -88,8 +90,6 @@ Or running the following command: sed -i '/redis/d' ./Procfile ``` -Note: with the option '--skip-redis-config-generation' during bench init, this part is no more needed. But at least, take a look to ProcFile to see what going on when bench launch honcho on start - ### Create a new site with bench You can create a new site with the following command: From 3ec5c6563c3073312037b7ccf9afdc67537c052f Mon Sep 17 00:00:00 2001 From: Florian HENRY Date: Thu, 5 Nov 2020 20:09:12 +0100 Subject: [PATCH 4/4] review comment --- development/README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/development/README.md b/development/README.md index c524d525..a42cbf29 100644 --- a/development/README.md +++ b/development/README.md @@ -75,7 +75,7 @@ bench set-redis-socketio-host redis-socketio:6379 ### Edit Honcho's Procfile -Note : With the option '--skip-redis-config-generation' during bench init, this part is no more needed. But at least, take a look to ProcFile to see what going on when bench launch honcho on start +Note : With the option '--skip-redis-config-generation' during bench init, these actions are no more needed. But at least, take a look to ProcFile to see what going on when bench launch honcho on start command Honcho is the tool used by Bench to manage all the processes Frappe requires. Usually, these all run in localhost, but in this case, we have external containers for Redis. For this reason, we have to stop Honcho from trying to start Redis processes.