From 337a024a21c166e211fed7ad52f63c554afe2be3 Mon Sep 17 00:00:00 2001 From: Tengku Izdihar Date: Fri, 26 Jan 2024 12:48:26 +0700 Subject: [PATCH] frontend depends_on websocket to avoid error on startup (#1313) * frontend depends_on websocket to avoid error on startup * ci: fix lint --------- Co-authored-by: Revant Nandgaonkar --- .gitignore | 3 +++ devcontainer-example/devcontainer.json | 10 +++++----- pwd.yml | 2 ++ 3 files changed, 10 insertions(+), 5 deletions(-) diff --git a/.gitignore b/.gitignore index 61803ea8..94a9fe2f 100644 --- a/.gitignore +++ b/.gitignore @@ -25,3 +25,6 @@ development/* *.pyc __pycache__ venv + +# NodeJS +node_modules diff --git a/devcontainer-example/devcontainer.json b/devcontainer-example/devcontainer.json index 32671f22..d80b845d 100644 --- a/devcontainer-example/devcontainer.json +++ b/devcontainer-example/devcontainer.json @@ -5,11 +5,11 @@ "settings": { "terminal.integrated.profiles.linux": { "frappe bash": { - "path": "/bin/bash" - } + "path": "/bin/bash", + }, }, "terminal.integrated.defaultProfile.linux": "frappe bash", - "debug.node.autoAttach": "disabled" + "debug.node.autoAttach": "disabled", }, "dockerComposeFile": "./docker-compose.yml", "service": "frappe", @@ -20,6 +20,6 @@ "ms-vscode.live-server", "grapecity.gc-excelviewer", "mtxr.sqltools", - "visualstudioexptteam.vscodeintellicode" - ] + "visualstudioexptteam.vscodeintellicode", + ], } diff --git a/pwd.yml b/pwd.yml index 92fa42b1..52387d6c 100644 --- a/pwd.yml +++ b/pwd.yml @@ -90,6 +90,8 @@ services: frontend: image: frappe/erpnext:v15.10.6 + depends_on: + - websocket deploy: restart_policy: condition: on-failure