From 247a8e8e2da2c43f311a0c2534f16bbfa6ba2a72 Mon Sep 17 00:00:00 2001 From: Revant Nandgaonkar Date: Sat, 1 Aug 2020 23:24:09 +0530 Subject: [PATCH] fix: gitignore .devcontainer --- .gitignore | 3 +++ {.devcontainer => devcontainer-example}/devcontainer.json | 0 {.devcontainer => devcontainer-example}/docker-compose.yml | 0 development/README.md | 6 ++++++ 4 files changed, 9 insertions(+) rename {.devcontainer => devcontainer-example}/devcontainer.json (100%) rename {.devcontainer => devcontainer-example}/docker-compose.yml (100%) diff --git a/.gitignore b/.gitignore index c5aa2d25..e6ae4965 100644 --- a/.gitignore +++ b/.gitignore @@ -13,3 +13,6 @@ deploy_key.pub # Pycharm .idea + +# VS Code devcontainer +.devcontainer diff --git a/.devcontainer/devcontainer.json b/devcontainer-example/devcontainer.json similarity index 100% rename from .devcontainer/devcontainer.json rename to devcontainer-example/devcontainer.json diff --git a/.devcontainer/docker-compose.yml b/devcontainer-example/docker-compose.yml similarity index 100% rename from .devcontainer/docker-compose.yml rename to devcontainer-example/docker-compose.yml diff --git a/development/README.md b/development/README.md index f7e4bc25..607e53ed 100644 --- a/development/README.md +++ b/development/README.md @@ -22,6 +22,12 @@ git clone https://github.com/frappe/frappe_docker.git cd frappe_docker ``` +Copy example devcontainer config from `devcontainer-example` to `.devcontainer` + +```shell +cp -R devcontainer-example .devcontainer +``` + ## Use VSCode Remote Containers extension For most people getting started with Frappe development, the best solution is to use [VSCode Remote - Containers extension](https://marketplace.visualstudio.com/items?itemName=ms-vscode-remote.remote-containers).