brotherton-erpnext/erpnext
Glen Whitney f5a8dc0f9c
fix(Bank Reconciliation): update/merge CR/DR journal entry search (#23629)
* fix(Bank Reconciliation): update/merge CR/DR journal entry search

  Prior to this commit, the debit journal entry search (for
  credit-side Bank Transaction entries) and the corresponding
  credit journal entry search had diverged, with the latter
  working but the former not working. Thus, the search for
  journal entries matching a credit Bank Transaction (for the
  purposes of reconciliation) was never returning any matching
  journal entries, making reconciliation difficult.

  To fix this, this commit not only updates the debit journal
  entry search, but takes advantage of the fact that the two SQL
  queries for the two sides (debit/credit) differ only by the
  word "debit" or "credit," to merge the code for the two
  queries, making the code more DRY and hopefully reducing the
  chance of similar bugs occurring in the future.

* fix: message translation

Co-authored-by: Nabin Hait <nabinhait@gmail.com>
2020-10-19 16:49:55 +05:30
..
accounts fix(Bank Reconciliation): update/merge CR/DR journal entry search (#23629) 2020-10-19 16:49:55 +05:30
agriculture feat: updated desk pages (#21138) 2020-04-10 18:52:05 +05:30
assets Merge pull request #23588 from kevingdc/fix/asset-update-maintenance-status 2020-10-12 16:13:29 +05:30
buying Merge pull request #23443 from marination/rfq-email 2020-10-14 18:16:59 +05:30
change_log
commands
communication feat: add customer link to call log 2020-08-25 17:09:53 +05:30
config fix: Chart of Accounts (#23530) 2020-10-14 10:29:53 +05:30
controllers fix: cannot merge pos invoice if validate selling price is checked (#23593) 2020-10-12 18:31:23 +05:30
crm fix: displayings mandatory address field in Lead form 2020-10-13 17:33:58 +05:30
demo fix: Travis (#23606) 2020-10-13 16:53:10 +05:30
domains
education fix: duplicate validation for Course Enrollment (#23659) 2020-10-19 10:41:25 +05:30
erpnext_integrations fix(plaid): do not send null list in account ids (#23376) 2020-09-21 18:50:22 +05:30
healthcare fix: Patient Appointment not able to save (#23434) 2020-09-25 12:45:47 +05:30
hotels fix: conflicts 2020-02-27 13:16:53 +05:30
hr fix: fuel expense amount of vehicle log (#23632) 2020-10-16 12:32:59 +05:30
hub
hub_node fix(DocTypes): Reset "owner" values in DocTypes to Administrator (#23350) 2020-09-18 18:27:24 +05:30
loan_management Merge pull request #23301 from deepeshgarg007/closed_loan_amount 2020-09-08 21:32:54 +05:30
maintenance fix(DocTypes): Reset "owner" values in DocTypes to Administrator (#23350) 2020-09-18 18:27:24 +05:30
manufacturing Fixed incorrect operation time calculation develop (#23674) 2020-10-19 10:38:48 +05:30
non_profit fix: translate error log 2020-09-30 12:01:35 +05:30
patches fix: added patch to make custom field 'Print UOM after Quantity' 2020-10-08 16:41:23 +05:30
payroll fix: Travis (#23606) 2020-10-13 16:53:10 +05:30
portal Merge branch 'develop' into item-group-filter-portal 2020-08-31 16:42:47 +05:30
projects fix: removing unused imports (#23633) 2020-10-14 15:44:52 +05:30
public fix: set default filters on unchecking box, code cleanup 2020-10-15 12:21:43 +05:30
quality_management fix: review changes 2020-10-13 11:46:52 +05:30
regional feat: address template for luxembourg 2020-10-13 13:35:33 +02:00
restaurant chore: add query functions to whitelist 2020-07-02 12:35:41 +05:30
selling fix: not able to make material request from SO 2020-10-16 15:21:52 +05:30
setup fix: Chart of Accounts (#23530) 2020-10-14 10:29:53 +05:30
shopping_cart fix: Ui fixes 2020-09-24 16:37:08 +05:30
startup fix: Supplier Leaderboard fix 2020-09-03 19:45:04 +05:30
stock refactor: added new filters in the Batch-wise balance history report (#23676) 2020-10-19 11:37:54 +05:30
support refactor: Issue form cleaned up and renamed Minutes to First Response field (#23066) 2020-09-23 16:53:16 +05:30
templates Merge branch 'develop' into rfq-email 2020-10-12 18:02:15 +05:30
tests fix: typo in function name 2020-05-08 15:13:48 +05:30
translations chore: Update translations (#23677) 2020-10-19 11:19:27 +05:30
utilities fix: validate only for stock transactions 2020-10-10 21:56:50 +05:30
www fix: Update modified timestamp for Delivery Note Item 2020-07-17 10:35:16 +05:30
__init__.py fix: bump erpnext develop to version 13-dev (#21651) 2020-05-08 13:06:50 +05:30
exceptions.py
hooks.py fix: Cleanup code 2020-10-16 15:28:12 +05:30
modules.txt feat: New Payroll module (#21990) 2020-06-19 19:17:57 +05:30
patches.txt fix: added patch to make custom field 'Print UOM after Quantity' 2020-10-08 16:41:23 +05:30