a3ea985348
I just applied semgrep autofix. Untested completed, review before merging.
```yaml
- id: frappe-set-value-semantics
patterns:
- pattern-either:
- pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
- pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
message: |
If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
languages: [python]
severity: ERROR
```
17 lines
696 B
Python
17 lines
696 B
Python
import frappe
|
|
from frappe.model.utils.rename_field import rename_field
|
|
|
|
|
|
def execute():
|
|
frappe.reload_doc("stock", "doctype", "item")
|
|
frappe.reload_doc("stock", "doctype", "stock_settings")
|
|
frappe.reload_doc("accounts", "doctype", "accounts_settings")
|
|
|
|
rename_field("Stock Settings", "tolerance", "over_delivery_receipt_allowance")
|
|
rename_field("Item", "tolerance", "over_delivery_receipt_allowance")
|
|
|
|
qty_allowance = frappe.db.get_single_value("Stock Settings", "over_delivery_receipt_allowance")
|
|
frappe.db.set_single_value("Accounts Settings", "over_delivery_receipt_allowance", qty_allowance)
|
|
|
|
frappe.db.sql("update tabItem set over_billing_allowance=over_delivery_receipt_allowance")
|