brotherton-erpnext

History

fix: split_invoices_based_on_payment_terms (backport #37859 ) (#38488 )

* refactor: `split_invoices_based_on_payment_terms`

- Invoices were in the wrong order due to the logic. The invoices with payment terms were added first and the rest after.
- Overly long function with unnecessary loops (reduced to one main loop) and complexity
- The split row as per payment terms was not ordered. So the second installment was allocated first

(cherry picked from commit 6bd56d2d5f62814eb2f777934ed894bc5709e947)

* test: `get_outstanding_reference_documents` (triggered via UI)

(cherry picked from commit 162c0497d1db69e3af5f142459e3a875f03962af)

# Conflicts:
#	erpnext/accounts/doctype/payment_entry/test_payment_entry.py

* fix: Alert message and make sure invoice due dates are different for effective test

- Make invoice due dates are different so that the invoice with the earliest due date is allocated first in the test
- Translate voucher type, simplify alert message. The invoice could be "split" into 1 row, no. of rows in the message seems unnecessary.

(cherry picked from commit 56ac3424d22b68bbc551913133803686431d1694)

* style: Remove spaces introduced via merge conflict

(cherry picked from commit 4b4b176fcf99241bf17067989ebc850b2de24bcb)

# Conflicts:
#	erpnext/accounts/doctype/payment_entry/test_payment_entry.py

* fix: Re-add no.of rows split in alert message

(cherry picked from commit 1fc5844025d97de150195b94070b0c4061378992)

* fix: Merge conflicts in tests

---------

Co-authored-by: marination <maricadsouza221197@gmail.com>

2023-12-06 18:01:42 +05:30

account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

account_closing_balance

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

accounting_dimension

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

accounting_dimension_detail

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

accounting_dimension_filter

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

accounting_period

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

accounts_settings

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

advance_tax

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

advance_taxes_and_charges

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

allowed_dimension

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

allowed_to_transact_with

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

applicable_on_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_account_subtype

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_account_type

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_clearance

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_clearance_detail

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_guarantee

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_reconciliation_tool

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_statement_import

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_transaction

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_transaction_mapping

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

bank_transaction_payments

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

budget

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

budget_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

campaign_item

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

cashier_closing

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

cashier_closing_payments

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

chart_of_accounts_importer

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

cheque_print_template

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

closed_document

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

cost_center

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

cost_center_allocation

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

cost_center_allocation_percentage

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

coupon_code

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

currency_exchange_settings

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

currency_exchange_settings_details

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

currency_exchange_settings_result

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

customer_group_item

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

customer_item

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

discounted_invoice

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

dunning

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

dunning_letter_text

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

dunning_type

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

exchange_rate_revaluation

fix: remove hardcoded, implicit rounding loss allowance

2023-12-03 11:14:26 +00:00

exchange_rate_revaluation_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

finance_book

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

fiscal_year

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

fiscal_year_company

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

gl_entry

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

invoice_discounting

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

item_tax_template

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

item_tax_template_detail

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

journal_entry

refactor: ingore on JE cancel as well

2023-12-05 06:34:14 +00:00

journal_entry_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

journal_entry_template

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

journal_entry_template_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

ledger_merge

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

ledger_merge_accounts

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

loyalty_point_entry

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

loyalty_point_entry_redemption

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

loyalty_program

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

loyalty_program_collection

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

mode_of_payment

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

mode_of_payment_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

monthly_distribution

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

monthly_distribution_percentage

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

opening_invoice_creation_tool

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

opening_invoice_creation_tool_item

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

overdue_payment

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

party_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

party_link

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_entry

fix: split_invoices_based_on_payment_terms (backport #37859 ) (#38488 )

2023-12-06 18:01:42 +05:30

payment_entry_deduction

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_entry_reference

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_gateway_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_ledger_entry

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_order

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_order_reference

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_reconciliation

refactor: virtual doctype methods

2023-12-04 06:31:08 +00:00

payment_reconciliation_allocation

chore: resolve conflict

2023-12-04 12:16:41 +05:30

payment_reconciliation_invoice

refactor: convert payment reconciliation tool to virtual doctype

2023-12-04 06:31:07 +00:00

payment_reconciliation_payment

refactor: convert payment reconciliation tool to virtual doctype

2023-12-04 06:31:07 +00:00

payment_request

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_schedule

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_term

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_terms_template

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

payment_terms_template_detail

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

period_closing_voucher

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_closing_entry

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_closing_entry_detail

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_closing_entry_taxes

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_customer_group

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_field

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_invoice

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_invoice_item

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_invoice_merge_log

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_invoice_reference

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_item_group

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_opening_entry

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_opening_entry_detail

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_payment_method

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_profile

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_profile_user

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_search_fields

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pos_settings

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pricing_rule

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pricing_rule_brand

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pricing_rule_detail

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pricing_rule_item_code

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

pricing_rule_item_group

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

process_deferred_accounting

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

process_payment_reconciliation

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

process_payment_reconciliation_log

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

process_payment_reconciliation_log_allocations

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

process_statement_of_accounts

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

process_statement_of_accounts_customer

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

process_subscription

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

promotional_scheme

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

promotional_scheme_price_discount

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

promotional_scheme_product_discount

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

psoa_cost_center

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

psoa_project

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

purchase_invoice

refactor: ignore unreconcile doc on PI cancel/delete

2023-12-05 06:34:14 +00:00

purchase_invoice_advance

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

purchase_invoice_item

fix(ux): make valuation field read only when it can't be modified (backport #38450 ) (#38464 )

2023-11-30 17:30:35 +05:30

purchase_taxes_and_charges

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

purchase_taxes_and_charges_template

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

repost_accounting_ledger

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

repost_accounting_ledger_items

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

repost_accounting_ledger_settings

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

repost_allowed_types

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

repost_payment_ledger

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

repost_payment_ledger_items

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

sales_invoice

fix: use predefined onload property load_after_mapping (#38209 )

2023-12-04 09:36:52 +05:30

sales_invoice_advance

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

sales_invoice_item

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

sales_invoice_payment

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

sales_invoice_timesheet

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

sales_partner_item

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

sales_taxes_and_charges

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

sales_taxes_and_charges_template

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

share_balance

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

share_transfer

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

share_type

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

shareholder

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

shipping_rule

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

shipping_rule_condition

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

shipping_rule_country

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

south_africa_vat_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

subscription

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

subscription_invoice

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

subscription_plan

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

subscription_plan_detail

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

subscription_settings

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

supplier_group_item

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

supplier_item

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

tax_category

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

tax_rule

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

tax_withheld_vouchers

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

tax_withholding_account

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

tax_withholding_category

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

tax_withholding_rate

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

territory_item

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

unreconcile_payment

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

unreconcile_payment_entries

feat: enable automatic type annotations (backport #38452 ) (#38454 )

2023-11-30 14:43:16 +05:30

__init__.py

chore: remove utf-8 compat code

2021-11-05 11:16:29 +05:30