Commit Graph

104 Commits

Author SHA1 Message Date
Ankush Menat
fe597cdd3b chore: remove unused issue tempaltes
[skip ci]
2021-12-10 18:33:58 +05:30
Ankush Menat
fcb614d1b7 chore: correct form format for issues 2021-12-10 18:23:24 +05:30
Ankush Menat
bf48f17600 chore: new and improved bug report form
[skip ci]
2021-12-10 18:17:21 +05:30
Ankush Menat
ffa3d45c42 chore: update stale rules and apply on issues
[skip ci]
2021-12-10 18:17:21 +05:30
Conor
03370c63c5
chore: minor typo correction in CONTRIBUTING (#28386) 2021-11-14 09:46:31 +05:30
Ankush Menat
b728597ef4 fix: use hotfix branches for patch tests 2021-11-10 19:41:55 +05:30
Revant Nandgaonkar
c2697bca76 ci: change GITHUB_PAT to CI_PAT 2021-11-03 13:52:37 +05:30
Revant Nandgaonkar
c587f18735 chore: migrate docker to github actions 2021-11-02 12:09:41 +05:30
Ankush Menat
27cbeb920e test(patch): run patch tests for major releases
Run patch tests one at a time
v10 db -> v12-> v13 -> .... -> frappe:corresponding base branch and PR.
2021-11-01 17:44:46 +05:30
Ankush Menat
4ad2b851c4 chore: change semgrep rules repo name
[skip ci]
2021-10-22 22:39:11 +05:30
Ankush Menat
cc1baae5eb
ci: move semgrep rules out of repo (#28067)
Moving semgrep rules out of repos as it's unnecessary to maintain
same ruleset for different repos and different branches.
2021-10-22 21:43:50 +05:30
Ankush Menat
5ada11b1af ci: run semgrep after basic linters 2021-10-20 19:09:57 +05:30
Ankush Menat
92c0dcc3ea ci: install dev requirements in CI 2021-10-20 19:09:57 +05:30
gavin
9916b87767
ci: Rule Added for using frappe.qb over db.sql* (#28000)
ERPNext port of https://github.com/frappe/frappe/pull/14481


Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
Co-authored-by: abhishek <as7122000@gmail.com>
2021-10-19 14:20:09 +05:30
Mohammad Hussain Nagaria
904381295e
chore: Add Try on Frappe Cloud button to README (#27950) 2021-10-13 20:07:27 +05:30
Ankush Menat
06b426e9c3
ci: rule to fail PRs that add a new manual commit (#27928)
Manual commits are frequent source of bugs, confusions or undefined
behaviour.

All new manual commits should be explcitly ignored with explanation on
why it's added. This will only fail for new additions. Existing ones
need to be cleaned up manually.
2021-10-12 23:01:37 +05:30
ChillarAnand
4dc17a856e fix(CI): Use bugbear instead of flake8-mutable 2021-10-11 11:17:55 +05:30
Chillar Anand
772d4753e7
refactor: Clean up mutable defaults and add CI check (#27828)
* refactor: Clean up mutable defaults and add CI check
2021-10-06 16:58:48 +00:00
Ankush Menat
35e30bdcaf
ci: fail build if asset bundling fails (#27820) 2021-10-05 21:44:34 +05:30
Suraj Shetty
1fc8fcc258 ci: Upload coverage report to codecov 2021-09-10 08:08:00 +05:30
Dany Robert
fa819f2fb0
fix: General Ledger translation issues (#27298)
* fix: remove translations from GL report options

Options need not be translated, their display label gets translated
client side.

* fix: make group by options translatable

* ci: semgrep rule for translated options in report

Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-09-08 16:28:05 +05:30
Ankush Menat
5596988c94
ci: fix docs checker for wiki based docs (#27380) 2021-09-07 14:53:30 +05:30
Chillar Anand
915b34391c
chore: Clean up imports (#27302)
* chore: Added isort to pre-commit config

* chore: Sort imports with isort

* chore: Clean up imports with pycln

* chore: Sort imports with isort

* chore: Fix import issues

* chore: Clean up sider issues

* chore: Remove import errors from flake8 ignore list

* chore: Clean up lint issues
2021-09-02 16:44:59 +05:30
Ankush Menat
65279c2471
ci: add strict config for flake8 2021-09-01 16:57:21 +05:30
Alan
72ece75b11
ci(semgrep): add translation checks for report labels (#27280)
* ci(semgrep): add translation checks for report labels

* refactor: shift report tests to it's own yml

path can't be applied on a test id basis

* ci: ignore regional report in translation checks

[skip ci]
2021-09-01 14:19:39 +05:30
gavin
dea14eef51
Merge pull request #27240 from ankush/ubuntu_ci
ci: switch to latest LTS Ubuntu version
2021-08-31 18:22:30 +05:30
Ankush Menat
602374a0a4
ci: switch to latest LTS Ubuntu version 2021-08-30 19:32:53 +05:30
Ankush Menat
9de0f7538f
ci: concurrency control for CI jobs (#27230)
similar to https://github.com/frappe/frappe/pull/14061

This will ensure that only one instance of the following tests run per
PR and cancel previous running/queued jobs when new commits are pushed.

- Server / unit tests
- UI tests
- Patch test
2021-08-30 14:07:13 +05:30
Ankush Menat
e5e00700e5
ci: use node action instead of apt (#27220) 2021-08-30 12:07:11 +05:30
Ankush Menat
ae55eab599
chore: remove deprecated and empty QUnit tests (#27179)
* chore: remove deprecated and empty QUnit tests

* ci: fix UI test config

Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.
2021-08-26 20:43:06 +05:30
Ankush Menat
8bbec42fa0
fix: undo changes to patch (#26983)
* fix: undo changes to patch

* ci: ignore empty body / head
2021-08-17 15:14:13 +05:30
Rucha Mahabal
39efc62b94
feat: Organizational Chart (#26893)
* feat: Organizational Chart

* feat: org chart mobile interactions

* feat(mobile): sibling node group expansion and rendering

* fix: expanded node group interactions and visibility

* feat: connectors for mobile node cards

* fix: don't refresh connections for same node

- remove all connectors while expanding a group node

* chore: create separate files for Desktop and Mobile view and bundle assets

* refactor: add options to chart

- method to return the node data

- wrapper for showing the hierarchy

* feat: setup node edit action

* fix: revert changes in employee descendants query

* refactor: use arcs instead of bezier curves for cleaner connectors

* feat: add arc to connectors in mobile view

* fix: edit node button overflowing

* fix: sider

* fix: removing orphaned connectors

* fix: unnecessary variables

* feat: handle multiple root / orphan nodes

* perf: Optimise Rendering

- optimise get_children function

- use promises instead of callbacks

- optimise selectors

- use const wherever possible

- use pure js instead of jquery for connectors for faster rendering

* fix: do not sort by number of connections

* feat: use icon for connections on mobile view

* fix: exclude active node while fetching sibling group

* fix: sibling group expansion not working for root nodes

* fix(mobile): collapsed nodes not expanding

* fix: sider

* test: UI tests for org chart desktop

* test: UI tests for org chart mobile

fix(mobile): detach node before emptying hierarchy

fix(mobile): sibling group not rendering for first level

* fix: sider

* ci(cypress): use env variable for key

documentation ref: https://docs.cypress.io/guides/guides/command-line\#cypress-run

* fix(tests): clear filter before typing

* fix(tests): apply filters correctly

* fix: tests

* fix: tests

* fix: tests

* fix(test): increase timeout for record creation

* fix: sider

* fix: sider

* feat: Expand All nodes option in Desktop view

* feat: add html2canvas for easily exporting html to images using canvas

* feat: Export chart option in desktop view

* fix(style): longer titles overflowing

* fix: remove unnecessary imports

* fix: test

* fix: make bundled assets for hierarchy chart

* fix(style): apply svg container margin only in desktop view

* fix: Nest `.level` class style under `.hierarchy` class (#26905)

fix: Nest `.level` class style under `.hierarchy` class

* fix: add z-index to filter to avoid svg wrapper overlapping

* fix: expand all nodes not working when there are only 2 levels

- added dom freeze while expanding all nodes and exporting

* fix: test

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-16 20:42:23 +05:30
Ankush Menat
2a43fe1a22
ci: ignore backports while checking docs (#26962)
[skip ci]
2021-08-16 18:03:21 +05:30
Rucha Mahabal
4981746b9a
Merge branch 'develop' into org-chart-develop 2021-08-15 20:50:56 +05:30
Ankush Menat
8a6b82b196
ci: ignore js files in unittests (#26934)
* ci: ignore js files in unittests

- Avoid running python unittests on PRs that ONLY change JS files.

* ci: ignore md files in test workflows
2021-08-13 12:59:27 +05:30
Rucha Mahabal
9dfddca22e ci(cypress): use env variable for key
documentation ref: https://docs.cypress.io/guides/guides/command-line\#cypress-run
2021-08-10 17:56:23 +05:30
Ankush
0bb60b37df
chore: add timeout to GHA workflows (#26714) 2021-07-29 17:15:12 +05:30
Ankush
e906acdc49
chore: change location of backport action (#26705) 2021-07-29 13:56:21 +05:30
Ankush
057a0a9842
ci: auto backport squashed commits based on labels (#26622) 2021-07-25 12:49:05 +05:30
Ankush Menat
28d52c4a95
chore: remove warning rules
semgrep-action doesn't consider severity, hence ignoring these rules for now.
2021-07-21 19:54:06 +05:30
Suraj Shetty
47f200a70d
chore: Update stale.yml
reduce `daysUntilStale` & `daysUntilClose` to keep the contributors active.
2021-07-20 16:13:49 +05:30
Ankush
a6d80dcc2a
chore: disable semgrep on push events (#26523) 2021-07-16 13:01:57 +05:30
Ankush
1b5f3cf605
ci: make semgrep ignore existing errors (#26516) 2021-07-15 19:30:05 +05:30
Ankush Menat
203c2b2292 ci: show bench logs if ui test fails 2021-07-12 10:09:50 +05:30
Ankush Menat
a68344fe8a refactor: extend commands from frappe 2021-07-01 21:26:18 +05:30
Ankush Menat
3f14b92e2c ci: UI tests workflow 2021-07-01 21:26:18 +05:30
Suraj Shetty
e8e4841e5e ci: Build frappe assets
- Build frappe assets since it is used for print views
2021-06-17 20:23:18 +05:30
Gavin D'souza
c68006b607 ci: Update ERPNext backup patch test >= v10
* Generated v10 backup archive
    * used old v7 erpnext backup hosted via build.erpnext.com
    * upgraded to v10 frappe + erpnext
* Hosted backup on https://erpnext.com/files/v10-erpnext.sql.gz
2021-06-04 11:49:56 +05:30
Suraj Shetty
5b17f335d1
ci: Add coveralls_repo_token env variable 2021-06-01 08:18:56 +05:30
Nabin Hait
a3d1b6973a fix: merge conflict 2021-05-31 11:21:33 +05:30