Himanshu
eba3a8e802
fix: get contact details ( #19281 )
2019-10-11 10:43:24 +05:30
Rohit Waghchaure
4494d46020
fix: name 'link_link_doctype' is not defined
2019-10-10 14:17:06 +05:30
Pranav Nachanekar
aa918e8528
moved validations to sepeate functions
2019-10-09 15:49:48 +05:30
Pranav Nachanekar
9ccc43980b
Merge branch 'develop' of https://github.com/0Pranav/erpnext into develop
2019-10-09 14:17:37 +05:30
Pranav Nachnekar
50e66d81de
fix: use get_single_value
...
Co-Authored-By: Shivam Mishra <scmmishra@users.noreply.github.com>
2019-10-09 08:43:18 +00:00
Pranav Nachanekar
604febb398
fix: set_verified method contained js
2019-10-09 14:09:47 +05:30
Pranav Nachnekar
96930e25f3
fix: readability
...
Co-Authored-By: Shivam Mishra <scmmishra@users.noreply.github.com>
2019-10-09 08:31:37 +00:00
Pranav Nachnekar
5e4ec85574
remove:unnecessary translation
...
Co-Authored-By: Shivam Mishra <scmmishra@users.noreply.github.com>
2019-10-09 08:23:54 +00:00
Pranav Nachnekar
1f1b7eb7d5
Merge branch 'develop' into develop
2019-10-07 06:12:45 +00:00
Pranav Nachanekar
e18388ade3
fix:add exception for no opportunity
2019-10-04 16:32:32 +05:30
Pranav Nachanekar
911e034d1c
fix: syntax error
2019-10-04 15:50:02 +05:30
Pranav Nachanekar
0082b78075
fix:incosistent tabs and spaces
2019-10-04 15:36:36 +05:30
Pranav Nachanekar
bfe18d6085
feat:assign appointments from opportunity
2019-10-04 14:41:54 +05:30
Pranav Nachanekar
c1bc0f9dfb
fix: added sections for settings
2019-10-04 11:36:53 +05:30
Pranav Nachanekar
25148d0de5
fix:readability
2019-10-04 11:32:39 +05:30
Pranav Nachanekar
22189ec9e8
remove unnecessary doctype 'Timezone'
2019-10-04 11:07:04 +05:30
Pranav Nachanekar
a1d39cab21
fix: travis
2019-10-03 18:26:02 +05:30
Pranav Nachanekar
d40c020e0e
fix:variable names
2019-10-03 17:43:31 +05:30
Pranav Nachanekar
bec88bc52a
fix: exists return tuple not string
2019-10-03 16:58:38 +05:30
Pranav Nachanekar
afe52e8e09
feat: add check for toggling the route
2019-10-03 16:35:08 +05:30
Pranav Nachanekar
72aac09d62
fix:remove tearDown from test
2019-10-03 16:09:50 +05:30
Pranav Nachanekar
43331564b4
fix:class variable in tests
2019-10-03 15:29:09 +05:30
Pranav Nachanekar
42cf5f279f
fix:added class variables to test
2019-10-03 14:26:21 +05:30
Pranav Nachanekar
8640a01f85
remove duplicate day validation
2019-10-03 13:32:57 +05:30
Pranav Nachanekar
1dccc039b7
fix:add tear down to tests
2019-10-03 13:32:46 +05:30
Pranav Nachanekar
76cbb9132f
fix: more test errors
2019-10-03 12:50:55 +05:30
Pranav Nachanekar
c5420bb453
fix: remove validation for repeated days
2019-10-03 12:06:43 +05:30
Pranav Nachanekar
1dcedb5054
fix: empty leads and appointment in test
2019-10-03 11:56:54 +05:30
gavin
be8f6f0d65
fix: report ~ lead conversion time ( #19232 )
2019-10-03 11:36:04 +05:30
Rohan
d463c346fe
fix: set no-copy on some contract fields ( #19208 )
2019-09-30 16:37:29 +05:30
Pranav Nachanekar
2ea9b3e6f2
fix:test appointments
2019-09-30 15:35:38 +05:30
Mangesh-Khairnar
d8763d7d65
fix: allow rename/merge in opportunity ( #19202 )
2019-09-30 14:39:46 +05:30
Pranav Nachanekar
7f4bc64d22
fix:appointment tests exist check
2019-09-30 13:58:42 +05:30
Himanshu
25ab1e41df
fix(Contact): mobile_no re-introduced and travis fixes ( #19009 )
...
* fix: mobile_no re-introduced
* fix: test cases
* fix: set email as primary
* fix: add primary email and phone
* fix: utils for contact creation
* chore: remove = from dict
2019-09-30 10:08:15 +05:30
Pranav Nachanekar
fd46bf2616
fix codacy
2019-09-25 16:01:48 +05:30
Pranav Nachanekar
774167192a
Merge branch 'develop' of https://github.com/0Pranav/erpnext into develop
2019-09-25 13:12:32 +05:30
Pranav Nachanekar
291e161793
Added permissions for sales user
2019-09-25 13:11:04 +05:30
Pranav Nachanekar
9f86022c2b
fix: Error in test setUp
2019-09-24 16:07:41 +05:30
Pranav Nachanekar
c9cf5aebea
Changed required values, add clientside validation
2019-09-24 12:08:37 +05:30
Nabin Hait
7ab861fe95
Merge branch 'develop' into develop
2019-09-24 11:50:38 +05:30
Pranav Nachanekar
558d44e519
Removed auto-assignment for unverified appointments
2019-09-24 11:33:57 +05:30
Mangesh-Khairnar
5dcf2c669f
chore: remove unlinked letter head references ( #19138 )
2019-09-24 09:53:06 +05:30
Pranav Nachanekar
8393ebbbca
Fixed missing permission in update
2019-09-23 17:14:31 +05:30
Pranav Nachanekar
8b744b2d03
Added request verification and url encoding
2019-09-23 15:55:35 +05:30
Pranav Nachanekar
a35e34b5f0
FIxed typos and create_lead method
2019-09-23 14:38:22 +05:30
Pranav Nachanekar
3eccb84eaa
Fixed update method
2019-09-23 14:25:42 +05:30
Pranav Nachanekar
b6b27d9256
Corrected moving to doctype for email
2019-09-23 14:16:13 +05:30
Pranav Nachanekar
7b7962d28c
Added test cases
2019-09-23 13:05:18 +05:30
Pranav Nachanekar
dcfc849946
Moved email to appoitnmetn doctype
2019-09-23 11:52:26 +05:30
Pranav Nachanekar
f8cc86bfed
Moved email from class variable to doctype
...
Formatting
Made methods which link other doctypes idempotent
2019-09-23 11:28:05 +05:30
Pranav Nachanekar
0800031c0d
Addee email to appointment doctyoe
...
and asthetic changes
2019-09-23 11:26:46 +05:30
Pranav Nachanekar
6b0fea16b6
Added buttons to linked docs
2019-09-23 11:26:18 +05:30
Pranav Nachanekar
9c0f462336
Fixed Syntax errors
2019-09-20 10:51:56 +05:30
Pranav Nachanekar
aa7d0c0163
Merge branch 'develop' of https://github.com/0Pranav/erpnext into develop
2019-09-20 10:47:18 +05:30
Pranav Nachanekar
73420e462f
Added email
2019-09-20 10:44:52 +05:30
Pranav Nachanekar
fa4a2a53e8
Added email
2019-09-20 10:41:59 +05:30
Pranav Nachanekar
df1a5a9633
Added flow for verifying emails
2019-09-20 10:08:48 +05:30
Pranav Nachanekar
5324234bd0
Removed required lead
2019-09-20 10:08:26 +05:30
Pranav Nachanekar
ca2509423a
Added permissions for HR manager
2019-09-19 12:36:51 +05:30
Pranav Nachanekar
4109f88c04
Linked send_reminder in calendar event
...
to Appointment Booking Settings
2019-09-19 12:08:10 +05:30
Pranav Nachanekar
5bf52ebed6
limit assigment load to appointment day
2019-09-19 11:47:54 +05:30
Pranav Nachanekar
ec1dae023c
styling
2019-09-18 16:13:29 +05:30
Pranav Nachanekar
7d476a3e35
Moved lead assignment to the controller
2019-09-18 15:33:31 +05:30
Pranav Nachanekar
3c8bea65ef
Merged with local
2019-09-18 10:39:11 +05:30
Pranav Nachnekar
57c311f8e9
Merge branch 'develop' into develop
2019-09-18 10:33:39 +05:30
Pranav Nachanekar
91a564989f
Styling and PR review changes
2019-09-17 16:58:41 +05:30
Suraj Shetty
627a3dcd6d
feat: Default energy point rules ( #19003 )
...
* feat: Add default energy point rules during install
* fix: Add completed_by field to task doctype
* fix: Rule data
* fix: Add default rules for opportunity
* fix: Add a patch to create default energy point rules
* fix: Default success action message
* fix: Use .items() instead of .iteritems()
* fix: Add "create_default_energy_points" patch entry
* fix: Reload Energy Point Rule to fix patch
* fix: Import frappe
2019-09-17 15:54:41 +05:30
Pranav Nachnekar
33daf281bd
Merge branch 'develop' into develop
2019-09-17 14:14:16 +05:30
Pranav Nachnekar
a8752db012
Typo and styling fixes
...
Co-Authored-By: Shivam Mishra <scmmishra@users.noreply.github.com>
2019-09-16 20:02:20 +05:30
Rushabh Mehta
72dcb51177
fix(minor): opportunity_from may not be selected ( #19063 )
2019-09-16 14:47:43 +05:30
Pranav Nachanekar
018f0d3bbd
Fixed issue: agents weren't looked up in settings
2019-09-13 16:52:06 +05:30
Pranav Nachanekar
1cd762e9d0
Added ajuto assignment
2019-09-13 15:56:54 +05:30
Pranav Nachanekar
cf045d86b0
fixed typo
2019-09-13 15:55:54 +05:30
Pranav Nachanekar
a3b8c77af1
Fixed leads
2019-09-12 15:19:22 +05:30
Pranav Nachanekar
1564f1476c
Added customer to calender event
2019-09-12 14:24:28 +05:30
Pranav Nachanekar
469247bf73
Change max date of datepicker
...
to number of days in future as specified by the settings
2019-09-12 11:15:42 +05:30
Pranav Nachanekar
a2dbd391b3
Add lead and calender event to appointments
2019-09-12 10:48:26 +05:30
Pranav Nachanekar
8051ca1859
Limit advance booking of appointments
2019-09-12 10:47:45 +05:30
Pranav Nachanekar
249cdd92e0
Added uniqueness check for offset
2019-09-11 14:59:25 +05:30
Pranav Nachanekar
e543fc483f
Removed email reminders
...
As it will be handled by calender event in the future
2019-09-11 14:59:13 +05:30
Pranav Nachanekar
0cc837eac5
Create event for the appointment
...
TODO: Add lead and employee to this
2019-09-11 14:12:30 +05:30
Pranav Nachanekar
5038d6a6db
Removed appointment tests
...
TODO: Write better tests after adding lead and calender event generation
2019-09-11 10:31:04 +05:30
Pranav Nachanekar
2d7370a525
Moved delete_appointment
2019-09-10 16:46:17 +05:30
Pranav Nachanekar
c4950a0281
Added doctype
...
availabitlity of slots added
2019-09-10 15:10:51 +05:30
Pranav Nachanekar
5c211d8abf
fixed codacy
2019-09-10 11:52:55 +05:30
Pranav Nachanekar
06facea895
added doctype
2019-09-09 17:09:03 +05:30
Pranav Nachanekar
110f4ea0c9
Formatting
2019-09-09 17:04:25 +05:30
Pranav Nachanekar
db21f86b26
Removed unneccessary doctype
2019-09-09 17:01:40 +05:30
Pranav Nachanekar
5945144c08
Added tests
2019-09-09 16:35:48 +05:30
Pranav Nachanekar
10711dd09d
Refactor UI
2019-09-09 15:41:20 +05:30
Pranav Nachanekar
48e43e2421
build fix
2019-09-09 14:43:55 +05:30
Pranav Nachanekar
217aadba7e
Better autoname
2019-09-09 14:43:41 +05:30
Nabin Hait
eb2ab3bf76
Merge branch 'develop' into develop
2019-09-05 14:59:16 +05:30
pranav nachnekar
d272fd42c9
changed Autoname
2019-09-03 14:16:56 +05:30
Rohan
7fa3f3fe98
fix: include start and end date for contract status ( #18866 )
2019-09-03 14:16:12 +05:30
pranav nachnekar
a3d04cdbca
A
2019-09-03 13:17:35 +05:30
pranav nachnekar
eb4fa966b0
Added validation for timezones
2019-09-03 12:04:23 +05:30
pranav nachnekar
ad6151b690
Added guest permissions
2019-09-03 12:04:13 +05:30
pranav nachnekar
64095084e7
Removed end time in favor of appointment duration
2019-09-03 12:03:14 +05:30
Himanshu
fffdb6f575
feat(Contacts): Multiple Emails in a Contact ( #18675 )
...
* feat: render multiple addresses
* feat: move to newer contacts structure
* fix: iterate over valid variable
* fix: use primary label instead of bold letters
* fix: call popup get contact name from number
* fix: make contact structure call popup compatible
* fix: query
* fix: add city, state and country
* fix: display address
* fix: get address in single line
* fix: review fixes
* fix: translation strings
* fix: fix query for contacts
* fix: remove references of mobile_no
2019-09-02 15:57:45 +05:30
pranav nachnekar
adba6c833d
Merge branch 'develop' of https://github.com/frappe/erpnext into develop
2019-08-28 17:00:27 +05:30
pranav nachnekar
7b9e30914f
Added doctypes and portal pages
2019-08-28 16:57:37 +05:30
Suraj Shetty
6affeaa9c1
fix: check if number exists after striping '0'
...
- Absract number striping logic to separate method
- Rename a confusing variable name
- Remove leftout print statement
2019-08-21 09:14:56 +05:30
Suraj Shetty
80afee04a4
fix: Set address while creating Opportunity from Lead ( #18702 )
...
* fix: Set address while creating Opportunity from Lead
* fix: Setting of address in opportunity from Lead
2019-08-13 10:58:29 +05:30
Faris Ansari
9eda500dbc
Merge branch 'develop' into refactor-call-popup
2019-08-12 15:56:35 +05:30
Suraj Shetty
f81b6c7cfb
fix: Set address while creating Opportunity from Lead ( #18700 )
2019-08-12 13:05:22 +05:30
Suraj Shetty
429bfcfd83
fix: Make requested changes
2019-08-08 19:16:32 +05:30
Suraj Shetty
7d3f1fef1c
fix: Employee selection for call popup
...
- Check if employee with matched number is also
scheduled to receive popup
2019-08-05 21:21:45 +05:30
Suraj Shetty
0957480305
fix: Show popup to employees with same phone number
2019-08-05 11:32:51 +05:30
Anurag Mishra
0505135f90
Merge branch 'develop' into refactor-call-popup
2019-07-24 18:33:14 +05:30
Suraj Shetty
4177ecb6b2
Merge branch 'develop' of github.com:frappe/erpnext into refactor-call-popup
2019-07-22 15:18:03 +05:30
Suraj Shetty
433e587a95
style: Add tabs
2019-07-22 13:21:35 +05:30
Suraj Shetty
002474367b
Merge branch 'develop' into email-campaign
2019-07-22 13:20:06 +05:30
Rucha Mahabal
6224266512
fix: replaced frappe.db.get_value with frappe.db.exists
2019-07-22 13:04:43 +05:30
Rucha Mahabal
d23a95c06e
fix: removed unnecessary fields from Campaign DocType and other fixes in Email Campaign
2019-07-22 12:26:52 +05:30
Faris Ansari
e3b3ac8a59
fix: Fetch email when making Opportunity from Lead ( #18373 )
2019-07-22 11:31:30 +05:30
Rucha Mahabal
324ab98b99
Merge branch 'email-campaign' of https://github.com/ruchamahabal/erpnext into email-campaign
2019-07-22 03:27:29 +05:30
Rucha Mahabal
8d994cb1f2
fix: allow only 1 active Email Campaign for a lead/contact at a time
2019-07-22 03:26:40 +05:30
Rucha Mahabal
b54459e588
dash: added Email Campaign to CRM dashboard
2019-07-22 03:23:40 +05:30
Rucha Mahabal
a566b4e24a
Merge branch 'develop' into email-campaign
2019-07-19 15:07:56 +05:30
Suraj Shetty
82cfccab2f
fix: Get user_id of employee instead of name
...
- Remove caching from lead
2019-07-17 11:52:35 +05:30
Suraj Shetty
e7d277d51e
fix: Last communication query
2019-07-16 13:53:41 +05:30
Suraj Shetty
f5dd494716
fix(call popup): Multiple changes
...
- Remove summary from call log use comments instead
- Add contact and lead if matched to the call log
- Add received by field with Employee Link
- DocPerm to allow Employees to have read access on call log
- Remove unwanted code
- Add a method to get lead just by providing phone number
- Show popup only to Employee to which the system is trying to connect.
- Remove custom code from call popup dialog and replace it with
standard fields
- Increase timeout to hide popup after the call has been disconnected.
2019-07-16 11:07:25 +05:30
Rucha Mahabal
bbb22ad082
fix: child table naming
2019-07-15 17:52:50 +05:30
deepeshgarg007
eac5461229
fix: Address filtering fix in opportunity
2019-07-15 13:55:08 +05:30
Rucha Mahabal
0fe37fda09
codacy fixes
2019-07-12 17:47:32 +05:30
Rucha Mahabal
4879e00d64
codacy fixes
2019-07-12 16:09:32 +05:30
Rucha Mahabal
c35a9a4888
codacy fixes
2019-07-12 15:49:05 +05:30
Rucha Mahabal
7396bb8933
codacy fixes
2019-07-12 14:47:02 +05:30
Rucha Mahabal
2b7064a348
codacy fixes
2019-07-12 14:34:43 +05:30
Rucha Mahabal
9e35bff55c
feat: Email Campaign
2019-07-12 13:56:36 +05:30
Rucha Mahabal
8c747ce5cf
merged
2019-07-09 15:18:45 +05:30
Rucha Mahabal
36963a8e04
feat: Email Campaign
2019-07-09 15:14:13 +05:30
Suraj Shetty
247d50e552
refactor: Remove unwanted debug flag
2019-07-03 10:47:35 +05:30
Nabin Hait
34c551d9a5
fix: Missing commits from hotfix branch ( #17997 )
...
* fix: merge conflict
* fix: restored missing set_gst_state_and_state_number function
* fix: style linting as per codacy
* fix: Fixes related to customer/lead merging
* fix: merge conflict
* fix: Fixes related to customer/lead merging
* fix: Assign isue/opportunity to user
* fix: Assign isue/opportunity to user
* fix: Replaced Invoice type by GST Category
* fix: merge conflict
* fix: merge conflict
* fix: test cases
* fix: test cases
2019-07-03 10:34:31 +05:30
Aditya Hase
8d70073cf8
refactor: Remove implicit auto assignment feature ( #18124 )
...
This behaviour now can be replicated with Assignment Rule configurations.
2019-07-01 19:35:17 +05:30
Suraj Shetty
502565ff56
fix: Make required changes
2019-07-01 14:28:59 +05:30
Rucha Mahabal
162f7d1b50
auto email and new communication linked to email campaign setup
2019-07-01 01:09:58 +05:30
Rucha Mahabal
dcf5fbd35d
added some validations
2019-06-30 16:36:09 +05:30
Rucha Mahabal
fc03509e46
created data structure for email automation
2019-06-30 16:24:29 +05:30
Suraj Shetty
19e4fde737
Merge branch 'develop' of github.com:frappe/erpnext into call-summary-dialog
2019-06-30 15:30:59 +05:30
Faris Ansari
23f9b6156f
fix(Opportunity): Don't assign to Guest ( #17996 )
...
If Opportunity is created from Website, it breaks because
the assign_to user is Guest
2019-06-20 11:34:14 +05:30
Suraj Shetty
9ba9a91631
fix: Strip leading zero from phone number
2019-06-18 10:56:47 +05:30
Suraj Shetty
04d623ab66
fix: Get employee login ids directly from child table
2019-06-17 15:20:28 +05:30
Suraj Shetty
2f84779667
fix: Last Communication for lead
...
- Remove unused code
- Remove unused import
2019-06-12 10:31:07 +05:30
Suraj Shetty
6013375fbb
fix: Improve call popup UX
...
- Close modal after 10 secs if user is has not entered any call summary
- Show alert once the summary was saved
2019-06-11 08:03:55 +05:30
Suraj Shetty
77302b3928
fix: Save summary to right field
2019-06-11 08:01:18 +05:30
Suraj Shetty
13770ccf7a
fix: Codacy
2019-06-10 09:52:53 +05:30
Suraj Shetty
c8c17422f7
fix: Change call log fieldname and some cleanups
2019-06-07 10:22:50 +05:30
Suraj Shetty
97780613ad
fix: Improve call popup UI
2019-06-06 14:48:37 +05:30