Saqib
64c1347d1e
refactor!: remove abbreviation renaming ( #27766 )
...
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-10-07 07:05:34 +00:00
Deepesh Garg
a2b5e678fe
fix: Use get_list instead of get_all to avoid perm issues
...
(cherry picked from commit 9507b2d752a40c0dd9e8b43ae3ef64435457c85e)
2021-10-05 09:49:05 +00:00
GangaManoj
38c7e42f0c
fix: Delete linked Transaction Deletion Record docs on deleting company
2021-10-05 10:14:01 +05:30
mergify[bot]
b9942ad639
feat: Tracking Multi-round interview ( #25482 ) ( #27724 )
...
* feat: Tracking Multi-round interview
* fix: releted to scheduler event and formating
* fix: job applicant UI/UX and conflicts
* test: Interview Round
* fix(test): Employee referral, Employee Onboarding, Job Offer
* fix: sider
* feat: set default value in Hr settings
* feat: added validation for designation
* test: Interview
* test: Added validatiolns for skill
* test: Interview feedback
* fix: sider
* fix: remove unnecessary validations and form label cleanups
* chore: clean-up Interview Round and Interview Type doctype
* fix: remove redundant Rating Value, only keep Rating
* fix: update interview details on feedback submission
- make interview feedback submission dialog minimizable
* fix: show submit feedback button only if feedback doesn't exist
* refactor: Interview and Feedback statuses and workflow
* fix(HR Settings): clean up interview settings
* refactor: Interview
* refactor: Interview Feedback, remove unnecessary validations
* chore: update notification messages
* chore: remove unnecessary formatting changes in attendance list and leave application
* refactor: Job Applicant to Interview mapping
* chore: sorted imports
* chore: sorted imports
* fix: sider issues
* fix: linter issues
* fix: sider issues
* fix: tests
* fix: sorted imports
* fix: tests, sider
* fix: therapy plan test
* fix: sider issues
* feat: Include From Time and To Time fields in Interview for cleaner data
* feat: Interview Calendar
* fix: allow renaming masters
* fix: add more fields to list view and standard filter
* fix: validate overlapping interviews
* fix: update tests
* fix: linter issues
* refactor: replace reminder messages with Email Templates
* fix: sider issues
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
(cherry picked from commit 57e66f958cd57d66a6fd3b19f6cd3593eab63666)
Co-authored-by: Anurag Mishra <32095923+Anurag810@users.noreply.github.com>
2021-10-01 13:15:40 +05:30
Kenneth Sequeira
abded895f3
fix: update default KSA VAT rate for setup ( #27614 )
2021-09-21 10:58:18 +05:30
Saqib
5eba1ccd51
fix: no validation on item defaults ( #27393 )
...
* fix: no validation on item defaults
* fix: cache value while validating
* test: item default company relation
* fix: reorder validations
* refactor: add guard conditions on update_defaults
* test: add default warehouse for item group
* fix: validate item defaults for item groups
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-09-16 17:31:37 +05:30
Faris Ansari
1c1b476d67
perf: Optimize get_attribute_filters ( #26729 )
...
* perf: Optimize get_attribute_filters
* fix: handle when filter attributes are undefined
* chore: unused imports
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-09-14 11:41:19 +05:30
Shariq Ansari
e68c55ce83
fix: Removing first Spacer from home page ( #27321 )
2021-09-03 11:00:33 +05:30
Chillar Anand
915b34391c
chore: Clean up imports ( #27302 )
...
* chore: Added isort to pre-commit config
* chore: Sort imports with isort
* chore: Clean up imports with pycln
* chore: Sort imports with isort
* chore: Fix import issues
* chore: Clean up sider issues
* chore: Remove import errors from flake8 ignore list
* chore: Clean up lint issues
2021-09-02 16:44:59 +05:30
Ankush Menat
b147b85e6a
chore: whitespace / eof fixes
2021-09-01 16:57:21 +05:30
Ankush Menat
e46567192a
fix: invalid escape sequences in regex
2021-09-01 16:57:17 +05:30
Ankush Menat
694ae81618
fix: remove bare excepts
2021-09-01 15:02:28 +05:30
Jannat Patel
48f2e5ac1d
fix: email digest original_user issue ( #27191 )
2021-08-31 17:43:30 +05:30
Dany Robert
94dcbf851a
fix: update get_exchange_rate for test mode ( #26847 )
...
* fix: no api calls on test mode
* fix: make api call, but return 1.0 incase of invalid currency
* feat: patch request.get
* fix: clear cache after test
* fix: add missing test_exchange_value
* fix: avoid api call in implicit function call during test
* fix: returning 1 while in test causes failure
Returning 1.00 causes failure of exchange rate tests.
* chore: retab
* chore: style
2021-08-31 17:19:12 +05:30
Kamal Johnson
a285b5b78b
feat: Accounts, Selling & Assets Onboarding cleanup ( #27112 )
...
* refactor: company form fields arrangement
* refactor: accounts onboarding steps
* refactor: re-arrange fields & modify labels in company form
* feat: onbording steps for accounts module
* fix: updated onboarding steps for selling module
* fix: remove unwanted steps from accounts
* feat: add more onboarding steps
* feat: Refactor onboarding-module for accounting workspace
* feat: Add basic asset onboarding steps
* feat: Add basic asset item form tour
* feat: Add basic selling onboarding-steps
* feat: Add basic form tour for purchase recipt
* feat: Add basic form tour for existing asset
* feat: Adding asset category form tour
* feat: Add form tour for asset category
* feat: Refactor sales taxes and charges template form tour with new method
* refactor: Remove old form tour for accounts settings
* refactor: Change asset category form tour with new tour method
* refactor: Change asset item form tour with new tour method
* refactor: Change purchase receipt form tour with new tour method
* refactor: Change asset form tour with new tour method
* refactor: Remove old form tour for selling settings
* refactor: general fix/typo in onboarding steps
* Apply suggestions from code review
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
* refactor: Remove old form tour method for sales order.
* fix: removed duplicate section break
* fix: Removed duplicate fields
Co-authored-by: Saqib Ansari <nextchamp.saqib@gmail.com>
Co-authored-by: Anuja <anuja.pawar20@gmail.com>
Co-authored-by: Afshan <33727827+AfshanKhan@users.noreply.github.com>
Co-authored-by: Nabin Hait <nabinhait@gmail.com>
2021-08-27 15:47:11 +05:30
Ankush Menat
ae55eab599
chore: remove deprecated and empty QUnit tests ( #27179 )
...
* chore: remove deprecated and empty QUnit tests
* ci: fix UI test config
Testing library was added on Frappe, in order to reuse command testing
library has to be installed during setup process.
2021-08-26 20:43:06 +05:30
Saqib
60675379c2
fix: partial rename while replacing abbreviation ( #27065 )
2021-08-25 18:26:00 +05:30
Saqib
ce129a1414
feat: re-arrange company doctype fields ( #27091 )
2021-08-24 17:23:14 +05:30
Deepesh Garg
2b2572b9b9
fix: Cascade deletion for Company ( #26923 )
...
* fix: Cascade deletion for Company
2021-08-20 14:40:12 +05:30
Ankush Menat
4551d7d602
chore: mass trailing whitespace and EOF fixes
2021-08-19 13:43:28 +05:30
Rohit Waghchaure
eb1e3181a4
fix: conflicts while merging brnach version-13 to develop
2021-08-17 10:53:19 +05:30
Shariq Ansari
b32c2fa561
fix: updated erpnext wspace json files ( #26380 )
...
* fix: updated erpnext wspace json files
* fix: updated wspace json files
* fix: updated wspace json files
* fix: removed padding code from wspace json files
* fix: Updated restrict_to_domain in wspace json
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-13 12:19:16 +05:30
Rohit Waghchaure
7167fd00bc
Merge branch 'version-13-hotfix' into merged-v13-hotfix-into-pre-release
2021-08-10 23:30:16 +05:30
Frappe PR Bot
1a39d1a311
fix: cost center & account validation in Sales/Purchase Taxes and Charges ( #26881 )
2021-08-10 19:38:39 +05:30
Anuja Pawar
0e337be065
fix: cost center & account validation in Sales/Purchase Taxes and Charges ( #25929 )
2021-08-10 17:26:35 +05:30
Rohit Waghchaure
f571e42aa4
Merge branch 'version-13-hotfix' into merge-version-13-hotfix-into-v13-pre-9
2021-08-10 01:06:23 +05:30
GangaManoj
fcbd79b7d3
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into backport-asset-repair-refactor
2021-08-06 18:12:24 +05:30
Frappe PR Bot
b13e46071a
fix: Let all System Managers be able to delete Company transactions ( #26815 ) ( #26819 )
...
(cherry picked from commit 884d8cf065
)
Co-authored-by: Ganga Manoj <ganga.manoj98@gmail.com>
2021-08-06 10:39:58 +05:30
Ganga Manoj
884d8cf065
fix: Let all System Managers be able to delete Company transactions ( #26815 )
2021-08-05 11:14:46 +05:30
Rohit Waghchaure
343143037c
fix: conflicts
2021-08-01 14:45:24 +05:30
Dany Robert
2833a02e0e
Merge branch 'develop' into patch-5
2021-07-29 16:47:28 +05:30
Dany Robert
909995a441
fix: issue with cache.setex
2021-07-29 15:58:27 +05:30
Anupam
e5fea372af
fix: frappe linter
2021-07-29 11:05:38 +05:30
Anupam
b1350af1f6
fix: setup wizard
2021-07-28 23:54:46 +05:30
Anupam Kumar
89f2138fbc
Merge branch 'version-13-hotfix' into email-digest
2021-07-28 18:24:29 +05:30
Rohit Waghchaure
60a0b7fe77
Merge branch 'version-13-hotfix' into 'version-13-pre-release-13-8'
2021-07-26 11:34:57 +05:30
Ganga Manoj
41705acbd9
fix: delete child docs when parent doc is deleted ( #26518 )
...
* fix: Make code more readable
* fix: Delete child table info when parent doc is deleted
* fix: Sider issues
* fix: Remove trailing whitespace
2021-07-20 20:48:57 +05:30
Deepesh Garg
2686d04800
fix: Typo and remove duplicate function
2021-07-18 17:54:35 +05:30
Nabin Hait
11475487fb
fix: merge conflict
2021-07-16 15:58:50 +05:30
18alantom
b24c0bfbf9
fix: show child item group items on portal
2021-07-14 17:41:32 +05:30
18alantom
7558e7f115
fix: show child item group items on portal
2021-07-14 17:40:04 +05:30
Marica
3f599b049c
Merge branch 'develop' into fix-item-group-portal-issues
2021-07-14 17:15:18 +05:30
Saqib
be773f4052
Merge branch 'develop' into bootstrapped_gst_setup_develop
2021-07-14 13:55:00 +05:30
Ganga Manoj
05d7c69aa2
fix: delete child docs when parent doc is deleted ( #26239 )
2021-07-14 11:54:27 +05:30
Deepesh Garg
75f66f78d7
Merge pull request #26420 from deepeshgarg007/new_company_error
...
fix: Errors on parallel requests creation of company for India
2021-07-13 20:29:56 +05:30
Deepesh Garg
2de11fbbc4
fix: Test Cases
2021-07-13 16:50:35 +05:30
Deepesh Garg
779d2afa60
fix: Update account heads in GST test cases
2021-07-13 16:50:04 +05:30
Deepesh Garg
2908f2ee20
fix: Revert Changes
2021-07-13 16:49:21 +05:30
Deepesh Garg
0dfea4d134
fix: Test Cases
2021-07-13 16:49:21 +05:30
Deepesh Garg
22683cf19b
fix: Tests
2021-07-13 16:49:21 +05:30