Ankush Menat
0d7f54c6c2
refactor: simplify UOM conversion logic
...
- Remove unnecessary sql query
- Remove convoluted matching logic and be explcitiy while querying.
- better variable names for understanding matching cases
2021-05-24 17:55:37 +05:30
Ankush Menat
297dc5e345
perf: add basic optimisation for uom conversion
2021-05-24 17:55:37 +05:30
Ankush Menat
958d485ba4
refactor: msgprint(raise_exception)->frappe.throw
2021-05-24 17:55:36 +05:30
Ankush Menat
ccbde0efa0
refactor: use enumerate instead of trackign index
...
also removed dead code
2021-05-24 17:55:36 +05:30
Ankush Menat
44c489223b
chore: remove py2 compat code
2021-05-24 17:55:18 +05:30
Jannat Patel
dc7afa743c
fix: profitability test ( #25812 )
...
* fix: profitability test
* fix: replaced class method
* fix: removed print statement
2021-05-24 17:33:48 +05:30
noahjacob
bf1b3b89d1
refactor: updated conditional visibility of check box
2021-05-24 17:03:15 +05:30
rohitwaghchaure
6809ff4f64
Merge pull request #25776 from rohitwaghchaure/fixed-warehouse-not-found-issue
...
fix: warehouse not found in stock entry
2021-05-24 17:00:06 +05:30
marination
c12264f6bc
chore: Cleanup Customer and Supplier Details section in Stock Entry
...
- Changed depends on value to "Send to Subcontractor" for supplier fields
- Removed Customer fields as they are not relevant to any Stock Entry purpose
- Renamed section to "Supplier Details" visibe on subcontracting transfer
2021-05-24 13:20:22 +05:30
rohitwaghchaure
ce88c945cd
Update stock_entry.js
2021-05-24 11:53:27 +05:30
krishnagirishp
5457db0601
chore: remove uses of six.PY2 in codebase ( #25062 )
...
* remove uses of six.py2 in codebase
* changes based on pr feedback
* Update amazon_mws_api.py
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-05-23 21:13:44 +05:30
Ankush Menat
7b4a38c71e
chore: remove print from account controller ( #25807 )
...
This is polluting test output and it's not useful for debugging without
context.
2021-05-23 18:49:26 +05:30
Ankush Menat
a2d6cf3125
chore: remove pytlint config ( #25796 )
...
- We have flake8 config and it runs in Sider. Flake8 and pylint have
huge overlap, no point in using both tools.
- The config is not valid pylint config. So it's useless anyway.
2021-05-23 18:38:14 +05:30
Ankush Menat
c229ac9322
refactor: add guard clause for readability
...
Both functions only execute based on a condition. In such cases
condition should immediately exit the function, this is called "guard
clause" and helps in readability (less indent, and easy to "exit" when
reading the code.
2021-05-23 16:31:29 +05:30
Ankush Menat
4b484d741d
refactor: use is_new() instead of __islocal
...
Interface over implementation.
2021-05-23 16:31:29 +05:30
Ankush Menat
931c886f92
fix: not checking all fields
...
`break` will break out of the loop without checking remaining fields.
2021-05-23 16:31:29 +05:30
Ankush Menat
83e6e2e68a
refactor: add guard clause for readability
2021-05-23 16:31:29 +05:30
Ankush Menat
0b4858d8e5
refactor: eliminate unnecessary loop, container casts
2021-05-23 16:31:29 +05:30
Ankush Menat
ad58a8164a
refactor: code cleanup
...
minor fixes for improving code quality
2021-05-23 16:31:29 +05:30
Ankush Menat
4a2dbd4885
refactor: cleanup get_timeline_data, remove py2
2021-05-23 16:31:28 +05:30
Ankush Menat
330353a5ce
refactor: use frappe.throw instread of recreating
...
_msgprint was basically duplicating behvaiour of frappe.throw
2021-05-23 16:31:16 +05:30
Ankush Menat
e1ab290911
chore: remove woocommerce package ( #25736 )
...
This is not used anywhere. It was added in this commit
df83148d7c
2021-05-23 11:25:35 +05:30
Marica
eaf0465c44
Merge pull request #25797 from marination/item-variants-report
...
fix: Item Variant Details Report
2021-05-22 19:05:54 +05:30
marination
b0019bcf5b
fix: Item Variant Details Report
...
Co-authored-by: gavindsouza <gavin18d@gmail.com>
- Handling of variants with special characters
- Set data in appropriately named columns
- Code cleanup
2021-05-21 21:42:11 +05:30
rohitwaghchaure
ab34f5b485
Merge pull request #25742 from ankush/disable_submit_btn
...
fix: duplicate stock entry on multiple click
2021-05-21 18:13:01 +05:30
rohitwaghchaure
579a1b7028
Merge pull request #25779 from ankush/parallel_stock_transactions
...
fix: wrong quantity after transaction for parallel stock transactions
2021-05-21 18:11:34 +05:30
Saqib
0b5e340b6e
fix(pos): return case for item with available qty equal to one ( #25760 )
2021-05-21 16:32:56 +05:30
Saqib
e930456be2
fix(e-invoicing): 'NoneType' object is not iterable ( #25781 )
2021-05-21 16:31:12 +05:30
Alan
1097dc89c5
fix: show allow zero valuation only when auto checked ( #25778 )
2021-05-21 14:04:03 +05:30
Ankush Menat
4dcac4ae81
refactor(minor): Use identity instead of equality
...
Ignore false positive.
2021-05-21 13:49:58 +05:30
Ankush Menat
9979cf5fcc
fix: wrong quantity after transaction for parallel stock transactions
...
When two transactions are inserted parallelly then previous SLE could be
incorrect for some of them. Locking SLE table would prevent reading from
it till transaction is complete.
2021-05-21 12:31:06 +05:30
rohitwaghchaure
651e934415
Merge pull request #25683 from noahjacob/supplier_item_group_link
...
feat: linking supplier with an item group for filtering items
2021-05-21 12:07:53 +05:30
Rohit Waghchaure
795909fdcd
fix: warehouse not found in stock entry
2021-05-21 11:31:01 +05:30
Anuja P
605ea044f3
fix: update process SOA format
2021-05-21 11:24:33 +05:30
rohitwaghchaure
84730aa4a5
Merge pull request #25754 from rohitwaghchaure/fixed-do-not-repost-if-scheduler-is-in-running-13
...
fix: the status of repost item valuation showing In Progress since long time
2021-05-21 09:50:18 +05:30
Rucha Mahabal
722cfdb7e5
Merge pull request #25701 from anupamvs/timesheet-refactor
...
refactor: timesheet
2021-05-20 23:43:19 +05:30
Rucha Mahabal
a7d0dbb085
fix: calculate total billing amount on fetching timesheets
...
- show timesheet billing amounts in doc currency
2021-05-20 23:02:11 +05:30
Rucha Mahabal
8a407f1ec3
fix: sider issues
2021-05-20 22:23:44 +05:30
Rucha Mahabal
be247ec3de
fix: error message placeholders and sider issues
2021-05-20 22:17:20 +05:30
Rucha Mahabal
0d8b9a9d0a
fix(patch): billable field not renamed
2021-05-20 19:53:30 +05:30
noahjacob
f0e6a16910
test: updated test for generated schedule dates
2021-05-20 19:29:12 +05:30
Deepesh Garg
181c5d240b
Merge pull request #25767 from deepeshgarg007/gst-ptach-fix-1
...
fix: Do not throw error on migrate
2021-05-20 18:40:48 +05:30
Mohammad Hasnain Mohsin Rajan
21e662f678
fix: apply permission while selecting projects ( #25765 )
2021-05-20 17:20:05 +05:30
Deepesh Garg
4427390ab3
fix: Do not throw error in migrate
2021-05-20 17:19:24 +05:30
noahjacob
0169cd845a
fix: sider
2021-05-20 15:40:07 +05:30
Anupam
1270febfff
fix: sider issues
2021-05-20 14:15:58 +05:30
Anupam
aa516e5d17
fix: review changes
2021-05-20 14:12:18 +05:30
Anupam
aeb88385bb
patch: timesheet changes
2021-05-20 14:11:36 +05:30
noahjacob
08598238d7
refactor: suggested changes
2021-05-20 13:23:10 +05:30
Deepesh Garg
8bc90ffcf5
Merge pull request #25755 from nextchamp-saqib/improve-missing-cost-center-msg
...
fix: missing cost center message on creating gl entries
2021-05-20 11:20:43 +05:30
