Deepesh Garg
96035b87d5
fix: Lower deduction certificate for multi-company ( #36491 )
2023-08-05 22:21:06 +05:30
Corentin Flr
559d914c0b
fix(accounts): Translate columns in AP/AR report ( #36503 )
2023-08-05 22:18:36 +05:30
s-aga-r
758b31d895
fix: get incoming rate instead of BOM rate ( #36496 )
...
* fix: get incoming rate instead of BOM rate
* test: add test case for SCR rm rate
2023-08-05 19:28:38 +05:30
s-aga-r
e179499764
fix(ux): add Ordered Qty
column in Get Items From > MR ( #36486 )
2023-08-05 19:26:11 +05:30
Michelle Alva
16bc1e228f
chore: typo in onboarding ( #36504 )
...
* fix: typo in onboarding
* fix: typo
2023-08-05 18:30:24 +05:30
ruthra kumar
a4be6b0f10
Merge pull request #36501 from ruthra-kumar/fix_failing_gain_loss_unit_tests
...
fix(test): replace hardcoded reference to adv with dynamic one
2023-08-05 14:43:42 +05:30
ruthra kumar
466734fb4b
fix(test): replace hardcoded reference to adv with dynamic one
2023-08-05 14:11:57 +05:30
Ritvik Sardana
b483364649
Merge branch 'develop' of https://github.com/frappe/erpnext into develop-ritvik-POS-runtime-effect
2023-08-05 11:26:47 +05:30
Ritvik Sardana
dbc000d655
fix: batched items method giving wrong quantity, so changed it back to previous way
2023-08-05 11:23:07 +05:30
mergify[bot]
b65ee6c2db
fix: cross connect delivery note and sales invoice (backport #36183 ) ( #36457 )
...
fix: cross connect delivery note and sales invoice (#36183 )
* fix: cross connect delivery note and sales invoice
* chore: remove unnecessary non_standard_fieldname
(cherry picked from commit 8501a1182ae8323d91438da30ddc8d93cf8c2789)
Co-authored-by: Anand Baburajan <anandbaburajan@gmail.com>
2023-08-05 10:57:23 +05:30
RitvikSardana
b86afb2964
feat: Financial Ratio Report ( #36130 )
...
* feat: Financial Ratio report added
* fix: Made columns dynamic
* fix: Changed fieldtype of year column
* fix: Added Financial Ratios for all Fiscal Years
* fix: Added Validation of only Parent Having account_type of Direct Income, Indirect Income, Current Asset and Current Liability
* fix: Added 4 more ratios
* fix: added a function for repeated code
* fix: added account_type in accounts utils and cleaned report code
* fix: created function for avg_ratio_values
* fix: cleaning code
* fix: basic ratios completed
* fix: cleaned the code
* chore: code cleanup
* chore: remove comments
* chore: code cleanup
* chore: cleanup account query
* chore: Remove unused variables
---------
Co-authored-by: Ritvik Sardana <ritviksardana@Ritviks-MacBook-Air.local>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2023-08-04 22:05:30 +05:30
Gursheen Kaur Anand
edbefee10c
fix: payment allocation in invoice payment schedule ( #36440 )
...
* fix: payment allocation in invoice payment schedule
* test: payment allocation for payment terms
* chore: linting issues
2023-08-04 17:49:17 +05:30
Sumit Jain
49be740736
fix: Contact Doctype doesn't have any field called job_title
...
fix: Contact Doctype doesn't have any field called `job_title`
2023-08-04 17:45:16 +05:30
Deepesh Garg
17585f08ba
Merge pull request #36333 from GursheenK/AP-GL-not-matching
...
fix: AP report does not show expense claim payables
2023-08-04 17:42:54 +05:30
Ritvik Sardana
510543680b
fix: batched items in POS
2023-08-04 16:55:30 +05:30
Ritvik Sardana
c9d5a62350
fix: POS Runtime Effect completed
2023-08-04 16:47:49 +05:30
Deepesh Garg
7276d593c3
Merge pull request #36458 from GursheenK/consolidated-financial-statements-roottype
...
test: balance sheet report
2023-08-04 09:55:36 +05:30
Deepesh Garg
04820b14da
Merge pull request #35644 from ruthra-kumar/book_gain_loss_in_je
...
refactor: booking exchange gain/loss amount through journal
2023-08-04 09:53:26 +05:30
Deepesh Garg
10529e1f5a
Merge pull request #36412 from pancho-s/Custom_Abbr_On_Setup
...
feat: Reallow customizing company abbreviation on setup.
2023-08-03 21:34:57 +05:30
Anand Baburajan
38a612c62e
chore: better cost center validation for assets ( #36477 )
2023-08-03 16:37:05 +05:30
Ritvik Sardana
5b1aa07ecb
fix: fixed SABB error
2023-08-03 16:10:28 +05:30
Husam Hammad
27ebf14f9d
fix: handle None value in payment_term_outstanding
...
* Fix payment entry bug: Handle None value in payment_term_outstanding
* fix: Handle None value in payment_term_outstanding V2
fix linting issue
2023-08-02 16:28:05 +05:30
Devin Slauenwhite
dedf24b86d
fix: don't allow negative rates ( #36027 )
...
* fix: don't allow negative rate
* test: don't allow negative rate
* fix: only check for -rate on items child table
2023-08-02 16:26:55 +05:30
Deepesh Garg
b715453ae3
Merge pull request #36450 from cogk/fix-typo-in-query-for-financial-statement-report
...
fix: Fix query for financial statement report
2023-08-01 23:36:25 +05:30
Gursheen Anand
002bf77314
test: balance sheet report
2023-08-01 23:24:18 +05:30
Gursheen Anand
cd98be6088
fix: check root type only when not none
2023-08-01 23:22:49 +05:30
Anand Baburajan
a8df875820
chore: use datatable for asset depr sch table view ( #36449 )
...
* chore: use datatable for asset depr sch table view
* chore: remove unnecessary code
2023-08-01 21:14:27 +05:30
Ritvik Sardana
17771a55fb
fix: added code for batched items in POS
2023-08-01 19:28:40 +05:30
Corentin Flr
bd3fc7c434
fix: Fix query for financial statement report
2023-08-01 14:35:11 +02:00
ruthra kumar
ab933df5bb
fix: overallocation validation misfire on normal invoices ( #36349 )
...
* fix: overallocation validation misfire on normal invoices
* test: assert misfire doesn't happen
2023-08-01 13:12:16 +05:30
Anand Baburajan
2ab3d75274
feat: asset activity ( #36391 )
...
* feat: asset activity
* chore: add more actions to asset activity
* chore: fix failing test due to timestamp mismatch error
* chore: rewriting asset activity messages
* chore: add report and add it to workspace
* chore: show user in list view
2023-08-01 12:00:24 +05:30
mergify[bot]
3f09f811bf
fix: allow fully depreciated existing assets (copy #36378 ) ( #36379 )
...
* fix: allow fully depreciated existing assets
(cherry picked from commit 9489cba275525a93d92c00f62569888a219a8912)
# Conflicts:
# erpnext/assets/doctype/asset/asset.json
# erpnext/assets/doctype/asset/depreciation.py
* chore: fix conflicts in asset.json
* chore: fix conflicts in depreciation.py
---------
Co-authored-by: anandbaburajan <anandbaburajan@gmail.com>
2023-08-01 11:20:04 +05:30
Deepesh Garg
333f2a565b
fix: Add journal entry in demo
2023-08-01 10:10:50 +05:30
ruthra kumar
a93ae9c826
Merge pull request #36434 from ruthra-kumar/replace_get_cached_with_get_single_value
...
fix: incorrect usage `get_cached_value` on single doctypes
2023-08-01 10:02:33 +05:30
abdosaeed95
4f473eb090
fix: typo in loyalty program throw message ( #36432 )
2023-08-01 10:01:01 +05:30
ruthra kumar
ba15810639
fix: incorrect usage get_cached_value
on single doctypes
2023-08-01 07:58:09 +05:30
Bernd Oliver Sünderhauf
f333d2724a
Merge branch 'frappe:develop' into Custom_Abbr_On_Setup
2023-08-01 01:18:10 +02:00
Bernd Oliver Sünderhauf
bc8d05da0f
feat: Reallow customizing company abbreviation on setup.
2023-07-31 23:46:47 +02:00
Gursheen Kaur Anand
11bd15e580
fix: root type in account map for balance sheet ( #36303 )
...
* fix: root type in account map
* fix: fetch gle by root type in consolidated financial statement
* refactor: consolidated financial statement gle query
* fix: filter accounts by root type
2023-07-31 23:27:16 +05:30
Ankush Menat
f31d07554d
perf: avoid full table scan in sle count check ( #36428 )
2023-07-31 22:13:47 +05:30
rohitwaghchaure
f83a100a8d
fix: not able to make material request ( #36416 )
2023-07-31 19:13:23 +05:30
Devin Slauenwhite
e8eeeb16e2
fix: group item reorder by (warehouse, material_request_type) ( #35818 )
...
* fix: group item reorder by (warehouse, material_request_type)
* fix: update reorder error message
* chore: linter
* fix: correct error message
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
* chore: linter
---------
Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
2023-07-31 12:47:14 +00:00
xdlumertz
652398fad2
fix: Defined "Open" Status as default ( #36421 )
...
Defined "Open" Status as default of the child doctype (Quality Review Objective), because without it the main doctype (Quality Review) has "Passed" status.
This happens because in the "set_status" function, the status is updated according to the status of the child records.
2023-07-31 12:34:33 +00:00
Vimal
ce36d1f668
fix: job card suggest holiday as start date ( #35958 )
2023-07-31 17:51:31 +05:30
xdlumertz
05b07e098a
fix: process_owner is not link User ( #36420 )
...
-Changed "fetch from" since field is not a binding field
-Change field "full_name" from Hidden to Read Only
2023-07-31 17:34:55 +05:30
Gursheen Kaur Anand
1ddfaa7605
fix: ignore cancelled gle in voucher-wise balance report ( #36417 )
...
fix: ignore cancelled gle
2023-07-31 14:29:20 +05:30
Deepesh Garg
70c5df056d
Merge branch 'develop' of https://github.com/frappe/erpnext into demo_data_on_install
2023-07-31 13:02:34 +05:30
Deepesh Garg
7805abbb2d
fix: reset default company
2023-07-30 20:29:20 +05:30
Deepesh Garg
c6d8f15b10
Merge pull request #36389 from AlexandreLumertz/patch-2
...
fix: Party type translation in error message
2023-07-30 18:42:01 +05:30
Deepesh Garg
c6b024c34b
Merge pull request #36167 from barredterra/percentage-rounding
...
fix: rounding of percentage fields
2023-07-30 14:41:30 +05:30