Ernesto Ruiz
c1e608d9ef
fix: add translate function to period in stock_analytics.py
2022-10-25 22:09:02 -06:00
Ernesto Ruiz
71a0ae2e59
fix: refactor code for better translatable string in stock_ageing.py
2022-10-25 22:05:25 -06:00
Sagar Sharma
26c00f8dd3
Merge branch 'develop' into refactor/stock/remaining-reports
2022-10-21 15:19:23 +05:30
Sagar Sharma
40bd121593
refactor: rewrite Itemwise Recommended Reorder Level Report
queries in QB
2022-10-21 14:49:12 +05:30
Sagar Sharma
cde785f1bb
refactor: rewrite Product Bundle Balance Report
queries in QB
2022-10-21 14:49:09 +05:30
Sagar Sharma
feaa2dbba8
refactor: rewrite Stock Ledger Report
queries in QB
2022-10-21 13:12:34 +05:30
Sagar Sharma
582e1bf10c
Merge branch 'develop' into refactor/stock/reports
2022-10-17 16:30:43 +05:30
Rohit Waghchaure
2481574a28
chore: seperate function to apply filter for warehouse in case of QB
2022-10-17 14:25:23 +05:30
Rohit Waghchaure
6381e75fa5
fix: group warehouse filter not working for Batchwise Balance history report
2022-10-17 12:17:05 +05:30
Sagar Sharma
f0f2413932
Merge branch 'develop' into refactor/stock/reports
2022-10-07 09:59:56 +05:30
Sagar Sharma
8103856a41
refactor: rewrite Warehouse wise Item Balance Age and Value Report
queries in QB
2022-10-07 09:59:35 +05:30
Sagar Sharma
7c759b193c
refactor: rewrite Total Stock Summary Report
queries in QB
2022-10-07 09:59:28 +05:30
Sagar Sharma
d3c073dc25
refactor: rewrite Supplier-Wise Sales Analytics Report
queries in QB
2022-10-06 17:42:31 +05:30
Sagar Sharma
c18f13a45b
refactor: rewrite Stock Projected Qty Report
queries in QB
2022-10-06 17:04:50 +05:30
Sagar Sharma
e312d17eae
refactor: rewrite Item Prices Report
queries in QB
2022-09-26 17:50:17 +05:30
hendrik
f41d1500b0
fix: report chart field type
...
* fix: report chart field type
Co-authored-by: Sagar Sharma <sagarsharma.s312@gmail.com>
Co-authored-by: Deepesh Garg <deepeshgarg6@gmail.com>
2022-09-26 17:47:24 +05:30
Sagar Sharma
afb323b01c
Merge branch 'develop' into refactor/stock/report/incorrect-stock-value
2022-09-26 17:09:22 +05:30
Sagar Sharma
b93331e844
refactor: rewrite Incorrect Stock Value Report
queries in QB
2022-09-26 09:44:29 +05:30
Sagar Sharma
22299d2382
refactor: rewrite Item Price Stock Report
queries in QB
2022-09-26 09:40:49 +05:30
Sagar Sharma
bb59346651
refactor: rewrite Delayed Item Report
queries in QB
2022-09-23 15:47:26 +05:30
Sagar Sharma
1c1f991d2f
refactor: rewrite Batch-Wise Balance History Report
queries in QB
2022-09-23 14:57:44 +05:30
Sagar Sharma
2c9d9577e3
refactor: rewrite Batch Item Expiry Status Report
queries in QB
2022-09-23 14:06:37 +05:30
Sagar Sharma
3dc754cac2
test: add test cases for Item Shortage Report
2022-09-20 10:48:05 +05:30
Sagar Sharma
f0a78aa559
refactor: rewrite Item Shortage Report
queries in QB
2022-09-20 10:47:55 +05:30
Rohit Waghchaure
5da7e01db2
fix: dont show zero qty available items in stock ageing report
2022-07-22 17:54:46 +05:30
Rohit Waghchaure
289e6cd4ce
fix: change frappe.db.sql to frappe.qb
2022-07-20 16:02:13 +05:30
Rohit Waghchaure
e576f7f07e
test: test cases for inventory dimension
2022-07-20 16:02:13 +05:30
Rohit Waghchaure
dbec5cff00
feat: Inventory Dimension
2022-07-20 16:02:13 +05:30
Conor
74a782d81d
refactor: DB independent quoting and truthy/falsy values ( #31358 )
...
* refactor: DB independent quoting and truthy/falsy values
* style: reformat to black spec
* fix: ifnull -> coalesce
* fix: coalesce -> Coalesce
* fix: revert pypika comparison
* refactor: convert queries to QB
* fix: incorrect value types for query
`=` query makes no sense with list of values
* fix: remove warehouse docstatus condition
* fix: keep using base rate as rate
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-06-17 17:01:27 +05:30
Marica
5b8c7438cc
Merge pull request #30945 from ankush/stock_analytics_fix
...
fix: stock analytics report shows incorrect data there's no stock movement in a period
2022-05-12 12:26:54 +05:30
Ankush Menat
f6d6463a33
chore: fifo queue vs qty after transaction comparison report
2022-05-11 14:43:03 +05:30
Ankush Menat
198b91f8d4
fix: only carry-forward balances till today's period
...
Showing data in future doesn't make sense. Only carry-forward till last
bucket that contains today's day.
2022-05-10 15:38:02 +05:30
Ankush Menat
287b255ad6
fix: batch_no doesn't maintain qty_after_transaction
2022-05-10 15:38:02 +05:30
Ankush Menat
6ab0046e9c
fix: consider previous balance is missing
...
Also remove `total`, total of total is a meaningless value.
2022-05-10 15:38:02 +05:30
Ankush Menat
d81422fb58
test: basic test for stock analytics report
2022-05-10 15:38:02 +05:30
Ankush Menat
ae842d8145
chore: remove datettime formatting from debug report
...
This hides some information that would otherwise help during debugging
2022-05-09 11:29:00 +05:30
Ankush Menat
9af2d68945
refactor: convert queries to ORM/QB, add types
2022-04-14 18:05:38 +05:30
Ankush Menat
ba29323e11
test: increase assertions to cover all cases
2022-04-14 18:05:38 +05:30
Ankush Menat
e278ee359a
test: item attribute columns
2022-04-14 18:05:38 +05:30
Ankush Menat
febc74a21b
refactor: rewrite stock balance query to QB
2022-04-14 18:05:35 +05:30
Ankush Menat
8a499e95d3
test: uom conversion in stock balance report
2022-04-14 18:01:43 +05:30
Ankush Menat
af0ea7b532
test: assert balanaces against SLE
2022-04-14 18:01:42 +05:30
Ankush Menat
f4766ae4eb
test: opening balance in stock balance report
2022-04-14 18:01:42 +05:30
Ankush Menat
8b2432dfa0
test: stock balance report tests
2022-04-14 18:01:42 +05:30
Ankush Menat
64ac22af82
refactor: add filter type info
2022-04-14 18:01:42 +05:30
Ankush Menat
a896895a9e
fix: bulk fix (~330) missing translations
2022-04-04 13:59:51 +05:30
Ankush Menat
494bd9ef78
style: format code with black
2022-03-28 18:52:46 +05:30
Ankush Menat
5a9bf9ffd6
fix: respect db multi_tenancy while fetching precision ( #30301 )
...
[skip ci]
2022-03-18 17:29:09 +05:30
Noah Jacob
60c4593f7b
chore: removed unrequired batch_no parameter while fetching stock_balance
2022-03-14 15:36:56 +05:30
Noah Jacob
00797fa02d
test: checking balance serial nos in stock ledger report
2022-03-14 15:36:56 +05:30
Noah Jacob
e8ba1f4e74
fix: incorrect balance serial no in stock ledger report
2022-03-14 15:36:56 +05:30
Chillar Anand
fe4b6771b5
refactor: Remove dead code ( #30140 )
2022-03-09 17:16:05 +05:30
Marica
7579981fb5
Merge pull request #29987 from marination/mr-to-order-and-receive-report
...
fix: Get MRs that are yet to be received but fully ordered in Report `Requested Items to Order and Receive`
2022-03-07 10:18:28 +05:30
Ankush Menat
55a966ec41
chore: get stock reco qty from SR instead of SLE ( #30059 )
...
[skip ci]
2022-03-02 14:49:45 +05:30
marination
e6952cb7f9
refactor: Convert to QB, added test file, removed white space
...
- Converted mysql raw query to qb
- Test file for Report Requested Items to Order and Receive
- Removed white space and edited copyright year
2022-03-01 17:15:04 +05:30
Ankush Menat
b0d1e6db54
test(refactor): use FrappeTestCase
2022-02-28 17:23:32 +05:30
Ankush Menat
5d403449bd
test: move report tests to subttest ( #29945 )
...
Basically failfast=False but for sub-tests
2022-02-22 19:24:49 +05:30
Ankush Menat
b1555fd477
chore: batch flag and consumption rate in invariant report
2022-02-21 18:02:40 +05:30
marination
d5be536740
test: Negative Stock, over consumption & over production with split rows, balance precision
2022-02-18 18:53:05 +05:30
marination
ed4a6c6cc6
fix: Range Qty precision
2022-02-18 18:52:42 +05:30
marination
d3fbbcfed3
fix: Precision of available qty and negative stock in transfer bucket
...
- Maintain only positive values in transfer bucket
- Use it to neutralize/add stock to fifo queue
2022-02-18 16:33:28 +05:30
marination
f6233e77c6
chore: Add transfer bucket working to .md file
2022-02-15 20:30:16 +05:30
marination
ea3b7de867
test: Stock Ageing FIFO buckets for Repack entry with same item
2022-02-15 18:41:42 +05:30
marination
799671c748
fix: Transfer Bucket logic for Repack Entry with split batch rows
2022-02-15 18:41:08 +05:30
marination
f221a0d253
test: Cover back to back recos from different warehouses
2022-02-14 20:14:14 +05:30
marination
f62b3207ff
fix: Generate Wh wise FIFO Queue and later aggregate if required
...
- Back to back stock recos cause incorrect qty calculation across warehouses
- Hard to differentiate how much of the qty is reset by the reco
- Maintain Queue and balances warehouse wise and later aggregate for accurate values
2022-02-11 18:14:28 +05:30
Ankush Menat
3e5f940686
test: e2e test for LIFO valuation
2022-02-06 20:12:15 +05:30
Ankush Menat
04f6426dbf
feat: show stock value difference in stock ledger report ( #29607 )
2022-02-03 17:14:57 +05:30
mergify[bot]
0dafa8a12a
fix: stock ledger rendering glitch
...
undefined Issue
(cherry picked from commit f38004219518e901eb736780b181c19fe88ce823)
Co-authored-by: smehata <53169014+smehata@users.noreply.github.com>
2022-01-27 20:23:24 +05:30
Ankush Menat
f5f3552abb
test: cover more reports in test
2022-01-25 23:22:14 +05:30
Ankush Menat
82ea958730
fix: ignore cancelled SLEs ( #29303 )
2022-01-16 20:19:04 +05:30
Ankush Menat
24fc487dd8
fix: incorrect serial no valuation report showing cancelled entries ( #29172 )
2022-01-06 17:03:34 +05:30
marination
6ca978c18b
fix: Linter (extra line after import)
2021-12-28 11:46:46 +05:30
marination
098f72e7ec
test: Stock Ageing FIFO Slot generation
2021-12-28 02:33:54 +05:30
Marica
0eb38a4b13
Merge branch 'develop' into stock-ageing-negative-stock
2021-12-28 01:29:01 +05:30
marination
c007f84ade
chore: Added .md file to explain stock ageing business logic
2021-12-28 01:27:24 +05:30
marination
878fd377c2
chore: Use frappe.qb for query
2021-12-27 21:09:05 +05:30
Ankush Menat
7987a46509
chore: add running stock value difference in invariant report ( #29012 )
...
[skip ci]
2021-12-23 21:13:22 +05:30
marination
24a35c69c0
fix: Sider and Server side test
...
- args passed to wrong function
- missing space around '='
2021-12-21 12:52:03 +05:30
marination
8951a5c267
fix: Linter (imports)
2021-12-20 21:53:47 +05:30
marination
0f43792dbb
fix: Stock Ageing Report - Negative Opening Stock
...
- Consider negative opening stock in logic and neutralise it with +ve stock
- minor code refactor: class for FIFOSlots to generate chronological FIFO queue
2021-12-20 21:33:59 +05:30
Ankush Menat
6ba8f7644d
chore: ledger invariant check report ( #28921 )
2021-12-16 22:31:31 +05:30
Ankush Menat
228e011819
perf: remove forcing of posting sort index on stock balance ( #28902 )
...
mysql is generally smart enough to figure out which index is better
based on cardinality of index. While posting sort index is better for
low item high # of SLE scenario it's bad for high item variety each with
lower count of SLEs.
2021-12-15 19:18:41 +05:30
aaronmenezes
304aa44feb
fix: Nonstock item showing in Itemwise Recommended Reorder Level report ( #28873 )
2021-12-14 15:18:03 +05:30
Noah Jacob
7ff30a4b2b
fix: incorrect balance for warehouses ( #28583 )
2021-11-26 17:33:57 +05:30
Ankush Menat
87f2dcfb59
fix: total stock summary UI glitch #28564
...
fix: total stock summary UI glitch
2021-11-25 19:38:44 +05:30
Ankush Menat
e498389b00
fix: ignore cancelled entries in incorrect balance qty report
2021-11-10 12:09:51 +05:30
Ankush Menat
8fe5feb6a4
chore: remove all six compat code
2021-11-05 11:16:29 +05:30
Ankush Menat
6098e92ba9
chore: remove utf-8 compat code
2021-11-05 11:16:29 +05:30
Noah Jacob
fdaf93f76c
refactor: shows opening balance from filtered from_date ( #26877 )
...
* refactor: shows opening balance from filtered from_date
* refactor: opening balance considered from filtered from_date in stock ledger
* fix: check if stock reco is opening and misc cleanups
2021-10-23 21:04:42 +05:30
Alan
2849297471
refactor: move process loss report to manufacturing ( #28043 )
...
* refactor: move process loss report to manufacturing
* test: fix process loss report test
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-10-21 11:07:47 +05:30
Ankush Menat
da3635b94f
test: execute manufacturing reports
2021-10-20 20:35:11 +05:30
Ankush Menat
126ba16740
fix: remove debug from query
2021-10-20 20:35:11 +05:30
Ankush Menat
06fa35a9c1
test: add custom TestCase class and use in stock
2021-10-12 16:17:15 +05:30
Ankush Menat
70c203d19e
test: automated test for running all stock reports ( #27510 )
...
* test: automated test for running all stock reports
These test do not assert correctness, they just check that "execute" function
is working with sane filters.
* test: make report execution test modular
2021-09-15 19:24:35 +05:30
Ankush Menat
d743c41b54
fix(ux): apply proper filtering in stock reports ( #27411 )
...
* fix(ux): apply proper filtering in stock reports
Stock Balance: apply company filter to warehouse field
Stock Ageing: apply company filter to warehouse field
* fix: unnecessary parens
Co-authored-by: Alan <2.alan.tom@gmail.com>
2021-09-12 16:38:18 +05:30
Chillar Anand
915b34391c
chore: Clean up imports ( #27302 )
...
* chore: Added isort to pre-commit config
* chore: Sort imports with isort
* chore: Clean up imports with pycln
* chore: Sort imports with isort
* chore: Fix import issues
* chore: Clean up sider issues
* chore: Remove import errors from flake8 ignore list
* chore: Clean up lint issues
2021-09-02 16:44:59 +05:30
Ankush Menat
b147b85e6a
chore: whitespace / eof fixes
2021-09-01 16:57:21 +05:30
Ankush Menat
9fec0a5c68
refactor: itemgetter instead of assigned lambda
2021-09-01 15:02:29 +05:30
Alan
9dc0843cbd
fix: translate labels ( #27282 )
...
[skip ci]
2021-09-01 12:58:34 +05:30