Ankush Menat
f83a1c1989
fix: dont reset barcode in scan mode
2022-04-04 12:06:35 +05:30
Ankush Menat
1736ab57ac
feat: Barcode scanning in Stock Reconciliation
...
[skip ci]
2022-04-04 12:06:35 +05:30
marination
7ef1ccbe84
fix: Add default score of 1 to Item Group Autocompleter
...
- If score 0 is inserted into suggestions, RS does not consider that suggestion
2022-04-04 12:04:35 +05:30
marination
97e3a855f7
fix: Convert payload to string before adding to autocompleter
2022-04-04 11:32:49 +05:30
Rucha Mahabal
d9f00409b9
Merge branch 'develop' into multiple-shifts
2022-04-04 11:19:03 +05:30
Suraj Shetty
40d33b5fec
test: Use FrappeAPITestCase to track coverage
2022-04-04 11:15:29 +05:30
Rucha Mahabal
1d4b1c42f2
fix: skip validation for overlapping shift attendance if no shift is linked
2022-04-04 11:14:40 +05:30
marination
ea036e4958
fix: Better Exception Handling and vaeiabl naming
...
- Function to handle RS exceptions (create log and raise error)
- Handle `ResponseError` where it is anticipated
- Misc: Better variables
2022-04-04 11:07:53 +05:30
Rucha Mahabal
62cdde9a84
test: skip auto attendance
2022-04-04 11:05:03 +05:30
Rucha Mahabal
277bda11dd
test: validations for duplicate and overlapping shift attendance records
2022-04-04 11:04:24 +05:30
Rucha Mahabal
83489be7d9
fix: add validation for overlapping shift attendance
...
- skip auto attendance in case of overlapping shift attendance record
- this case won't occur in case of shift assignment, since it will not allow overlapping shifts to be assigned
- can happen if manual attendance records are created
2022-04-04 11:00:26 +05:30
Suraj Shetty
f4b8573e64
test: Fix erroneous code
2022-04-04 09:31:15 +05:30
Suraj Shetty
cfee53eb55
fix: Handle exception where no employee is returned
2022-04-04 07:38:15 +05:30
Suraj Shetty
39abfae5fe
chore: Remove unused code
...
- and simplify get_call_log
2022-04-04 07:28:41 +05:30
Suraj Shetty
0e9ebad9c6
test: Refactor exotel test setup
...
- Remove unnecessary code
- Move test data to separate file
- Make proper test assertions
2022-04-04 07:23:08 +05:30
Rucha Mahabal
7bd84f2696
chore: remove unused import
2022-04-03 23:58:04 +05:30
Rucha Mahabal
58fb2f7dde
refactor: Overlapping validation for Shift Request
...
- commonify time overlap function between request and assignment
- add tests for shift request overlap
2022-04-03 23:54:03 +05:30
Rucha Mahabal
6fffdcf0c7
test: Shift Type with Auto Attendance setup and working
...
fix test setups
2022-04-03 22:37:10 +05:30
Rucha Mahabal
655c1dd6ab
fix: attendance fixes
...
- check half day attendance threshold before absent threshold to avoid half day getting marked as absent
- round working hours to 2 digits for better accuracy
- start and end dates for absent attendance marking
2022-04-03 21:47:32 +05:30
Suraj Shetty
6644ebd52d
Merge branch 'develop' into exotel-fixes
2022-04-03 21:17:29 +05:30
Deepesh Garg
a7e125a540
chore: format patch file
2022-04-02 20:36:36 +05:30
Deepesh Garg
c58fde2fb2
fix: Add competitor field back
2022-04-02 20:03:46 +05:30
Deepesh Garg
205c8c2bda
Merge pull request #30191 from abhinavxd/patch-3
...
fix: incorrect payable amount for loan closure
2022-04-02 19:53:07 +05:30
Deepesh Garg
7e185fb0f2
Merge branch 'develop' of https://github.com/frappe/erpnext into patch-3
2022-04-02 17:42:09 +05:30
Deepesh Garg
485f5cfdfe
fix: Resolve conflicts
2022-04-02 17:25:29 +05:30
Deepesh Garg
0f6d52c625
Merge branch 'develop' of https://github.com/frappe/erpnext into mergify/bp/develop/pr-30385
2022-04-02 17:24:19 +05:30
Subin Tom
e57e7bb02c
fix: added tests(fixed)
2022-04-02 17:16:56 +05:30
Ankush Menat
c8ead0a7ab
fix: dont send empty serial no in get_item_details
...
[skip ci]
2022-04-01 21:11:03 +05:30
Ankush Menat
6a069d6efa
feat: dont trigger selector if all info is scanned
2022-04-01 21:11:03 +05:30
Ankush Menat
47f27a5171
refactor: move scan api to stock utils; add item_info
2022-04-01 21:11:03 +05:30
Ankush Menat
9bf427985f
fix!: remove barcode field triggers
...
use "scan barcode" field instead for scanning
[skip ci]
2022-04-01 21:11:03 +05:30
Ankush Menat
530f767098
revert: "fix: ignore circular dependencies on barcode scan"
...
This reverts commit 98468fab18
2022-04-01 21:11:03 +05:30
Ankush Menat
767b827b59
feat: return batch code while scanning serial no
2022-04-01 21:11:03 +05:30
marination
07f17453cd
fix: Use Payload in AutoCompleter (categories in search) and misc
...
- Separate Item group and Item autocomplete dict definition
- Add payload along with Item group, containing namke and route
- Pass weightage while defining item group autocomplete dict (auto sort)
- Use payload while getting results for categories in search
- Remove check to show categories, always show
- Search fields mandatory if reidsearch enabled
- Code separation (rough)
2022-04-01 18:47:01 +05:30
gavin
1d2e9e8e1c
Merge pull request #30521 from gavindsouza/misc-fixes-0
...
fix: Handle changes in frappe's get_monthly_goal_graph_data API
2022-04-01 17:28:59 +05:30
Gavin D'souza
f8c9fba52d
fix: Handle changes in frappe's get_monthly_goal_graph_data API
2022-04-01 17:18:47 +05:30
Sagar Sharma
01c64915c8
chore: remove unwanted validation
2022-04-01 15:51:48 +05:30
Ankush Menat
6c5b01c60d
perf: index barcode for faster scans ( #30543 )
2022-04-01 15:27:46 +05:30
Alberto826
5d14e7860e
Fix: Remove trailing slash "/" from route ( #30532 )
...
Routes with trailing slash "/" causes a redirect to port 8080 in docker host with reverse proxy.
The Student Admission Row template has this issue.
2022-04-01 14:48:00 +05:30
Deepesh Garg
9a6a181f14
fix: Ignore disabled tax categories
2022-04-01 14:46:26 +05:30
Rucha Mahabal
65763275ae
fix: convert dates to datetime before comparing in leave days calculation and fix half day edge case ( #30538 )
2022-04-01 13:47:52 +05:30
Sagar Sharma
0a3cdc2623
chore: rename "is_subcontracted" field label to "Is Subcontracted"
2022-04-01 13:22:54 +05:30
Sagar Sharma
d074c93ac7
refactor!: change "is_subcontracted" field type from "Select" to "Check"
2022-04-01 13:22:44 +05:30
Ankush Menat
257623509d
perf: use cached single docs ( #30536 )
...
frappe.local is request specific thread local, hence is almost as good
as no caching.
2022-04-01 11:55:19 +05:30
Saqib Ansari
bfc34e1084
fix: check for debit credit difference even after round-off adjustment ( #30050 )
2022-04-01 11:03:16 +05:30
Deepesh Garg
8598d64d2c
Merge pull request #30502 from dj12djdjs/fix-pe-ex-rate-precision
...
fix(accounts): payment entry exchange rate precision
2022-04-01 09:48:15 +05:30
Deepesh Garg
df06d263ae
Merge pull request #30510 from deepeshgarg007/tax_mapping
...
fix: Taxes getting overriden from mapped to target doc
2022-04-01 09:43:19 +05:30
rohitwaghchaure
8d16c7f44b
Merge pull request #30527 from rohitwaghchaure/feat-pick-list-item-reference-in-delivery-note
...
feat: minor, pick list item reference on delivery note item table
2022-03-31 20:22:49 +05:30
Rohit Waghchaure
2f51011f91
test: test case to check pick list name has mapped or not
2022-03-31 18:47:09 +05:30
Rohit Waghchaure
2f63ae2ee9
feat: minor, pick list item reference on delivery note item table
2022-03-31 18:43:42 +05:30
