Ankush Menat
6a069d6efa
feat: dont trigger selector if all info is scanned
2022-04-01 21:11:03 +05:30
Ankush Menat
47f27a5171
refactor: move scan api to stock utils; add item_info
2022-04-01 21:11:03 +05:30
Ankush Menat
9bf427985f
fix!: remove barcode field triggers
...
use "scan barcode" field instead for scanning
[skip ci]
2022-04-01 21:11:03 +05:30
Ankush Menat
530f767098
revert: "fix: ignore circular dependencies on barcode scan"
...
This reverts commit 98468fab18
.
2022-04-01 21:11:03 +05:30
Ankush Menat
767b827b59
feat: return batch code while scanning serial no
2022-04-01 21:11:03 +05:30
marination
07f17453cd
fix: Use Payload in AutoCompleter (categories in search) and misc
...
- Separate Item group and Item autocomplete dict definition
- Add payload along with Item group, containing namke and route
- Pass weightage while defining item group autocomplete dict (auto sort)
- Use payload while getting results for categories in search
- Remove check to show categories, always show
- Search fields mandatory if reidsearch enabled
- Code separation (rough)
2022-04-01 18:47:01 +05:30
gavin
1d2e9e8e1c
Merge pull request #30521 from gavindsouza/misc-fixes-0
...
fix: Handle changes in frappe's get_monthly_goal_graph_data API
2022-04-01 17:28:59 +05:30
Gavin D'souza
f8c9fba52d
fix: Handle changes in frappe's get_monthly_goal_graph_data API
2022-04-01 17:18:47 +05:30
Sagar Sharma
01c64915c8
chore: remove unwanted validation
2022-04-01 15:51:48 +05:30
Ankush Menat
6c5b01c60d
perf: index barcode for faster scans ( #30543 )
2022-04-01 15:27:46 +05:30
Alberto826
5d14e7860e
Fix: Remove trailing slash "/" from route ( #30532 )
...
Routes with trailing slash "/" causes a redirect to port 8080 in docker host with reverse proxy.
The Student Admission Row template has this issue.
2022-04-01 14:48:00 +05:30
Rucha Mahabal
65763275ae
fix: convert dates to datetime before comparing in leave days calculation and fix half day edge case ( #30538 )
2022-04-01 13:47:52 +05:30
Sagar Sharma
0a3cdc2623
chore: rename "is_subcontracted" field label to "Is Subcontracted"
2022-04-01 13:22:54 +05:30
Sagar Sharma
d074c93ac7
refactor!: change "is_subcontracted" field type from "Select" to "Check"
2022-04-01 13:22:44 +05:30
Ankush Menat
257623509d
perf: use cached single docs ( #30536 )
...
frappe.local is request specific thread local, hence is almost as good
as no caching.
2022-04-01 11:55:19 +05:30
Saqib Ansari
bfc34e1084
fix: check for debit credit difference even after round-off adjustment ( #30050 )
2022-04-01 11:03:16 +05:30
Deepesh Garg
8598d64d2c
Merge pull request #30502 from dj12djdjs/fix-pe-ex-rate-precision
...
fix(accounts): payment entry exchange rate precision
2022-04-01 09:48:15 +05:30
Deepesh Garg
df06d263ae
Merge pull request #30510 from deepeshgarg007/tax_mapping
...
fix: Taxes getting overriden from mapped to target doc
2022-04-01 09:43:19 +05:30
rohitwaghchaure
8d16c7f44b
Merge pull request #30527 from rohitwaghchaure/feat-pick-list-item-reference-in-delivery-note
...
feat: minor, pick list item reference on delivery note item table
2022-03-31 20:22:49 +05:30
Rohit Waghchaure
2f51011f91
test: test case to check pick list name has mapped or not
2022-03-31 18:47:09 +05:30
Rohit Waghchaure
2f63ae2ee9
feat: minor, pick list item reference on delivery note item table
2022-03-31 18:43:42 +05:30
Deepesh Garg
02dab021c6
Merge pull request #30500 from deepeshgarg007/auto_tax_gst
...
fix(India): Tax fetching based on tax category
2022-03-31 18:01:32 +05:30
marination
7e207c8901
fix: Call Redisearch index creation functions on enabling redisearch in settings
2022-03-31 16:29:18 +05:30
Marica
96fc6ad590
Merge pull request #30146 from marination/bom-update-tool
...
refactor: Add exception handling in background job within BOM Update Tool
2022-03-31 15:54:34 +05:30
Marica
cd9d07028d
Merge branch 'develop' into bom-update-tool
2022-03-31 14:54:05 +05:30
Marica
901d8eac57
Merge pull request #30509 from marination/buying-validate-items
...
fix: Add non-existent Item check and cleanup in `validate_for_items`
2022-03-31 14:52:34 +05:30
Saqib Ansari
9af353ffa9
Merge pull request #30461 from nextchamp-saqib/fix-asset-warehouse-validation
...
fix(asset): do not validate warehouse on asset purchase
2022-03-31 14:15:16 +05:30
Deepesh Garg
e0631474c0
Merge branch 'develop' into auto_tax_gst
2022-03-31 13:52:10 +05:30
Deepesh Garg
544533ced2
Merge pull request #30486 from deepeshgarg007/account_currenct_change_test
...
fix: Account currency validation
2022-03-31 13:39:04 +05:30
marination
93f6346cea
fix: (test) change expected exception due to https://github.com/frappe/frappe/pull/16454
2022-03-31 13:07:51 +05:30
marination
2fece523f6
chore: Added BOM std filters and update type in List View
2022-03-31 12:55:48 +05:30
Saqib Ansari
4623a1bc57
fix(test): Item MacBook does not exist
2022-03-31 12:48:00 +05:30
Marica
f482b184a0
Merge branch 'develop' into bom-update-tool
2022-03-31 12:42:56 +05:30
Deepesh Garg
4720969ce6
fix: Taxes getting overriden from mapped to target doc
2022-03-31 12:14:16 +05:30
marination
982a246eec
fix: Add non-existent Item check and cleanup in validate_for_items
...
- Added a validation if invalid item code ia passed via data import/API, etc.
- Used DB APIs instead of raw sql
- Separated checks into separate functions
- Added return types to functions
- Better variable naming and removed redundant utils import in function
2022-03-31 11:47:20 +05:30
Saqib Ansari
199a6da960
perf: skip warehouse validation for non-stock items
2022-03-31 11:41:52 +05:30
Devin Slauenwhite
62266b29aa
fix: exchange rate precision
2022-03-30 14:22:44 -04:00
Ankush Menat
b981fae5a4
fix: remove naming series from bin, repost queue ( #30497 )
...
Removing naming series from:
1. Bin
2. Repost queue
These doctypes are not user facing and dont really need naming series.
Current implementation of naming makes stock transaction sequential if
these documents are to be created during submission.
2022-03-30 21:46:15 +05:30
Deepesh Garg
45f78977bf
Merge pull request #30493 from nabinhait/party-account-in-ar-ap-report
...
feat: Receivable/Payable Account column and filter in AR/AP report
2022-03-30 21:16:32 +05:30
Deepesh Garg
d93edbc859
fix: make test record
2022-03-30 21:07:56 +05:30
Deepesh Garg
532961fad2
fix(India): Tax fetching based on tax category
2022-03-30 19:33:44 +05:30
marination
a945484af4
test: Added test for 2 more validations
...
- Covers full validate function
2022-03-30 18:20:54 +05:30
marination
620575a901
fix: Type Annotations, Redundancy, etc.
...
- Renamed public function`update_new_bom` to `update_new_bom_in_bom_items`
- Replaced `get_cached_doc` with `get_doc`
- Removed click progress bar (drive through update log)
- Removed `bom_obj.update_new_bom()`, was redundant. Did same job as `update_new_bom_in_bom_items`
- Removed `update_new_bom()` in `bom.py`, unused.
- Prettier query formatting
- `update_type` annotated as non optional Literal
- Removed redundant use of JobTimeoutException
- Corrected type annotations in `create_bom_update_log()`
2022-03-30 18:03:52 +05:30
mergify[bot]
89a9afab94
fix: cast array slice index integer while splitting serial_nos array ( #30468 ) ( #30496 )
...
(cherry picked from commit 3f3717952c94af428c3d4c919aceb6b8cbae7679)
Co-authored-by: Anoop <anoop@earthianslive.com>
2022-03-30 17:00:28 +05:30
gavin
b9d37152ba
Merge pull request #30494 from resilient-tech/fix-get-cached-value
...
fix: update `get_cached_value` usage based on changes in definition
2022-03-30 16:26:51 +05:30
Sagar Vora
7bece37918
fix: update get_cached_value
usage based on changes in definition
2022-03-30 15:35:56 +05:30
Saqib Ansari
5408980223
Merge pull request #30453 from rahib-hassan/fix-paymentorder-row-delete
...
fix: enable row deletion in reference table
2022-03-30 15:31:54 +05:30
Saqib Ansari
291415d255
Merge pull request #30453 from rahib-hassan/fix-paymentorder-row-delete
...
fix: enable row deletion in reference table
2022-03-30 15:00:16 +05:30
Saqib Ansari
03e6a6c699
Merge branch 'develop' into fix-asset-warehouse-validation
2022-03-30 14:58:49 +05:30
Rucha Mahabal
9ff1904aec
fix: explicitly check if additional salary is recurring while fetching components for payroll ( #30489 )
2022-03-30 14:47:11 +05:30