ruthra kumar
a0fc68538f
refactor: toggle for negative rates in Selling Settings
2023-08-15 07:34:33 +05:30
Deepesh Garg
f8e7bc08af
Merge pull request #36564 from deepeshgarg007/monthly_sales_update
...
fix: Make default sales update frequency as monthly instead of each transaction
2023-08-11 22:39:04 +05:30
ruthra kumar
64614cd915
refactor(test): don't set po_no by default
2023-08-11 17:43:50 +05:30
ruthra kumar
dbd3fdbb41
fix: disallow mulitple SO with same PO No
2023-08-11 09:59:07 +05:30
Deepesh Garg
32863b4922
fix: Make default sales update frequency as monthly instead of each transaction
2023-08-09 15:36:28 +05:30
ruthra kumar
a93ae9c826
Merge pull request #36434 from ruthra-kumar/replace_get_cached_with_get_single_value
...
fix: incorrect usage `get_cached_value` on single doctypes
2023-08-01 10:02:33 +05:30
ruthra kumar
ba15810639
fix: incorrect usage get_cached_value on single doctypes
2023-08-01 07:58:09 +05:30
rohitwaghchaure
f83a100a8d
fix: not able to make material request ( #36416 )
2023-07-31 19:13:23 +05:30
Deepesh Garg
c6b024c34b
Merge pull request #36167 from barredterra/percentage-rounding
...
fix: rounding of percentage fields
2023-07-30 14:41:30 +05:30
rohitwaghchaure
4e58503075
Merge pull request #36377 from rohitwaghchaure/fixed-pp-sub-assembly-available-items
...
fix: multiple issues related to Production Plan
2023-07-28 17:26:06 +05:30
Rohit Waghchaure
1c2148b637
fix: multiple issues related to Production Plan
2023-07-28 15:38:00 +05:30
Deepesh Garg
ebdf1959fd
Merge pull request #36254 from deepeshgarg007/remove_auto_repeat
...
fix: Remove auto repeat (subscription) button from Sales and Purchase documents
2023-07-27 21:18:03 +05:30
Deepesh Garg
3f81e15672
Merge pull request #36147 from deepeshgarg007/eslint
...
refactor(ci): add eslint and update linting confs
2023-07-24 20:55:07 +05:30
Deepesh Garg
4bb6db86f8
fix: Remove auto repeat (subscription) button from Sales and Purchase documents
2023-07-24 12:29:57 +05:30
Deepesh Garg
7205fb9b97
chore: convert sales common to utils
2023-07-23 12:07:21 +05:30
s-aga-r
9fb1533b8f
fix(test): test_stock_reservation_against_sales_order ( #36166 )
2023-07-18 08:31:02 +05:30
Deepesh Garg
9e791efc82
refactor: client side accounts controller
2023-07-17 21:44:43 +05:30
barredterra
ecaf0aba3c
fix: rounding of percentage fields
...
Always round with precision of 2
2023-07-17 16:45:11 +02:00
Raffael Meyer
bf84e0d441
refactor: remove frappe.dynamic_link ( #35096 )
2023-07-10 21:22:06 +05:30
Deepesh Garg
0408b6d655
Merge branch 'develop' of https://github.com/frappe/erpnext into #34282-Record-advance-payment-as-a-liability
2023-06-29 12:19:42 +05:30
Gursheen Kaur Anand
5113a417a1
fix!: UX of supplier linking with supplier users on portal pages ( #35836 )
...
* fix: create and add Portal Users child table in Supplier/Customer
Issue #35772
* fix: modify the original permission check hook
* fix: auto-add role for portal users
* fix: added patch for auto-populating portal users
* fix: modify patch to fetch users correctly
* fix: remove unnecessary code for updating naming_series
* fix(UX): show portal user in list view
Also split columns to reduce whitespace.
* refactor: simpler role checking
* fix: consider parenttype while fetching portal user
* refactor: simpler code, rename variable
* test: supplier portal user can access their docs
* refactor: only add role if not added
* refactor: rename and move patch to supplier
* refactor: dont add role if no perm or existing doc
* fix: add role before save
* refactor: run query directly
* refactor: split patch and apply roles
- if role isn't present dont add portal user
- ignore failure as it's not critical
* test: fix permission creation for webform test
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-28 11:22:40 +05:30
Deepesh Garg
da6bc1a13e
refactor: Redo workflows
2023-06-23 20:57:51 +05:30
Deepesh Garg
98cfea6f63
Merge branch 'develop' of https://github.com/frappe/erpnext into #34282-Record-advance-payment-as-a-liability
2023-06-20 13:26:14 +05:30
Raffael Meyer
11126521c9
Merge branch 'develop' into bank-trans-party-automatch
2023-06-19 15:04:37 +02:00
Deepesh Garg
7ec9d76545
Merge branch 'develop' of https://github.com/frappe/erpnext into #34282-Record-advance-payment-as-a-liability
2023-06-19 09:48:01 +05:30
s-aga-r
4b5454c752
fix(ux): set route options for new SBB
2023-06-16 15:04:37 +05:30
Raffael Meyer
51848ee9d7
Merge branch 'develop' into bank-trans-party-automatch
2023-06-15 16:36:17 +02:00
rohitwaghchaure
4820221a41
Merge pull request #35636 from s-aga-r/FIX-SBB-AttributeError
...
fix: miscellaneous
2023-06-14 16:02:04 +05:30
s-aga-r
7549a5c371
fix(ux): add filters for SBB
2023-06-14 15:04:51 +05:30
Deepesh Garg
984f89d274
fix: Validation for delivery date in Sales Order ( #35597 )
...
* fix: Validation for delivery date in Sales Order
* chore: update utils
* chore: revert
* chore: Add default delivery date
2023-06-13 21:35:52 +05:30
Ankush Menat
a3ea985348
refactor: Use db.set_single_value ( #35668 )
...
I just applied semgrep autofix. Untested completed, review before merging.
```yaml
- id: frappe-set-value-semantics
patterns:
- pattern-either:
- pattern: frappe.db.set_value($DOCTYPE, None, $...AFTER)
- pattern: frappe.db.set_value($DOCTYPE, $DOCTYPE, $...AFTER)
fix: frappe.db.set_single_value($DOCTYPE, $...AFTER)
message: |
If $DOCTYPE is a single doctype then using `frappe.db.set_value` is discouraged for setting values in DB. Use db.set_single_value for single doctype instead.
languages: [python]
severity: ERROR
```
2023-06-13 17:30:38 +05:30
Gursheen Anand
17341adf1c
fix: calculate outstanding amount on reconcile correctly
2023-06-13 15:00:46 +05:30
Gursheen Anand
7591f1010b
fix: Make get party account method return a list instead of a single default account.
2023-06-12 11:06:03 +05:30
David Arnold
c1b42b858d
fix: set Phone and Email option in doctypes ( #35549 )
2023-06-11 19:34:41 +05:30
Gursheen Anand
4ee163742a
fix: Using one field for both advance liability accounts
2023-06-08 13:15:23 +05:30
HarryPaulo
a9a47a51e4
fix: based on status_update.py update opportunity status to converted… ( #35145 )
...
fix: based on status_update.py update opportunity status to converted on sales submit
2023-06-07 21:35:52 +05:30
Deepesh Garg
0108b1abe2
fix: Improve validation message ( #35489 )
...
* fix: Improve validation message
* Update erpnext/selling/doctype/customer/customer.py
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
---------
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2023-06-07 21:33:36 +05:30
Nabin Hait
1cf1c7943f
Merge pull request #35572 from nabinhait/quotation-fix
...
feat: ability to create quotation against a prospect
2023-06-06 21:54:24 +05:30
Marica
75387bbaef
Merge branch 'develop' into bank-trans-party-automatch
2023-06-06 19:03:26 +05:30
Nabin Hait
47ce6de57d
feat: ability to create quotation against a prospect
2023-06-06 15:19:04 +05:30
s-aga-r
8fe1904f3f
fix(test): test_stock_reservation_against_sales_order
2023-06-06 14:59:17 +05:30
Sagar Sharma
5ebf46a1b5
Merge pull request #35510 from s-aga-r/FIX-ISS-23-24-01141
...
fix: ignore `Non-Stock Item` while calculating `% Picked` in Sales Order
2023-06-03 11:18:05 +05:30
Rohit Waghchaure
f8bf4aa7c8
fix: travis for work order, pos invoice and landed cost voucher
2023-06-02 17:14:17 +05:30
Rohit Waghchaure
e6143abb8a
refactor: added new file serial batch bundle
2023-06-02 17:14:14 +05:30
Gursheen Anand
74619269f0
feat: Record Advance Payments as Liability
...
Ability to let user record advance payments as liability instead of a negative asset.
Issue #34282
2023-06-02 17:13:51 +05:30
Raffael Meyer
09872301bd
Merge branch 'develop' into bank-trans-party-automatch
2023-06-01 18:03:10 +02:00
s-aga-r
4044c2ed40
fix(test): test_stock_reservation_against_sales_order
2023-06-01 17:00:57 +05:30
s-aga-r
0305a925fe
fix: ignore Non-Stock Item while calculating % Picked in Sales Order
2023-06-01 14:18:48 +05:30
Sagar Sharma
fefd788eb5
fix(ux): add non-group warehouse filter
2023-05-25 11:49:47 +05:30
rohitwaghchaure
565322daba
Merge branch 'develop' into stock-reservation
2023-05-24 14:32:04 +05:30
