Deepesh Garg
7145e9d183
Merge pull request #26359 from GangaManoj/enable-discount-accounting
...
feat: Enable discount accounting
2021-08-14 18:05:29 +05:30
Frappe PR Bot
b5926a33b3
fix: unknown attribute "string_type" ( #26947 ) ( #26950 )
...
(cherry picked from commit 6aed9e26acaf266f7260adab16656d554c6bb022)
Co-authored-by: Ankush Menat <ankush@iwebnotes.com>
2021-08-14 10:48:33 +05:30
GangaManoj
f9356ee642
fix: Sider issues
2021-08-13 17:40:51 +05:30
GangaManoj
f977c65e80
fix: Make enable_discount_accounting a class property
2021-08-13 17:17:58 +05:30
GangaManoj
5999760a65
fix: Syntax error
2021-08-13 17:13:38 +05:30
Deepesh Garg
5122948450
Merge branch 'develop' of https://github.com/frappe/erpnext into enable-discount-accounting
2021-08-13 16:00:20 +05:30
Marica
2e6899fbe4
fix: Copy previous balance dict object instead of assigning ( #26942 )
...
- Due to plain assignment, dict mutation gave wrong monthly values
(cherry picked from commit fe2a34f171
2021-08-13 10:08:41 +00:00
Marica
fe2a34f171
fix: Copy previous balance dict object instead of assigning ( #26942 )
...
- Due to plain assignment, dict mutation gave wrong monthly values
2021-08-13 15:37:45 +05:30
Shariq Ansari
b32c2fa561
fix: updated erpnext wspace json files ( #26380 )
...
* fix: updated erpnext wspace json files
* fix: updated wspace json files
* fix: updated wspace json files
* fix: removed padding code from wspace json files
* fix: Updated restrict_to_domain in wspace json
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-13 12:19:16 +05:30
Afshan
587d2db6a9
fix: show proper currency symbol in taxes and charges table ( #26827 )
...
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
Co-authored-by: Deepesh Garg <42651287+deepeshgarg007@users.noreply.github.com>
2021-08-13 10:59:06 +05:30
Afshan
1de4c01942
fix: Deferred Revenue Section should be collapsible only if its not enabled ( #26928 )
2021-08-12 23:06:34 +05:30
Noah Jacob
b8658d003f
fix: from_warehouse getting set to None ( #26920 )
2021-08-12 20:03:28 +05:30
Frappe PR Bot
f4b2f4aaf7
fix: ZeroDivisionError on creating e-invoice for credit note ( #26918 )
2021-08-12 17:11:38 +05:30
Saqib
88f13fef81
fix: ZeroDivisionError on creating e-invoice for credit note ( #26915 )
2021-08-12 16:26:51 +05:30
Ganga Manoj
54c31ed33c
feat: depreciate asset after sale ( #26543 )
2021-08-12 13:42:56 +05:30
Marica
08e4026456
fix: Stock Analytics Report must consider warehouse during calculation ( #26908 )
...
* fix: Stock Analytics Report must consider warehouse during calculation
* fix: Brand filter in Stock Analytics
(cherry picked from commit 703b081172981833bcf9a1fc5c86517817c3ff32)
2021-08-12 05:02:42 +00:00
Deepesh Garg
f037bae8ea
Merge pull request #26397 from GangaManoj/po-payment-terms
...
feat: Fetch Payment Terms from linked Sales/Purchase Order
2021-08-11 22:28:34 +05:30
Deepesh Garg
a7054560da
Merge branch 'develop' into po-payment-terms
2021-08-11 19:31:30 +05:30
Marica
42899d69ea
Merge branch 'develop' into stock-analytics
2021-08-11 18:44:29 +05:30
Deepesh Garg
13fb71f642
Merge branch 'develop' into payment_entry_validations_and_trigger_develop
2021-08-11 18:20:42 +05:30
marination
455d300fca
Revert "test: fix POS Closing Entry Test"
...
This reverts commit 8f1a3aef2e
2021-08-11 17:00:46 +05:30
marination
867939fcae
test: fixed asset movement tests
...
- set cwip account in company to avoid value missing
- removed unused statement
- removed trailing spaces
2021-08-11 16:40:07 +05:30
marination
8f1a3aef2e
test: fix POS Closing Entry Test
...
- Separated into two tests, one checks if SI cancelling is blocked, the other checks PCE cancel impact
- This is done because after cancel via assertRaises, damage done by cancel still exists or is partially comitted
- Dont use this partially cancelled doc for any assertions further, end test at exception assertion
- Use `get_value` to check SI docstatus, as its primary key changes after cancel
2021-08-11 15:17:06 +05:30
Suraj Shetty
99658ceb4e
fix: Nest .level class style under .hierarchy class
...
- To avoid style overrides in list view
2021-08-11 14:19:07 +05:30
marination
bca30d6101
test: fix Shift Request test
...
- Use `get_value` instead of `get_doc`
- Remove unnecessary loop, only one shift assignment is made against a shift request
- Get value after cancel again. Get doc is not reliable since primary key changed after cancel
2021-08-11 13:29:44 +05:30
marination
e5b0221693
test: fix attendance request tests
...
- Use `frappe.db.get_value` instead of `get_doc` for asserting values
- Get values after cancellation as reloading attendance doc breaks due to stale doc (primary key changed after cancel of attendance request)
- rollback everything on tearDown
2021-08-11 13:02:49 +05:30
Deepesh Garg
a1f0cebda5
fix: Do not update settings for test
2021-08-11 11:50:39 +05:30
Deepesh Garg
02f44528f2
test: Add test case for payment entry unlink
2021-08-11 11:50:39 +05:30
Deepesh Garg
7141860c04
test: Update exchange rate in test cases
2021-08-11 11:50:39 +05:30
Deepesh Garg
b5162390e5
fix: Only do specific validations on reference unlink
2021-08-11 11:50:39 +05:30
Deepesh Garg
188bba8feb
fix: Validation for receivingfrom customer against negative outstanding
2021-08-11 11:50:39 +05:30
Deepesh Garg
c5276f3fd3
fix: Multiple fixes in payment entry
2021-08-11 11:50:16 +05:30
Deepesh Garg
a57d13e1e9
fix: Multiple fixes in payment entry
2021-08-11 11:50:16 +05:30
Afshan
976ae13c1e
Merge branch 'develop' into payment-reconc-party-validation-fix
2021-08-11 11:49:27 +05:30
Ankush
c1c9c4b68e
Merge branch 'develop' into fix_dn_test
2021-08-11 11:40:15 +05:30
Ankush
9152715f90
perf: various minor perf fixes for ledger postings ( #26775 )
...
* perf: only validate if voucher is journal entry
* perf: optimize merge GLE
- Order fields such that comparison will fail faster
- Break out of loops if not matched
* perf: don't try to match SLE if count mismatch
* refactor: simplify initialize_previous_data
* perf: use cache for fetching valuation_method
These are set only once fields
* refactor: simplify get_future_stock_vouchers
* refactor: simplify get_voucherwise_gl_entries
* perf: fetch only required fields for GL comparison
`select *` fetches all fields, output of this function is only used for
comparing.
* perf: reorder conditions in PL cost center check
* perf: reduce query while validating new gle
* perf: use cache for validating warehouse props
These properties don't change often, no need to query everytime.
* perf: use cached stock settings to validate SLE
* docs: update misleading docstring
Co-authored-by: Marica <maricadsouza221197@gmail.com>
2021-08-11 11:17:50 +05:30
Marica
e8be3a5243
Merge branch 'develop' into stock-analytics
2021-08-11 10:35:33 +05:30
Deepesh Garg
bff3b0962a
fix: Override template only if setting is enabled
2021-08-10 23:58:27 +05:30
Rucha Mahabal
9855bbb95e
fix(style): apply svg container margin only in desktop view ( #26894 )
2021-08-10 23:53:02 +05:30
Rucha Mahabal
15cb248d9e
fix(style): apply svg container margin only in desktop view
2021-08-10 23:44:08 +05:30
Rohit Waghchaure
7167fd00bc
Merge branch 'version-13-hotfix' into merged-v13-hotfix-into-pre-release
2021-08-10 23:30:16 +05:30
Frappe PR Bot
1167a9bf94
fix: unsetting of payment if no pos profile found ( #26891 )
...
* fix: unseting of payment if no pos profile found (#26884 )
(cherry picked from commit b614834efe
2021-08-10 23:18:23 +05:30
Frappe PR Bot
b7b111c3ed
fix: unseting of payment if no pos profile found ( #26884 ) ( #26890 )
...
(cherry picked from commit b614834efe
2021-08-10 22:52:37 +05:30
Afshan
b614834efe
fix: unseting of payment if no pos profile found ( #26884 )
2021-08-10 21:33:58 +05:30
marination
eb2050b407
fix: Brand filter in Stock Analytics
2021-08-10 20:37:09 +05:30
Anupam Kumar
a6aa6cd7d6
fix: timesheet amount issue ( #25993 )
...
* fix: timesheet amount issue
* fix: timesheet detail rate conversion
* fix: condition to check timesheet currency
* fix: removing console statement
2021-08-10 20:32:15 +05:30
Rucha Mahabal
52cd007292
fix: make bundled assets for hierarchy chart
2021-08-10 20:13:28 +05:30
Frappe PR Bot
1a39d1a311
fix: cost center & account validation in Sales/Purchase Taxes and Charges ( #26881 )
2021-08-10 19:38:39 +05:30
Anuja Pawar
66784a16cb
fix: Sales Return cancellation if linked with Payment Entry ( #26883 )
2021-08-10 19:38:16 +05:30
Marica
d657f39ab8
Merge pull request #25622 from noahjacob/promo_scheme_feat
...
feat: added multi-select fields to create multiple pricing rules.
2021-08-10 19:09:42 +05:30
marination
55d8aaf0b6
fix: Stock Analytics Report must consider warehouse during calculation
2021-08-10 19:01:05 +05:30
Marica
af9863146d
fix: Grammar in Error message
2021-08-10 18:49:07 +05:30
Noah Jacob
49b7c7575e
refactor: code cleanup
2021-08-10 18:35:46 +05:30
Noah Jacob
4ee6e32d74
test(fix): fixed test case
2021-08-10 18:34:18 +05:30
Rucha Mahabal
f9afade7dc
fix: test
2021-08-10 18:02:41 +05:30
Rucha Mahabal
c1bb4eec9c
fix: remove unnecessary imports
2021-08-10 18:02:31 +05:30
Rucha Mahabal
5f0edca3f3
fix(style): longer titles overflowing
2021-08-10 18:02:21 +05:30
Rucha Mahabal
78f50a9809
feat: Export chart option in desktop view
2021-08-10 18:02:05 +05:30
Rucha Mahabal
6f799d17ce
feat: Expand All nodes option in Desktop view
2021-08-10 18:01:15 +05:30
Rucha Mahabal
982a097d7a
fix: tests
2021-08-10 18:00:27 +05:30
Rucha Mahabal
525d4d4776
fix: sider
2021-08-10 17:56:13 +05:30
Rucha Mahabal
a1d379d5d4
test: UI tests for org chart mobile
...
fix(mobile): detach node before emptying hierarchy
fix(mobile): sibling group not rendering for first level
2021-08-10 17:56:04 +05:30
Rucha Mahabal
3cc85e166f
test: UI tests for org chart desktop
2021-08-10 17:55:53 +05:30
Rucha Mahabal
e1cf7712d9
fix: sider
2021-08-10 17:55:17 +05:30
Rucha Mahabal
9e7302a21e
fix(mobile): collapsed nodes not expanding
2021-08-10 17:55:08 +05:30
Rucha Mahabal
9270de59f4
fix: sibling group expansion not working for root nodes
2021-08-10 17:51:37 +05:30
Rucha Mahabal
c79316a9c0
fix: exclude active node while fetching sibling group
2021-08-10 17:51:28 +05:30
Rucha Mahabal
1a3c335feb
feat: use icon for connections on mobile view
2021-08-10 17:50:13 +05:30
Rucha Mahabal
b6715189fb
fix: do not sort by number of connections
2021-08-10 17:50:02 +05:30
Rucha Mahabal
a48b23e6a5
perf: Optimise Rendering
...
- optimise get_children function
- use promises instead of callbacks
- optimise selectors
- use const wherever possible
- use pure js instead of jquery for connectors for faster rendering
2021-08-10 17:49:53 +05:30
Rucha Mahabal
31a0f36ed9
feat: handle multiple root / orphan nodes
2021-08-10 17:49:44 +05:30
Rucha Mahabal
97d2bab434
fix: unnecessary variables
2021-08-10 17:49:36 +05:30
Rucha Mahabal
6a4cce2431
fix: removing orphaned connectors
2021-08-10 17:49:27 +05:30
Rucha Mahabal
781d1bf28d
fix: sider
2021-08-10 17:49:12 +05:30
Rucha Mahabal
d363f9db3d
fix: edit node button overflowing
2021-08-10 17:48:23 +05:30
Rucha Mahabal
6d06d8c207
feat: add arc to connectors in mobile view
2021-08-10 17:48:13 +05:30
Rucha Mahabal
4e7cda6e65
refactor: use arcs instead of bezier curves for cleaner connectors
2021-08-10 17:48:02 +05:30
Rucha Mahabal
e179cd9841
fix: revert changes in employee descendants query
2021-08-10 17:47:53 +05:30
Rucha Mahabal
aacb649050
feat: setup node edit action
2021-08-10 17:47:43 +05:30
Rucha Mahabal
249621af1b
refactor: add options to chart
...
- method to return the node data
- wrapper for showing the hierarchy
2021-08-10 17:47:06 +05:30
Rucha Mahabal
281241dc24
chore: create separate files for Desktop and Mobile view and bundle assets
2021-08-10 17:46:51 +05:30
Rucha Mahabal
e9c6ea077f
fix: don't refresh connections for same node
...
- remove all connectors while expanding a group node
2021-08-10 17:46:40 +05:30
Rucha Mahabal
fb9b628b89
feat: connectors for mobile node cards
2021-08-10 17:46:20 +05:30
Rucha Mahabal
25c5cff3de
fix: expanded node group interactions and visibility
2021-08-10 17:46:10 +05:30
Rucha Mahabal
5046cb09d8
feat(mobile): sibling node group expansion and rendering
2021-08-10 17:45:51 +05:30
Rucha Mahabal
8a33a039f7
feat: org chart mobile interactions
2021-08-10 17:44:52 +05:30
Rucha Mahabal
506ecb4216
feat: Organizational Chart
2021-08-10 17:44:30 +05:30
Anuja Pawar
0e337be065
fix: cost center & account validation in Sales/Purchase Taxes and Charges ( #25929 )
2021-08-10 17:26:35 +05:30
Anuja Pawar
1cba77cfbd
fix: Sales Return cancellation if linked with Payment Entry ( #26551 )
2021-08-10 17:25:12 +05:30
Frappe PR Bot
a7e0805039
fix(e-invoicing): cannot cancel invoice if IRN cancelled on portal ( #26879 )
2021-08-10 17:16:15 +05:30
Nabin Hait
f8031d3d79
Merge pull request #26261 from ruchamahabal/org-chart
...
feat: Organizational Chart
2021-08-10 17:12:59 +05:30
Saqib
84c4161c00
fix(e-invoicing): cannot cancel invoice if IRN cancelled on portal ( #26638 )
2021-08-10 16:46:44 +05:30
Saqib
2ae2580706
fix(asset): incorrect date difference calculation ( #26793 )
2021-08-10 16:37:48 +05:30
Saqib
363225d2ba
fix(asset): incorrect date difference calculation ( #26805 )
2021-08-10 16:37:23 +05:30
Subin Tom
793063bf4e
fix: pos return payment mode issue ( #26875 )
2021-08-10 15:57:30 +05:30
Frappe PR Bot
1ba04fdfe5
fix: pos profile not mandatory for Sales Invoice ( #26876 )
2021-08-10 15:47:36 +05:30
Marica
173c4c8564
Merge branch 'develop' into test-asset-lcv
2021-08-10 14:38:31 +05:30
marination
510e31952d
test: Serial no sanitation
2021-08-10 14:35:51 +05:30
marination
f22b858253
fix: Clean Serial No input on Server Side
2021-08-10 14:35:41 +05:30
rohitwaghchaure
f8b4d69ff1
Merge pull request #26596 from marination/serial-no-space
...
fix: Clean Serial No input on Server Side
2021-08-10 14:32:23 +05:30
Afshan
af2f5277d5
fix: pos profile not mandatory for Sales Invoice ( #26853 )
2021-08-10 14:16:16 +05:30
Marica
d14f63afdc
Merge branch 'develop' into test-asset-lcv
2021-08-10 14:07:42 +05:30
Marica
fd12f65047
Merge pull request #26854 from marination/asset-lcv-gl-entry-hotfix
...
fix: Faulty Gl Entry for Asset LCVs (#26803 )
2021-08-10 14:07:12 +05:30
marination
948386d85d
test: Serial no sanitation
2021-08-10 14:00:55 +05:30
Saqib
5719198576
feat: dynamic conditions for applying SLA ( #26806 )
2021-08-10 13:56:48 +05:30
Saqib
b37c6992df
Merge branch 'develop' into po-payment-terms
2021-08-10 13:37:31 +05:30
Anurag Mishra
24da00cada
fix: updating lead status while customer creation ( #26607 )
...
* fix: updating lead status while customer creation
* fix: changes requested
2021-08-10 13:17:41 +05:30
Marica
f6ea00e029
Merge branch 'develop' into serial-no-space
2021-08-10 13:17:08 +05:30
Anurag Mishra
94beda65ca
fix: updating lead status while customer creation ( #26606 )
...
* fix: updating lead status while customer creation
* fix: changes requested
2021-08-10 13:16:46 +05:30
marination
06b6b7e3cc
fix: Set CWIP Account in company at the start to avoid flaky test
2021-08-10 13:14:32 +05:30
marination
9ca2febd88
fix: Set CWIP Account in company at the start to avoid flaky test
2021-08-10 13:10:46 +05:30
Deepesh Garg
25a2f2b90e
Merge pull request #26579 from deepeshgarg007/discount_accounting_v13
...
feat: Enable discount accounting
2021-08-10 11:48:14 +05:30
Subin Tom
2ab62a4484
fix: Missing method reset_issue_metrics added back to Issue doctype ( #26574 )
2021-08-10 11:43:59 +05:30
Subin Tom
8db0f07115
fix: Missing method reset_issue_metrics added back to Issue doctype ( #26573 )
2021-08-10 11:43:43 +05:30
Noah Jacob
10ce2f5d6e
refactor: added naming series for pricing rule
2021-08-10 11:42:59 +05:30
noahjacob
dd86642037
refactor: removed py2 code
2021-08-10 11:41:29 +05:30
noahjacob
b214e624bb
style: fixed formatting
2021-08-10 11:41:29 +05:30
noahjacob
74bcb987f3
style: fixed formatting
2021-08-10 11:41:29 +05:30
noahjacob
4fb1b6b80c
fix: Sider
2021-08-10 11:41:29 +05:30
noahjacob
a4cea1e56d
refactor: variable names
2021-08-10 11:41:29 +05:30
noahjacob
3a663ac77f
test: changed test item name
2021-08-10 11:41:29 +05:30
noahjacob
c95d96e7ae
refactor: changed variable names
2021-08-10 11:41:29 +05:30
noahjacob
a9ef56a107
test: added test case for creating and updating
2021-08-10 11:41:29 +05:30
noahjacob
415519af15
feat: added multi-select fields to create multiple pricing rules.
2021-08-10 11:41:29 +05:30
Saqib
7eefe927a5
Merge branch 'develop' into payment-reconc-party-validation-fix
2021-08-10 11:37:56 +05:30
rohitwaghchaure
c5e7673277
Merge pull request #26814 from noahjacob/mr_allowance_feat_v13
...
feat: over transfer allowance for material transfers (bp #26264 )
2021-08-10 11:32:43 +05:30
Anupam Kumar
8e6d298fcf
Merge branch 'develop' into lead-cleanup
2021-08-10 11:32:43 +05:30
Deepesh Garg
797170e913
fix: Linting issues
2021-08-10 11:02:21 +05:30
Deepesh Garg
428ccebad9
test: Update test cases for discount accounting
2021-08-10 10:43:01 +05:30
Deepesh Garg
b73bb3e501
fix: Add discount account handling in Purchase Invoice
2021-08-10 10:42:47 +05:30
Deepesh Garg
9b561ea839
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into discount_accounting_v13
2021-08-10 10:38:14 +05:30
Deepesh Garg
cd980f5e6b
Merge pull request #26723 from GangaManoj/backport-po-payment-terms
...
feat: Fetch Payment Terms from linked Sales/Purchase Order
2021-08-10 10:34:39 +05:30
Afshan
f5b5be9644
Merge branch 'develop' into po-payment-terms
2021-08-10 09:32:08 +05:30
Afshan
a982a2a72e
Merge branch 'develop' into payment-reconc-party-validation-fix
2021-08-10 09:30:48 +05:30
Rohit Waghchaure
f571e42aa4
Merge branch 'version-13-hotfix' into merge-version-13-hotfix-into-v13-pre-9
2021-08-10 01:06:23 +05:30
Ankush
5e428f0447
perf(cache): fix active SLA doctype caching ( #26861 )
...
If no SLA is configured then this query runs on EVERY `validate` call.
Root cause: if not active SLA doctypes exist then `not []` evalutes to
true and causes query to run again.
2021-08-09 22:15:49 +05:30
Francisco Roldan
0a90302170
fix: depends_on in price list field
2021-08-09 11:41:56 -03:00
Francisco Roldan
7e3dd9e8ee
fix: depends_on in price list field
2021-08-09 11:21:41 -03:00
Deepesh Garg
75a832715c
test: Update test cases for discount accounting
2021-08-09 19:03:14 +05:30
Deepesh Garg
cb539b7a6a
fix: Add discount account handling in Purchase Invoice
2021-08-09 19:01:41 +05:30
Deepesh Garg
8b9c04aae8
test: Fix test cases for payment terms fetch
2021-08-09 18:53:15 +05:30
Deepesh Garg
802c6b3738
test: Improve test case for not coping payment terms
2021-08-09 18:53:15 +05:30
Deepesh Garg
bcf56e64ba
fix: Ignore default payment term templates when coping payment terms from orders
2021-08-09 18:53:14 +05:30
GangaManoj
072f63b324
Revert "fix: Only fetch default Payment Terms Template if present"
...
This reverts commit fb80ca9e06
2021-08-09 18:53:14 +05:30
GangaManoj
e247e3a4b2
fix: Only fetch default Payment Terms Template if present
2021-08-09 18:53:14 +05:30
GangaManoj
5b33e75c65
fix: Fetch discount details from Payment Terms only if Discount Type = Percentage
2021-08-09 18:53:14 +05:30
GangaManoj
0588382c38
fix: Stop fetching amount while fetching Payment Terms
2021-08-09 18:53:14 +05:30
GangaManoj
55cb82c74d
fix: Compare Payment Schedules
2021-08-09 18:53:14 +05:30
GangaManoj
1200872c7e
fix: Disable automcatically_fetch_payment_terms after running its associated tests
2021-08-09 18:53:13 +05:30
GangaManoj
7244afe129
fix: Rename test to reflect changes in code
2021-08-09 18:53:13 +05:30
GangaManoj
54d1336d11
fix: Condition for fetching Payment Terms from Sales/Purchase Orders
2021-08-09 18:53:13 +05:30
Frappe PR Bot
18bd182f61
patch: delete all orphaned tables docs ( #26863 )
2021-08-09 18:34:51 +05:30
Deepesh Garg
90cca2cb55
Merge branch 'develop' into payment-reconc-party-validation-fix
2021-08-09 18:06:33 +05:30
Anuja Pawar
08ae49cd11
fix(regional): add permissions for VAT Audit report ( #26851 )
...
fix(regional): add permissions for VAT Audit report
2021-08-09 17:58:52 +05:30
Frappe PR Bot
0ff9ef673c
fix: add parameter for db insert while adding item tax ( #26855 ) ( #26858 )
...
(cherry picked from commit b3bbebd27c
2021-08-09 17:58:18 +05:30
Anupam Kumar
d0d0be0a61
Merge branch 'develop' into lead-cleanup
2021-08-09 17:25:53 +05:30
Ganga Manoj
458f7f1194
patch: delete all orphaned tables docs ( #26743 )
2021-08-09 17:16:48 +05:30
Anupam Kumar
2f06c3e40d
Merge branch 'develop' into lead-cleanup
2021-08-09 16:07:04 +05:30
Ankush
9f5111809d
test: fix flaky purchase receipt test ( #26859 ) ( #26860 )
...
# Conflicts:
# erpnext/stock/doctype/purchase_receipt/test_purchase_receipt.py
2021-08-09 15:35:26 +05:30
Anupam
db3ee31413
fix: test case
2021-08-09 15:34:50 +05:30
Ankush
7ba8c821a1
test: fix flaky purchase receipt test ( #26859 )
2021-08-09 15:14:26 +05:30
Anupam
42bb77bf80
fix: creating contact on creation of lead
2021-08-09 15:11:13 +05:30
Frappe PR Bot
ea83e2b45f
fix: validate python expressions ( #26835 ) ( #26856 )
...
(cherry picked from commit 07337d5c78
2021-08-09 14:48:59 +05:30
Afshan
b3bbebd27c
fix: add parameter for db insert while adding item tax ( #26855 )
2021-08-09 14:39:32 +05:30
Anupam Kumar
9c04c297b8
refactor: Accounts Settings form cleanup ( #26842 )
2021-08-09 14:01:02 +05:30
harshpwctech
b0f3c0f3fd
fix: JWT decoding error ( #26624 )
2021-08-09 13:42:05 +05:30
Saqib
e7a77d9cb1
Merge pull request #26415 from GangaManoj/backport-asset-repair-refactor
...
refactor: Asset Repair
2021-08-09 12:46:05 +05:30
Ankush
07337d5c78
fix: validate python expressions ( #26835 )
2021-08-09 12:38:40 +05:30
Anupam Kumar
ef8539fd60
refactor: Selling Settings form cleanup ( #26841 )
2021-08-09 12:38:14 +05:30
Marica
a8166c06c7
fix: Faulty Gl Entry for Asset LCVs ( #26803 )
...
* fix: Faulty Gl Entry for Asset LCVs
- Both Gl entries were crediting in their respective accounts
- Asset Account must be debited into
* fix: Use keyword arguments instead of positional for better readability
* chore: Test for LCV for draft asset created via Purchase Receipt
2021-08-09 12:38:12 +05:30
Marica
ab8f0cab4d
fix: Faulty Gl Entry for Asset LCVs ( #26803 )
...
* fix: Faulty Gl Entry for Asset LCVs
- Both Gl entries were crediting in their respective accounts
- Asset Account must be debited into
* fix: Use keyword arguments instead of positional for better readability
* chore: Test for LCV for draft asset created via Purchase Receipt
2021-08-09 12:24:04 +05:30
Frappe PR Bot
210441d9b5
fix: price list with 0 value are ignored (bp #26655 )
...
* fix: price list with 0 value are ignored
Steps to reproduce:
1. Create 2 item price for two different supplier. One of them should be
zero.
2. Create PO
3. Add supplier with non-zero price and add item.
4. change supplier. Price won't change. If price was non-zero it
would've changed.
Root cause: falsiness check instead of null value check is used for
checking if price list value exists. 0 is evaluated as false.
* refactor: make get_price_list_rate function pure
(cherry picked from commit 16d4de5130
2021-08-09 11:34:33 +05:30
Frappe PR Bot
3dfbf19e8f
fix: allow alternative items when using job card (bp #26724 )
...
(cherry picked from commit 7e0c57fa3f
2021-08-09 11:33:55 +05:30
Frappe PR Bot
bba9aac9c0
feat: add french address template (bp #26316 )
...
* add french address template
Co-authored-by: HENRY Florian <florian.henry@open-concept.pro>
(cherry picked from commit 07e65ab589
2021-08-09 10:58:39 +05:30
Marica
4c929b6994
Merge branch 'develop' into serial-no-space
2021-08-09 10:50:09 +05:30
Marica
e9c293d621
Merge pull request #25845 from noahjacob/item_so_variant_fix
...
fix: production plan not fetching sales order of a variant
2021-08-09 10:47:54 +05:30
Ankush
7e0c57fa3f
fix: allow alternative items when using job card ( #26724 )
2021-08-09 10:46:29 +05:30
Ankush
16d4de5130
fix: price list with 0 value are ignored ( #26655 )
...
* fix: price list with 0 value are ignored
Steps to reproduce:
1. Create 2 item price for two different supplier. One of them should be
zero.
2. Create PO
3. Add supplier with non-zero price and add item.
4. change supplier. Price won't change. If price was non-zero it
would've changed.
Root cause: falsiness check instead of null value check is used for
checking if price list value exists. 0 is evaluated as false.
* refactor: make get_price_list_rate function pure
2021-08-09 10:41:24 +05:30
HENRY Florian
07e65ab589
feat: add french address template ( #26316 )
...
* add french address template
Co-authored-by: Ankush <ankush@iwebnotes.com>
2021-08-09 10:32:31 +05:30
Deepesh Garg
5ace2767af
test: Fix test cases for payment terms fetch
2021-08-08 19:17:38 +05:30
Deepesh Garg
25d131a39f
test: Improve test case for not coping payment terms
2021-08-07 17:39:40 +05:30
Deepesh Garg
a27ef14db6
fix: Override template only if setting is enabled
2021-08-07 00:12:57 +05:30
Deepesh Garg
a59a761f99
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into backport-po-payment-terms
2021-08-06 23:55:01 +05:30
Deepesh Garg
0bba425fe3
fix: Ignore default payment term templates when coping payment terms from orders
2021-08-06 23:53:16 +05:30
Frappe PR Bot
aec7846407
test: fix pricelist tests ( #26839 ) ( #26840 )
...
problem: exchange rate API is returning exchange rates for "_Test currency".
These tests were relying on failure of that function.
(cherry picked from commit 27a29eb6bc
2021-08-06 21:55:01 +05:30
Ankush
27a29eb6bc
test: fix pricelist tests ( #26839 )
...
problem: exchange rate API is returning exchange rates for "_Test currency".
These tests were relying on failure of that function.
2021-08-06 21:34:44 +05:30
Frappe PR Bot
9ea24db20a
test: use item that allows fractional UOM in test ( #26837 ) ( #26838 )
...
(cherry picked from commit 614336fe1d
2021-08-06 21:14:40 +05:30
Ankush
614336fe1d
test: use item that allows fractional UOM in test ( #26837 )
2021-08-06 19:36:21 +05:30
GangaManoj
fcbd79b7d3
Merge branch 'version-13-hotfix' of https://github.com/frappe/erpnext into backport-asset-repair-refactor
2021-08-06 18:12:24 +05:30
Saqib
f1141e7756
fix: failing budget test due to project naming ( #26834 )
2021-08-06 17:37:17 +05:30
Anupam
b4e720f8ec
fix: test case
2021-08-06 14:39:13 +05:30
Anupam
59c971015a
fix: test case
2021-08-06 14:02:57 +05:30
Saqib
668f442139
Merge branch 'develop' into po-payment-terms
2021-08-06 13:42:10 +05:30
Frappe PR Bot
c8e6c07032
fix(e-invoicing): cannot generate IRNs for standalone credit notes ( #26824 ) ( #26833 )
2021-08-06 12:33:18 +05:30
Anupam
01a0585ba0
fix: removing organization_lead traceback
2021-08-06 12:21:02 +05:30
Anupam
4723e18f9e
fix: sider issue
2021-08-06 11:16:55 +05:30
Noah Jacob
cb44aed78b
test: get sales order with variant
2021-08-06 11:16:25 +05:30
Deepesh Garg
ffd7642de2
Merge pull request #26832 from deepeshgarg007/budget_test_case
...
test: Failing budget test due to project naming
2021-08-06 11:14:47 +05:30
Saqib
e7fa2e5826
fix(e-invoicing): cannot generate IRNs for standalone credit notes ( #26824 )
2021-08-06 11:03:57 +05:30
Frappe PR Bot
2e352834a2
fix: fetching of item tax from hsn code ( #26736 ) ( #26792 )
...
* fix: fetching of item tax from hsn code
(cherry picked from commit 3a50490c04
2021-08-06 10:59:29 +05:30
Deepesh Garg
6871c07685
test: Failing budget test due to project naming
2021-08-06 10:53:38 +05:30
Frappe PR Bot
b13e46071a
fix: Let all System Managers be able to delete Company transactions ( #26815 ) ( #26819 )
...
(cherry picked from commit 884d8cf065
2021-08-06 10:39:58 +05:30
Nabin Hait
418d478dad
Merge pull request #26764 from nabinhait/addl_salary_fix
...
fix: Additional salary processing
2021-08-06 10:24:03 +05:30
Nabin Hait
894ed3a9a5
Merge pull request #26765 from frappe/revert-24206-additional_salary_tax_enhancements
...
Revert "fix: Tax calculation for Recurring additional salary"
2021-08-06 10:22:31 +05:30
GangaManoj
232c728636
Revert "fix: Only fetch default Payment Terms Template if present"
...
This reverts commit fb80ca9e06
2021-08-05 23:04:58 +05:30
GangaManoj
fb80ca9e06
fix: Only fetch default Payment Terms Template if present
2021-08-05 22:04:11 +05:30
GangaManoj
5c21eea13d
fix: Fetch discount details from Payment Terms only if Discount Type = Percentage
2021-08-05 21:50:09 +05:30
GangaManoj
e4a07d8ff3
fix: Stop fetching amount while fetching Payment Terms
2021-08-05 21:42:09 +05:30
Frappe PR Bot
6e07ec2617
fix: Do not fetch fully return issued purchase receipts ( #26809 ) ( #26825 )
...
(cherry picked from commit 1d90f7684e
2021-08-05 20:13:28 +05:30
Deepesh Garg
1d90f7684e
fix: Do not fetch fully return issued purchase receipts ( #26809 )
2021-08-05 19:17:32 +05:30
Noah Jacob
041ac339b1
style: improved formatting of sql query
2021-08-05 16:37:22 +05:30
Noah Jacob
b10465eebe
refactor: created function to get bom_item for query
2021-08-05 16:37:22 +05:30
noahjacob
9b0b2daf4a
refactor: updated sql query for item variants
2021-08-05 16:37:22 +05:30
noahjacob
cf4078756d
fix: fixed fetching sales order of item variant in production plan
2021-08-05 16:37:21 +05:30
Anupam
c35a526dd8
fix: adding test cases
2021-08-05 14:42:15 +05:30
Frappe PR Bot
5b5a365aaf
fix: POS payment modes displayed wrong total ( #26808 )
2021-08-05 11:15:16 +05:30
Ganga Manoj
884d8cf065
fix: Let all System Managers be able to delete Company transactions ( #26815 )
2021-08-05 11:14:46 +05:30
GangaManoj
4a6ef9ab0f
fix: Compare Payment Schedules
2021-08-05 00:52:55 +05:30
GangaManoj
0b11420147
fix: Disable automcatically_fetch_payment_terms after running its associated tests
2021-08-05 00:35:45 +05:30
Anupam
2732490cbe
fix: review changes
2021-08-05 00:30:01 +05:30
GangaManoj
23c104555b
fix: Remove irrelevant code
2021-08-05 00:28:42 +05:30
Frappe PR Bot
bf8d0c256d
fix: typo in error message ( #26816 ) ( #26817 )
...
(cherry picked from commit 005291e6dd
2021-08-04 22:01:17 +05:30
François de Ryckel
005291e6dd
fix: typo in error message ( #26816 )
2021-08-04 21:59:18 +05:30
Noah Jacob
673bc58193
test: test case for over transfer of materials
2021-08-04 18:48:24 +05:30
Noah Jacob
8fced95f8c
feat: over transfer allowance for material transfers
2021-08-04 18:48:24 +05:30
GangaManoj
8328f45230
fix: Rename test to reflect changes in code
2021-08-04 17:33:35 +05:30
Frappe PR Bot
13192e1db1
fix: trigger lost reason dialog when status is changed to lost ( #26811 ) ( #26812 )
...
(cherry picked from commit e5d8ba65ca
2021-08-04 17:07:22 +05:30
Mohammed Yusuf Shaikh
e5d8ba65ca
fix: trigger lost reason dialog when status is changed to lost ( #26811 )
2021-08-04 16:35:38 +05:30
Anupam Kumar
df477dcae6
fix: bank remittance report issue ( #26398 ) ( #26766 )
2021-08-04 14:02:43 +05:30
Subin Tom
035ce304fe
fix: POS payment modes displayed wrong total ( #26708 )
2021-08-04 13:57:55 +05:30
Saqib
5c9d4db0e9
Merge branch 'develop' into payment-reconc-party-validation-fix
2021-08-04 13:57:00 +05:30
Dany Robert
9f94c19752
fix: ignore permission to update call log ( #26797 )
...
Backport of #26112
#no-docs
2021-08-04 10:01:44 +05:30
Frappe PR Bot
1b9a5c851d
fix: incorrect amount in work order required items table. ( #26585 ) ( #26623 )
...
* fix: amount in work order not equal to rate * qty
* fix: patch for amount in work order required items
(cherry picked from commit cd12d95a24
2021-08-03 20:06:36 +05:30
Frappe PR Bot
85815f989c
fix: Reset weight_per_unit on replacing Item ( #26619 ) ( #26791 )
...
* fix: Assign Item's default weight_per_unit as its weight_per_unit in get_item_details
* fix: Set weight_uom in get_item_details as Item's default weight_uom
(cherry picked from commit 471f48f64d
2021-08-03 20:06:07 +05:30
Saqib
3a50490c04
fix: fetching of item tax from hsn code ( #26736 )
...
* fix: fetching of item tax from hsn code
2021-08-03 15:57:11 +05:30
Deepesh Garg
4e1a205c11
fix: Optimize item updation
2021-08-03 14:58:45 +05:30
Deepesh Garg
346bde875c
Merge branch 'develop' of https://github.com/frappe/erpnext into sa-vat-report
2021-08-03 14:44:20 +05:30
Ganga Manoj
471f48f64d
fix: Reset weight_per_unit on replacing Item ( #26619 )
...
* fix: Assign Item's default weight_per_unit as its weight_per_unit in get_item_details
* fix: Set weight_uom in get_item_details as Item's default weight_uom
2021-08-03 14:39:38 +05:30
Frappe PR Bot
5a442f1bce
fix: change format string to percent string interpolation ( #26774 ) ( #26778 )
...
(cherry picked from commit 7fe588e236
2021-08-03 13:29:10 +05:30
Frappe PR Bot
373ed1f65c
fix: remove limit from stock balance report ( #26773 ) ( #26779 )
...
(cherry picked from commit b3740e9afc
2021-08-03 13:28:50 +05:30
GangaManoj
f99696b75d
fix: Condition for fetching Payment Terms from Sales/Purchase Orders
2021-08-02 23:15:44 +05:30
Anuja
f2ee1155c0
fix: sider fixes
2021-08-02 23:13:21 +05:30
Ankush
efb037b566
refactor!: drop shopify integration from ERPNext ( #26700 )
...
BREAKING CHANGE: remove Shopify integration.
The integration is moved to a separate app with additional enhancements.
The app is still FOSS and licensed under the same license as ERPNext. Any
data migration required is taken care of after installing the app and
enabling it.
New app: https://github.com/frappe/ecommerce_integrations
2021-08-02 21:57:52 +05:30
Deepesh Garg
db40d88fc2
Merge pull request #26780 from nemesis189/added-dispatch-address-to-sales-v13-new
...
feat: Added dispatch address fields in Sales Ord, Sales Inv, Delivery Note for Eway Bill
2021-08-02 21:11:50 +05:30
Subin Tom
6ba11a382a
test: Updated test case for Eway bill
2021-08-02 20:36:46 +05:30
Subin Tom
8800aaaee7
feat: Added fields for dispatch address in Sales Order, Sales Invoice, Delivery Note for Eway Bill
2021-08-02 20:36:37 +05:30
Ankush
b3740e9afc
fix: remove limit from stock balance report ( #26773 )
2021-08-02 20:13:26 +05:30
Alan
7fe588e236
fix: change format string to percent string interpolation ( #26774 )
2021-08-02 20:07:55 +05:30
Ankush
e43bdf76a5
chore: warning for shopify integration deprecation ( #26701 )
...
* chore: warning for shopify integration deprecation
* fix: warn deprecation during patch for sysadmins
2021-08-02 18:57:48 +05:30
Anuja
3bcbc86291
fix: resolved conflicts in patches.txt
2021-08-02 12:58:46 +05:30
